From: Jayesh Choudhary <j-choudhary@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>,
<linux-kernel@vger.kernel.org>, <nm@ti.com>, <robh@kernel.org>,
<j-luthra@ti.com>, <u-kumar1@ti.com>
Cc: <kristo@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable analog audio support
Date: Mon, 24 Jun 2024 15:15:31 +0530 [thread overview]
Message-ID: <b3587597-0b0b-493e-baa7-16f9b87231be@ti.com> (raw)
In-Reply-To: <cfab6475-9224-44a6-b140-59f6ec243ab1@ti.com>
Hello Vignesh,
On 22/06/24 12:06, Vignesh Raghavendra wrote:
>
>
> On 12/06/24 10:42, Jayesh Choudhary wrote:
> [...]
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index bf3c246d13d1..426ae3e8a839 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -105,6 +105,16 @@ vdd_sd_dv: regulator-TLV71033 {
>> <3300000 0x1>;
>> };
>>
>> + vcc_3v3_aud: regulator-vcc3v3 {
>> + /* Output of LM5140 */
>> + compatible = "regulator-fixed";
>> + regulator-name = "vcc_3v3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> vsys_io_1v8: regulator-vsys-io-1v8 {
>> compatible = "regulator-fixed";
>> regulator-name = "vsys_io_1v8";
>> @@ -122,6 +132,35 @@ vsys_io_1v2: regulator-vsys-io-1v2 {
>> regulator-always-on;
>> regulator-boot-on;
>> };
>> +
>> + codec_audio: sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "J722S-EVM";
>> + simple-audio-card,widgets =
>> + "Headphone", "Headphone Jack",
>> + "Line", "Line In",
>> + "Microphone", "Microphone Jack";
>> + simple-audio-card,routing =
>> + "Headphone Jack", "HPLOUT",
>> + "Headphone Jack", "HPROUT",
>> + "LINE1L", "Line In",
>> + "LINE1R", "Line In",
>> + "MIC3R", "Microphone Jack",
>> + "Microphone Jack", "Mic Bias";
>> + simple-audio-card,format = "dsp_b";
>> + simple-audio-card,bitclock-master = <&sound_master>;
>> + simple-audio-card,frame-master = <&sound_master>;
>> + simple-audio-card,bitclock-inversion;
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&mcasp1>;
>> + };
>> +
>> + sound_master: simple-audio-card,codec {
>> + sound-dai = <&tlv320aic3106>;
>> + clocks = <&audio_refclk1>;
>> + };
>> + };
>> };
>>
>> &main_pmx0 {
>
> [...]
>
>> +&main_conf {
>> + audio_refclk1: clock@82e4 {
>> + compatible = "ti,am62-audio-refclk";
>> + reg = <0x82e4 0x4>;
>> + clocks = <&k3_clks 157 18>;
>> + assigned-clocks = <&k3_clks 157 18>;
>> + assigned-clock-parents = <&k3_clks 157 33>;
>> + #clock-cells = <0>;
>> + };
>
>
> Shouldn't this be in a SoC level dtsi? If the clock selection is based
> on board design, the only move the assigned-clocks* to board file and
> keep the rest in SoC level files.
>
Ok.
I will need to rebase on top of Siddharth's patches[0] which I see are
now merged.
Will do that and roll v3.
[0]:
https://lore.kernel.org/all/20240615081600.3602462-4-s-vadapalli@ti.com/
Thanks,
Jayesh
>
>> +};
>
prev parent reply other threads:[~2024-06-24 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 5:12 Jayesh Choudhary
2024-06-14 8:41 ` Jai Luthra
2024-06-22 6:36 ` Vignesh Raghavendra
2024-06-24 9:45 ` Jayesh Choudhary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3587597-0b0b-493e-baa7-16f9b87231be@ti.com \
--to=j-choudhary@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®