From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075B01DF72C for ; Sat, 21 Feb 2026 17:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771694447; cv=none; b=ITtpfLnA/4tWJlAKYL2T6BmpJMgIIkYkYQBmbkFLDsUgVt9WlBrB/XN8fXG/mTW3c7yaKWgXwE6jk7739ePKlycxsrMRm4hdacMzO+kJ5zfGBvF29gwEu98Lhtyaa0AZSeWPZ/gufQ4zZpsSgEP+pj7GfdEjwn60oNRPmDtYV5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771694447; c=relaxed/simple; bh=XR1dfhSVli1Pid5SiGZLLVjDw59pUdaRkrY0seSKhbs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fB7ZXPDXISb/6fCWAqtVRH12MNuiw+9EgEyuZJzBYSXTTXrgAbpsBnLa/FO2P8Y3XY37V2zsx5qdN96xjgC5UnB4xS3648JQ+QV9v3ozwaIQEeEcVtI/i9AGSxYyFLxbl8iYFI6NCcsGQh0B1u1zuPD0LMlwJ036W7qfQp1aXpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=djUMbE/T; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="djUMbE/T" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-45f015a3259so1033062b6e.2 for ; Sat, 21 Feb 2026 09:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771694445; x=1772299245; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y1EwBHrT2F5QUtAJqsFuE4k23yzqTehZiQCEqa4Nn1M=; b=djUMbE/TVh4H9VWSalEa3NJUaGoKYJdYa1AE2mH+P01K5wy6Kj2Xx5bsQSOr5vorY1 /UYdvezmio1+o4D0ye66j4fsNlvcpNlBVlhdPL6jsc5WPKV40jjdsHprkvWF1Ma8JH5B xmeRqjvXlF3nsTiUCk0tWaBhj2lsVi1OR+TYOtozGDkKjkoxt53rkwEJhPy1dNP9pEta /iHQj71HfWot2dyiDzp1JOQMdKDrHRPrZkqZ4R1xy5dkB9t6R9Km57gSog2rGWTRP5pN nj8qXUFXCPmrJU5kjQkdWQTz3ORKfjSbQrR0eDPQ7HplH318mXnSUp/l2J1BTEq9zDRM 6bDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771694445; x=1772299245; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y1EwBHrT2F5QUtAJqsFuE4k23yzqTehZiQCEqa4Nn1M=; b=XbRZ5zHMwWvp8JFQnP2hZaP5q8CsNiYVV2tVLts/B9zx1fJvm39gqWnQWkQThV41Vw qq00AnndTn9nzIwP7MXBuqwZmiV+Fv1/QX02sVdyp8XnosqEM173ujp7PJK0nl1JE6cw v+sPcQHZj3b4iVDOepsMhXsUagG0fUWmgUN9Mu8QI9rg/mTILAHK/RDLUJ5VDznwgGqs 4Lxe3l4t0c2BwGqHMPDNZwYGiSPIHLTvUijoRCReEDA2x3t+VvK8MF8faSDnfq7nH+mS o6xiauQ5GsASRQ+Yf7N+pZXwAZle+su0AAl9v77j2sfmk8p7sdEWNyafK89dfqDzGAV3 Ggtw== X-Forwarded-Encrypted: i=1; AJvYcCWpmBUatDEQnIGYJ1q3AhLvGKEH/E9Q80gvRBhwjFhE6Yt9YqswlOc0Q8/uQR168hAFCZ1khlCrIHbADAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3O7hVkhf58e0Z0v194YhEw7WXckOUg/QNauVW2rKjaigtfccp Dl7jdmiertMFVzO4G9ir5zHzZW3xHeeMNdZuAeYe7wyBqjoewlgae0Psp5MU7d/17ig= X-Gm-Gg: AZuq6aItAKwTIwQZ6q3ibkchmILJTclrpwHLQbidIZbFY0PtkxgfVfFim+iedt/JKzK nv1YpBZjuDx7iX9UwddLlHVXV8rPEFkcVMS7eh/SK/YDLbI/x38qqC5qndweQSyXrQ3IyXoRIZH 6CzyvOKT8pTo3JcH/rfcAUrueUipKrUMQ6bZcRZa0orsT6eLYukFFzlWapAQZ2Pj7tMJ0EDLFSj ojePklS/oRQ4/t4EeysLq4kF4uK9xCSThm96M17N9LkQlKBKP8R8lAMn9oO35esBbK+v0GP9mAN H7PXunz+a4nL7UrsUVjsIw/uqweA+Ct3p2kI4jS9t4yV+JPCaeev7EKlD0E/zi3rFLiZFpB1QWS 0YTVJVKvj6pHDqAv1Lffi9E7oPmGBUiAYcAHqzSEzxECj+4yYX0JVK271n+pMKprqO/0neXHNTy lcriy30IU6Hxy07RcRXVVnY67cywF0MAX6W8aZY5DcXURUURC5wz7Rqnwi2BCHIkrUHvIG2w== X-Received: by 2002:a05:6808:6507:b0:45e:a749:81ed with SMTP id 5614622812f47-4644619a0fdmr1930872b6e.25.1771694444784; Sat, 21 Feb 2026 09:20:44 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:611:96af:f385:64bf? ([2600:8803:e7e4:500:611:96af:f385:64bf]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4644a17aea2sm1847935b6e.12.2026.02.21.09.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Feb 2026 09:20:43 -0800 (PST) Message-ID: Date: Sat, 21 Feb 2026 11:20:42 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] iio: adc: ti-ads7950: switch to using guard() notation To: Andy Shevchenko , Dmitry Torokhov Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260219022929.3558081-1-dmitry.torokhov@gmail.com> <20260219022929.3558081-4-dmitry.torokhov@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/19/26 1:51 AM, Andy Shevchenko wrote: > On Wed, Feb 18, 2026 at 06:29:27PM -0800, Dmitry Torokhov wrote: >> guard() notation allows early returns when encountering errors, making > > guard()() > > // strictly speaking > >> control flow more obvious. Use it. > > I like the change, but... > >> Also variables that now only hold error codes (or 0) are renamed to >> "error" to make their purpose clearer. Normally I would not give my opinion on this, but since I wrote the driver originally, I will say please don't rename. I prefer to always use "ret". > > ...this does not belong to the patch. If you wish to rename, better doing > it separately. This, in particular, adds undesired churn in the change making > it unclear. >