mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_eberman@quicinc.com>, <quic_collinsd@quicinc.com>,
	<quic_lsrao@quicinc.com>
Subject: Re: [PATCH v2] soc: qcom: rpmh-rsc: Enhance check for VREG in-flight request
Date: Mon, 29 Jan 2024 11:57:54 +0530	[thread overview]
Message-ID: <b3643a21-d0a8-4c4c-85de-852055a2d08b@quicinc.com> (raw)
In-Reply-To: <dahguk6hyo35ydugwno5t5lbteporwkiddhvxp6uni5ggbtxcm@3bu6ptvg7mdg>

Hi,

On 1/19/2024 9:17 PM, Andrew Halaney wrote:

>> Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> 
> Just noticed I commented on v1 when v2 was already out, sorry. Copy
> pasting this just to keep it on the latest thread:
> 
> Two minor things:
> 
>      1. Does this deserve a Fixes: tag?
>      2. The Signed-off-by chain here confuses me, you sent the patch
>         so your SOB should be last, but then that makes me believe Elliot
>         was the author which I don't think is reflected here (no From:
>         line). Please read [0] for a bit more details
> 
> [0] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Yes, this looks good to have patch, will include fixes:  tag and will 
fix SOB in v3.

Thanks,
Maulik

  parent reply	other threads:[~2024-01-29  6:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  8:26 Maulik Shah
2024-01-19 10:34 ` Bryan O'Donoghue
2024-01-19 11:30   ` Bryan O'Donoghue
2024-01-19 15:47 ` Andrew Halaney
2024-01-19 17:59   ` Elliot Berman
2024-01-29  6:27   ` Maulik Shah (mkshah) [this message]
2024-01-20  0:18 ` Konrad Dybcio
2024-01-28  3:43 ` Bjorn Andersson
2024-01-29  6:20   ` Maulik Shah (mkshah)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3643a21-d0a8-4c4c-85de-852055a2d08b@quicinc.com \
    --to=quic_mkshah@quicinc.com \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_lsrao@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®