From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25245C433DB for ; Thu, 4 Feb 2021 14:31:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4B1964F5C for ; Thu, 4 Feb 2021 14:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236508AbhBDObb (ORCPT ); Thu, 4 Feb 2021 09:31:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236719AbhBDO0o (ORCPT ); Thu, 4 Feb 2021 09:26:44 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48451C0613D6 for ; Thu, 4 Feb 2021 06:26:02 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id u14so3751254wri.3 for ; Thu, 04 Feb 2021 06:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f+Kn5O5ZpiyxGVryHYtP1dHvnCa/0Doj6DjufSQG6+s=; b=YS4z1atagIUMZKBbTg3QsyHjE/1Ce1TAm1g38OcbL+DaaCudgKyGyJ92SJH42zsX4o pSaOnLZdh0aj4jek4bosFfEUVg6E42JOGYzdVhr5bvcRepLuke37hPevPn4XOOToG2/Y 54ftMvYMIxT77t56wHCgSvn1hhZdn8mvnZVL5IL8lSDlnUUGC8UdOMTCgC5YmDBrszY2 XthJ0EO+zWAKUpMU/7mMiR2j4tafLHb+NNFL/vTg5PM69hkH8l67NWOfmNo0veQkoxSj fK4CwX0Xn3y0uYQuqfsIqiDJ09MbceOStRnmrN9S4/up5ra85FU1FbncX15gvjVK8/eS uc9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f+Kn5O5ZpiyxGVryHYtP1dHvnCa/0Doj6DjufSQG6+s=; b=s6u+d7S8p2CWQE6M5WtTgj++tdPh7XDUIHQznCO58Vf5so3M7eZLzQSk4z5PiVIWab Z5X+FV1DM6eJ6ecCuBe+6Sc8Lku8FyJv6FaRcXDZzhlBzbh+FVSCs7fG529Y8U5rbs+q WJDoVbI19l6LnkrVL9Dt5c9cwTbaiPfNpdkV8m4H6e0QmRMgXcnZzvHeHPyR6I3+8dmV ceQWdqSvtT0neY/hPbDe9Mjfo+wUu3pS7tx5YQXDpu7LazENtvFyyEBA/n5a7tDOhemh Aa8cPaSK63Ty4Qwj206FhzJ0fZ7FXCPR1P5aPxBzltfcJm6KldEUh1BHIbXSxSyUFXBo sH5Q== X-Gm-Message-State: AOAM533olayornrC36PH3FQhAtgZlv7Yvd82nxHB+h1hMneiaR6V6FAJ XaR5qGLvbRR5vGiqExKcIJ2LdfO3b0L1/g== X-Google-Smtp-Source: ABdhPJy3YVPTtEMFX+kbmWAPhOQGMRkTso3UENHpJVHtcB2KmShXPEyR2Eaalgda73n4/ohX3xkeGA== X-Received: by 2002:adf:df0a:: with SMTP id y10mr9655161wrl.214.1612448761048; Thu, 04 Feb 2021 06:26:01 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id y11sm8062875wrh.16.2021.02.04.06.25.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Feb 2021 06:26:00 -0800 (PST) Subject: Re: [RESEND PATCH] nvmem: qcom-spmi-sdam: Fix uninitialized pdev pointer To: Subbaraman Narayanamurthy , Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <1612376126-31001-1-git-send-email-subbaram@codeaurora.org> From: Srinivas Kandagatla Message-ID: Date: Thu, 4 Feb 2021 14:25:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1612376126-31001-1-git-send-email-subbaram@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2021 18:15, Subbaraman Narayanamurthy wrote: > "sdam->pdev" is uninitialized and it is used to print error logs. > Fix it. Since device pointer can be used from sdam_config, use it > directly thereby removing pdev pointer. > > Cc: stable@vger.kernel.org > Signed-off-by: Subbaraman Narayanamurthy > --- Applied thanks, --srini > drivers/nvmem/qcom-spmi-sdam.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c > index a72704c..f6e9f96 100644 > --- a/drivers/nvmem/qcom-spmi-sdam.c > +++ b/drivers/nvmem/qcom-spmi-sdam.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved. > + * Copyright (c) 2017, 2020-2021, The Linux Foundation. All rights reserved. > */ > > #include > @@ -18,7 +18,6 @@ > #define SDAM_PBS_TRIG_CLR 0xE6 > > struct sdam_chip { > - struct platform_device *pdev; > struct regmap *regmap; > struct nvmem_config sdam_config; > unsigned int base; > @@ -65,7 +64,7 @@ static int sdam_read(void *priv, unsigned int offset, void *val, > size_t bytes) > { > struct sdam_chip *sdam = priv; > - struct device *dev = &sdam->pdev->dev; > + struct device *dev = sdam->sdam_config.dev; > int rc; > > if (!sdam_is_valid(sdam, offset, bytes)) { > @@ -86,7 +85,7 @@ static int sdam_write(void *priv, unsigned int offset, void *val, > size_t bytes) > { > struct sdam_chip *sdam = priv; > - struct device *dev = &sdam->pdev->dev; > + struct device *dev = sdam->sdam_config.dev; > int rc; > > if (!sdam_is_valid(sdam, offset, bytes)) { >