From: Oded Gabbay <ogabbay@kernel.org>
To: Malkoot Khan <engr.mkhan1990@gmail.com>
Cc: fkassabri@habana.ai, ttayar@habana.ai,
stanislaw.gruszka@linux.intel.com, kelbaz@habana.ai,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from if statement
Date: Wed, 3 Jan 2024 17:42:51 +0200 [thread overview]
Message-ID: <b3732d2b-f6cf-4bf7-af1d-3ee7c4acfd3a@kernel.org> (raw)
In-Reply-To: <20231228210858.114111-1-engr.mkhan1990@gmail.com>
On 28/12/2023 23:08, Malkoot Khan wrote:
> The coding style in the Linux kernel prefers not to use
> braces for single-statement if conditions.
> This patch removes the unnecessary braces from an if statement
> in the file drivers/accel/habanalabs/common/command_submission.c,
> which also resolves a coding style warning.
>
> Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
> ---
> drivers/accel/habanalabs/common/command_submission.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c
> index 3aa6eeef443b..39e23d625a3c 100644
> --- a/drivers/accel/habanalabs/common/command_submission.c
> +++ b/drivers/accel/habanalabs/common/command_submission.c
> @@ -1360,9 +1360,8 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args)
> return -EINVAL;
> }
>
> - if (!hl_device_operational(hdev, &status)) {
> + if (!hl_device_operational(hdev, &status))
> return -EBUSY;
> - }
>
> if ((args->in.cs_flags & HL_CS_FLAGS_STAGED_SUBMISSION) &&
> !hdev->supports_staged_submission) {
Thanks for the patch.
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Oded
prev parent reply other threads:[~2024-01-03 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 21:08 Malkoot Khan
2024-01-03 15:42 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3732d2b-f6cf-4bf7-af1d-3ee7c4acfd3a@kernel.org \
--to=ogabbay@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=engr.mkhan1990@gmail.com \
--cc=fkassabri@habana.ai \
--cc=kelbaz@habana.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®