From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20320C4167B for ; Wed, 29 Nov 2023 08:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232051AbjK2I4U (ORCPT ); Wed, 29 Nov 2023 03:56:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbjK2I4Q (ORCPT ); Wed, 29 Nov 2023 03:56:16 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DD1DBD50 for ; Wed, 29 Nov 2023 00:56:22 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E9022F4; Wed, 29 Nov 2023 00:57:09 -0800 (PST) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 840A73F6C4; Wed, 29 Nov 2023 00:56:20 -0800 (PST) Message-ID: Date: Wed, 29 Nov 2023 09:55:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] sched/fair: Use all little CPUs for CPU-bound workload Content-Language: en-US To: Pierre Gondois , linux-kernel@vger.kernel.org Cc: Qais Yousef , Vincent Guittot , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider References: <20231124153323.3202444-1-pierre.gondois@arm.com> From: Dietmar Eggemann In-Reply-To: <20231124153323.3202444-1-pierre.gondois@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/11/2023 16:33, Pierre Gondois wrote: > Running n CPU-bound tasks on an n CPUs platform: > - with asymmetric CPU capacity > - not having SD_SHARE_PKG_RESOURCES flag set at the DIE nit: DIE is now called PKG on tip sched/core. f577cd57bfaa - sched/topology: Rename 'DIE' domain to 'PKG' (2023-10-12 Peter Zijlstra) > sched domain level (i.e. not DynamIQ systems) > might result in a task placement where two tasks run on a big CPU > and none on a little CPU. This placement could be more optimal by > using all CPUs. > > Testing platform: > Juno-r2: > - 2 big CPUs (1-2), maximum capacity of 1024 > - 4 little CPUs (0,3-5), maximum capacity of 383 > > Testing workload ([1]): > Spawn 6 CPU-bound tasks. During the first 100ms (step 1), each tasks > is affine to a CPU, except for: > - one little CPU which is left idle. > - one big CPU which has 2 tasks affine. > After the 100ms (step 2), remove the cpumask affinity. > > Before patch: > During step 2, the load balancer running from the idle CPU tags sched > domains as: > - little CPUs: 'group_has_spare'. Indeed, 3 CPU-bound tasks run on a > 4 CPUs sched-domain, and the idle CPU provides enough spare > capacity. What is meant by 'idle CPU provides enough spare capacity? I thought the task (util_avg ~ 512_ does not fit on the sched group [1,3-5] when we consider util_avg/capacity (383) The calculated imbalance of ~350 is too small for the task-size and that's why we need the 'shr_bound(util, env->sd->nr_balance_failed)' to let the task load-balance if nr_balance_failed = 2? [...] > Similar issue reported at: > https://lore.kernel.org/lkml/20230716014125.139577-1-qyousef@layalina.io/ > > v1: > https://lore.kernel.org/all/20231110125902.2152380-1-pierre.gondois@arm.com/ > > Suggested-by: Vincent Guittot > Signed-off-by: Pierre Gondois Even though this cures only classical big.LITTLE it might have a positive effect on today's Arm DynamIQ Android systems with Phantom SDs when running benchmarks like Geekbench. [...] Reviewed-by: Dietmar Eggemann