From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56E53B530A for ; Thu, 9 Apr 2026 15:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749152; cv=none; b=i9JNcxPn68jaUrWULnDzB6bSitly+hMKrlRE8MK4g91au5LPUJ99EV3xtiQqSomcEL4jNYPnmcU1SqQT2wk8k352MQV38aJVwO0v0XMkHKXRzzcLtfR4JKXe0u/LLLTbB4+ctQIwHQOoAdWMn+h2cgcCeu5iaXKpn1nDIJQCVI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749152; c=relaxed/simple; bh=9VhZJJo1ygdNZ7TCtZth8WrDphwJqDTJXg2P9t77FzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hf6HoZSuLM+qzZHK87HzcqPC6Xr7u8t1OUluRuehRCopEE8KeqOI0m9IKo4Ng3khaxIvmDpvXF1aO7QpTWy9LwzMxTFiGa3Z43vclm3GGlmLBgbBscsyJyyEqktgsmkqi6zeygbfaYjuuGVK5l79sGBKm79BShXJuSLWMIBzASc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=Vmr4K6UU; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="Vmr4K6UU" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7dbcd92eda5so770218a34.2 for ; Thu, 09 Apr 2026 08:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775749149; x=1776353949; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3W63L8sSL/cmlr8dk45RzNHMgaS33g+6/2V8j5M410k=; b=Vmr4K6UUzPUu7EzP4TLLS2F9x6U6q4uPQuk6SnhERS9PcR+h7YS0STdimjvodB1DX3 kOBKiRLFNfTuDnNxmAg3MdQtX7+WUtJP0KvsqSdjATF/21E+QSceqXDBuxKcMuMRaJZo cARUqgAh9FGThsHscdmQL/ioCBfqdZCemdTmywyM5MLot/Nw5hmCapSft4GO9ZZHFKXH 9vrOZjKB24hoVVzoKthIOgHMEkX8av7J3B7aOCNJsSLRU2sS0UGZOTgWHJO93Uf1P+t1 nS2YbY+YD3FkYHklnfwN0OcQtKPp5HyI0qDrutoumhM83h36wEgogl0kt5uJNVpLO4lE ZLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775749149; x=1776353949; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3W63L8sSL/cmlr8dk45RzNHMgaS33g+6/2V8j5M410k=; b=ALEk2c7QSj1JQCXrtsEg8aywbOcJhPojxMFQtxT4sm1F4u0Nh5ZsrOH8FH/0GhN53k 7V+3KXWvqekNCLFP9XJzpu4fknSGudfuTdRi8yEQ1LZw2jisYAdeXaGchho+Lwack3PU 5qCa73jnXjXl0x3uxJNqH9LlkxrEjWIrWU5/zIFrYs6WByz/VL9iqPrVb5h/FIfSUg7h M9kt3VVonl8kZM+32djVcUf9tr1ZKzOMNVC3ou7Y2kFtzkCgors7qqsRavD7K7hHjaZX fwPDQS5zuftXk8s3+TaEJGkXXi7s0kv3nRm+cqJ/IPuB1UERFSvIL87QvYeqsfxQMMHN HDZQ== X-Forwarded-Encrypted: i=1; AJvYcCVLSVLGCVxwIZjnrMtpzuSE2OvBKyxiz3XoXjzXEsWlkzimWHNce3Msx0FEh0QFJj61iy2Olbvvn736tFA=@vger.kernel.org X-Gm-Message-State: AOJu0YwxBN1MjDcrjUKodC+S+rzevzI4f55Z6sim1j3Zo7ElJbW3fqTx BV5nsEycw44wwC3ASgJkxDSq98WtJ94mmfzZTBtHyjJgW3MBFY3GfKSL4bEpzaWTdPA= X-Gm-Gg: AeBDiet++Wu2SBLlPprtYFc4bPtg/75Uuxx5JbySpOdDLH+xscl2i0cRtAGwncWgmKy i6KVmY951yKJlOsbbUxYpNXI7QtE4XCzp1mjsv8t2Bcfhdy0bAcT+72UGjfLSMi10JktRkXiWwb cuDuqp+TilVHL/Le4W4zrykMk661L8YEl4P9hwp6hWTtfr9MrRrN3jL2RBk68eOt6BUQ6AE3F5O o/Wg1lW0rys26tPhMjJjqOvj2rgB75v41f6fk/g5NFPZfUy+DA5fsTQJkTnT7AsQLpp0jUxMv8T YMu2pqIppvEeNoR17Fe/yybRDzjeHvn58WboifowTm46d3TuJsAuz4rynd2z6Jf+Sc+Z/NoCuem RUPfvEvgcCW9QZXU80QhMG3bA2LSlgUgkqMEbRqSluu4dWRWBCZ3IcsK8i/4jaQQKvZSkMW/R2C wOTm/g5zOqlcy+Mou8aIO4g+v1zqZwj4JjIhfKY9kOQ+OPMRT5uUJhDZLWEhCLpydaDlPC60Wub A== X-Received: by 2002:a4a:e90d:0:b0:67e:aa1:8821 with SMTP id 006d021491bc7-6822123db74mr14009511eaf.64.1775749148827; Thu, 09 Apr 2026 08:39:08 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:a548:cf0c:d054:fd01? ([2600:8803:e7e4:500:a548:cf0c:d054:fd01]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-68bc4d03ea1sm15573eaf.0.2026.04.09.08.39.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 08:39:07 -0700 (PDT) Message-ID: Date: Thu, 9 Apr 2026 10:39:07 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: frequency: ad983x: replace do_div() with div64_ul(). To: Joshua Crofts , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: <2026040913-spherical-slacks-bc5b@gregkh> <20260409150157.1300-1-joshua.crofts1@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260409150157.1300-1-joshua.crofts1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/9/26 10:01 AM, Joshua Crofts wrote: > Coccinelle reported the following in both ad983x drivers: > do_div() does a 64-by-32 division, please consider using > div64_ul instead. > > Fix this by replacing do_div() with div64_ul(), which > safely handles 64-bit dividends and unsigned long > divisors across all architectures. > > Signed-off-by: Joshua Crofts > --- > v2: Please don't send v2 or later revisions in reply to v1. It breaks some workflows. Start a new thread instead. > - resent email with corrected addresses Instead of a v2, you can just add a RESEND prefix to the subject line in cases like this. But do include an explanation like this when you do that. > > drivers/staging/iio/frequency/ad9832.c | 3 ++- > drivers/staging/iio/frequency/ad9834.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index b87ea1781b..61ee93263a 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -115,7 +116,7 @@ static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) > { > unsigned long long freqreg = (u64)fout * > (u64)((u64)1L << AD9832_FREQ_BITS); I would expect checkpatch to complain that there is no blank line between variable declarations and the rest of the code here. > - do_div(freqreg, mclk); > + freqreg = div64_ul(freqreg, mclk); > return freqreg; We can just return directly now. return div64_ul(freqreg, mclk); > } > > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c > index d339d5e8e0..83d0e1360c 100644 > --- a/drivers/staging/iio/frequency/ad9834.c > +++ b/drivers/staging/iio/frequency/ad9834.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -101,7 +102,7 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout) > { > unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS); > > - do_div(freqreg, mclk); > + freqreg = div64_ul(freqreg, mclk); > return freqreg; ditto. > } >