From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166061B21BC for ; Mon, 13 Jan 2025 19:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796287; cv=none; b=U1n2oIis34CrkKu/2tudVC+vbpbuGR112cnv+SZVbKu0Jezz99vg69J44RhX0uvjO/a/wSQIqXmvd6WMAuObOaEtUeKtMkqU3L6Kzgz43Ov65oiqyxLqzEhLUcFYeZC3uDGKAbmObl2aZlyA7dMxfP9QBMNiok3mdTha3LP4wIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796287; c=relaxed/simple; bh=phDGQaTxU/yTSkJZYJR/LV8WD8o70wPyPyv73TSdVkk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YpoZbcvbauAIPMpV+h23pzH65A6727I0dxmgER0A3GN9WZJJupi0NkJLsT1hIabwAwg1TS7Ac/Pt9UTXjXGMeYjgoAmsUqnAdaq+B3nPX0P3xSIPnWS5a0eo6v7mKJ6gp0IWMR016iZiW1aOxmTUu4Xf/yLwFGVaVtO8USnB7j0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RR4OFbnr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RR4OFbnr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DEHU2N010364 for ; Mon, 13 Jan 2025 19:24:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AUOLFheOXaPn7vxOSNO6EuwVYDmzYgNLEdqYuajMpeg=; b=RR4OFbnroBM5qm0E p5NRoCQU7JDSJ5SXIFrd6rPqk3APLAwxMchaBNeGPWWT4sGlUjCMC6VZqtd7XX2C A2wcRfS4RTOUnWHBrRqlM1pB6PlTnClbWKPf+AkXfIjGevMke1y251dKg6kqejh2 LbTdb+79bw3wrTGzBwZATiiosPV5/7yDE5yHtCNzpYBEhlcFOdQKq2fUQ/o/3Gqz 9XG0Los0HPVqvXeCZNbXrtCpZ3EYwrPJxcLuxuyqigZ2+XjGmXibwDudlZXAaZVj gG7vE2w71YkJueQugEpQrQ7Z49S3O/WAnGv693A3KINBlJ9RY0fwFJyMGYzIvsu4 4+GwYQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4454fe0rgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Jan 2025 19:24:45 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-218cf85639eso126049465ad.3 for ; Mon, 13 Jan 2025 11:24:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736796284; x=1737401084; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AUOLFheOXaPn7vxOSNO6EuwVYDmzYgNLEdqYuajMpeg=; b=m6k+mtIx8PuVz72ckfeTtY/CH2PmA3AZTwKCoZqc6s42WE1E6quZsSw5d5HgV8RYdF ij3o4zxRwEcZZGS+8UPH2eHSowJ92n1IczyG8IiQy+8yXQwCzPrUYAbSNITgQpBJ68Lz 6Z6M6xMQ1uGyhGy4lBsowIFS8u+WEjRoC617lmba/nRSg63UwuvwIUtfUMNtB28wIzxj yKBG+Nlln7dLpvCWcjYB+K8YcMoGjRVfuzI9z/m++ZcSPD8aAXQ4+9Np2QgdZwLsj6jn Qi2o2mrJLN4nqaXvVFrFEoBs33Ak5HDXBOJH+zQZHfR1ailiF24j1CTSQE0bNWsEAHD+ SQ8g== X-Forwarded-Encrypted: i=1; AJvYcCV1uHHW0hIodWkfEknKS9UYjMxiPxom32UcizroAVW8ClmOydQ9OEH81/ukIvvtEU/oH2tFsiUyqOgr+rM=@vger.kernel.org X-Gm-Message-State: AOJu0YxmrPdtQRzVHXL73CnFg8qetnUcYcd5F1cgMwryj5F6aIv4RTe1 +FRGO3Viait7bpiSWa56813E5Q4FhbQ4D0ngvDQrgnNJVbX9v01fjU7wvIR14QcZnqTmXjZn1AF +7IuiREsCmVylrntGtZS09QCijPzDwuzLcWGEAEiEel/0yt3NPKRviF9TpeQvw7Y= X-Gm-Gg: ASbGnct2FXGvffKabTQesvJMByXGNyuo15F4/69qVzUiWKiDhcQ1SHWOAC6pb6M/mwb 3BzuahQ5ngMQcxfGTsUU4wsZZBaw9Os86JXVZ1Pa120/ltCkqnA/iIXyKwzEldF9yEvBAMONtSC PFi2NC8AJi0Ay5j0DL65jD0gGxt3w4fo+XFDRyHjt0ccugdne1H2Uvr14b6vbZ6V2Gui5JTIo+l nBJIxgkM+6BHsBS3aEZyb5HzHbi0Aqxcn5rZy/ud1wl5E52IVHvRvUyw5LRRNMotfRpG6Y/dtdS J80c6da5cvN+KnDWvgRgQs4pmz8LhgpBQ81Ma/hARbtnAE69FA== X-Received: by 2002:a05:6a20:841c:b0:1e1:a9dd:5a58 with SMTP id adf61e73a8af0-1e88d0b6d05mr38830007637.30.1736796284332; Mon, 13 Jan 2025 11:24:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmceM+8RgiF0n8czYoLDHjbC9BgEP6OqgjVvqDc4obk6V9Mr5uL/MP3NmNz6OUjD3DEuWoyQ== X-Received: by 2002:a05:6a20:841c:b0:1e1:a9dd:5a58 with SMTP id adf61e73a8af0-1e88d0b6d05mr38829963637.30.1736796283924; Mon, 13 Jan 2025 11:24:43 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4056a6b4sm6405859b3a.60.2025.01.13.11.24.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 11:24:43 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 11:24:42 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] wifi: ath12k: handle ath12k_core_reset() with hardware grouping To: Aditya Kumar Singh , Kalle Valo , Jeff Johnson , Karthikeyan Periyasamy , Harshitha Prem Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com> <20250109-fix_reboot_issues_with_hw_grouping-v1-9-fb39ec03451e@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-9-fb39ec03451e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: c8tYe6uMuKmSTLZ2E5bRj7I77jhD7oz4 X-Proofpoint-GUID: c8tYe6uMuKmSTLZ2E5bRj7I77jhD7oz4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130155 On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote: > Currently, in ath12k_core_reset(), the device is powered up immediately > after a power down. However, with hardware grouping, when one device > asserts, all partner devices also asserts. If there is a delay in > processing these asserts, by the time this device powers up, other devices > might still be asserting, leading to an overall recovery failure. > > To prevent this issue, ensure all asserts for a group are processed before > initiating the power-up sequence. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aditya Kumar Singh Acked-by: Jeff Johnson