From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E888335E555 for ; Mon, 2 Feb 2026 11:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770030197; cv=none; b=otuaRcvvywuLXwYzxkJKxP6076aK3OvMoM8z9Vyc91VR4tUtU2EZf4gSwe7rbxu0ZNnKd1HpI+SWOh3im3dwOptyfs6wW1n8Sd/xMs1zaUOrpnU0ceHJu3cJ0bZzgC+MBDBhK3k/YOAK6FqQmxTxmOwZbitQruVN49HENVel76I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770030197; c=relaxed/simple; bh=ZoHT2X0+QvQ8zCJ3HO2LuvlEtbnfqKt+TG48smM9Xh4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jxZ4OYnVZmyyVwC1nDxSz1vuMjyDxclaCu/pzBgN7McThzp0V1QkpJOBDkY6+sH1SQnTWBmZSfaUyk/89QKpfd/FhH0kMpt7CH4cN4kG2h3AoQ6nnObQIdZFpZFCw2VAZtrOzVkvOw2ww2jNz65E+vXwErJmnO6/upK0tNAf1ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IEJMaWhl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dKdntOhU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IEJMaWhl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dKdntOhU" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612B0LWQ2899840 for ; Mon, 2 Feb 2026 11:03:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EU833LKChgISNL/htkFr48l7qcug469mq9IdafE2GVs=; b=IEJMaWhl3c5b5apc xO8FumxU4AhT2KLyQuN0i0m/Wgu+7TP/69wyRbal5+7lQOv/gcedJfP9jlk7biB6 YN5RORsYaUsCq1AGyQ44TRs55iuGpqSR2HKl4RroB5+FzNhUvT1AVTfnZI0JSw+1 Wz7JJ/uYkKVTcjZvm9rZSh4SS0n+7Z3dCF9+hBhRP8W6hpMspsP2rQ7MOW1udpTu e4u2UlNJl7waz4lWoeJygkZLQJ4AvzT/s9RTOHIZNkDBUxlQnlMU4AKv4l4saKb0 9wx1Z4ru3ZSHQ//jjQUzZyC30cTo+XScJ05y7CMFVcKaWhEpgyF3UIHsiGsnaeAd PmNADg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2tp0r09s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 11:03:12 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c53892a195so61637885a.3 for ; Mon, 02 Feb 2026 03:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770030192; x=1770634992; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EU833LKChgISNL/htkFr48l7qcug469mq9IdafE2GVs=; b=dKdntOhUx5B5GI04zPS5A/OHjcMIs5JhCv+QPAKdYhcNXZ3T9ddf1KpZWIzowlNx1S tsY34xDBDvqAmyA55SPtx7mY1exk74oxU9l7wIG01sf3ws+sgy8wpZ0PjX5mVrril6ow hmyTZkdacN9V33GCfQS9F6qUDus60mAhML0k+Uw7qwFqucblTzpCI4qmUsvWj71nHY7L InzOPW6O6CyPrRAEF6E+016ygDdSQsreIT4mi+/dhfYwGYslZsGT2QkZTWj6SQbAWqKQ oviUkeT9k23DjHJomD4Kvk1QVyEd5qaF9MhkYbB2UlPH0CmCs2O4ju0Hdk9Hy8hceF2M mgkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770030192; x=1770634992; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EU833LKChgISNL/htkFr48l7qcug469mq9IdafE2GVs=; b=Q9Rbd1ddjbDRrQClL4S6BUe6dKgxa7YIOViECFIcDm3a+DwlQ0DGVDetOwUeO/kQxp lT9ZdIF7mjhpU1m33jbb5DhsaW9pYd9wZ2JAzA9/fKfirhgC4D8R9r4Amfi+R9rZfpSe eSLAY7m89mLJhlhjI4XKv1DO0Qott9FVLlZibslw4pUKvN6GqCsClbLu6RGl1o6bry7S fNnHAqsfp/85XKiw3kY8Lynr0phDj7RydyxZX8wp0CABBhOQhd3SA2vXq99UISdehzd6 EddjL0Y/RB+AsjFUkQDJ6x3/OPfYPhkIVh60smO6ktYcRZQQZXvs5Nwu+d9xqY5Sie9U jztw== X-Forwarded-Encrypted: i=1; AJvYcCWc9wuKPWG6w2X1rSrW60EGlq4x/fzJk+d/K/qftp7bnXoaDa5Kq377gza4hSW/DCt+krFBdCi4v0lmCuk=@vger.kernel.org X-Gm-Message-State: AOJu0YyFti4dxWsD6d55gDVKz6uXFjlwVk1PU+WBtCTQwPdKqjEAwMif ZbL4wYsIY9z83FvQy97TpC1BEOPd8KGdLKoaS+aA54tpcYlUw/OUp9eMJ93CdxBryhxrcnuVJL1 j5XuBGOZGvpjV5d56CU8CI1xqs8O3POk3sYB1KG7HBO0ZIK9RfsbgwXsWk6yQgyHDWnyzYk6tqv s= X-Gm-Gg: AZuq6aJSgbsoh3DxPMrjEyCE1+lqfOgJvOl7e1FvjMnytcn4eFFbKYXqw4Ie62Rq8mr Lq2eg/JgcKXm7+7T3SgrXw4AuJy2EDHkoFW3yqJns+GerjgBVIIKWg9k5ugedtmCIxFOfsqGH0Q gpyXuMuZUu4AMCy/omL22FW5408jU0AG8SFZ2m6hxt3jBNihj87yQ+6zHQbr1hOlBrcdn3hzKxj jsI69fpx6ZsNUi2xQDUtPTgZJ6OO/vBb5Xr5t0uJvLZ0/QKdsQUfnzY+Fv5I5HZVGssMsn51IVJ bZwZTq0zN13SHDBRJIftp20b22+jjWT4hJx+P3b/Cw/nE5omGDT2MF/C0cGueGZjl+vEXpMD4XR TxjyMtUuDUn3j0Zm52M/CN/xsng0vQwZMQVQudvxxmgwbouOAQIqXulA/4ibAnk8lcgI= X-Received: by 2002:a05:620a:17aa:b0:8c6:ab77:f95e with SMTP id af79cd13be357-8c9eb352ba1mr1019639385a.11.1770030191659; Mon, 02 Feb 2026 03:03:11 -0800 (PST) X-Received: by 2002:a05:620a:17aa:b0:8c6:ab77:f95e with SMTP id af79cd13be357-8c9eb352ba1mr1019636785a.11.1770030191117; Mon, 02 Feb 2026 03:03:11 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e04be76afsm533984866b.36.2026.02.02.03.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 03:03:10 -0800 (PST) Message-ID: Date: Mon, 2 Feb 2026 12:03:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS To: Odelu Kukatla , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20260202070534.1281652-1-odelu.kukatla@oss.qualcomm.com> <20260202070534.1281652-2-odelu.kukatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202070534.1281652-2-odelu.kukatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: aG8o7HK1obTII8jubvnub8uK2cmjUAEr X-Authority-Analysis: v=2.4 cv=VJ/QXtPX c=1 sm=1 tr=0 ts=69808470 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=34g_aVeATRGB19fa1OcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4OCBTYWx0ZWRfXzug72UL85bJV BpS2GAYg9mJub/SMUD6fJQUJXmko9HBNEhV3msqHLMtCKj9xNcnkB6AWExzTNj+7SGbh0McTQdr +sQ1f0xtw6zhYgOSBnvmmaRAs4GwLzxRcnsyIpmvywLrizU5Of/zAzZ4sI+Ru11915Ka2wB1Y4n zJaKVQj6RkrJF1JcghVM1yg4jglwid78ZyMDGf/8Vf0wewIgMZgA+p+7cU3ItzTXaueeB6ZoqAZ /AdWlkN9MJIzwj4MPLVZdcVVjzdSuUyO8J89WAMejcA8JvAp6Ax0ZAgbPvNm44IGqLkmp97iqXl NzEeWseVKjjVKet5Kah60vyOaGAoa2074PISgkgmquEo41TOtYMQQ0H+xBZwWby2scc+9mBTqAH M9DoNgoBvFMk03hSQg+5N+9RfwHbPBXtPWgquj8fFiT643KF93xfO3omlmJEZc7zO0EYvMSY66Q 3okuTpo11JUPgYXgE5g== X-Proofpoint-GUID: aG8o7HK1obTII8jubvnub8uK2cmjUAEr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020088 On 2/2/26 8:05 AM, Odelu Kukatla wrote: > Aggre1-noc interconnect node on QCS615 has QoS registers located > inside a block whose interface is clock-gated. For that node, > driver must enable the corresponding clock(s) before accessing > the registers. Add the 'clocks' property so the driver can obtain > and enable the required clock(s). > > Only interconnects that have clock‑gated QoS register interface > use this property; it is not applicable to all interconnect nodes. > > Signed-off-by: Odelu Kukatla > --- > .../interconnect/qcom,qcs615-rpmh.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml > index e06404828824..096a9064cc01 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml > @@ -34,6 +34,10 @@ properties: > reg: > maxItems: 1 > > + clocks: > + minItems: 3 > + maxItems: 3 > + > required: > - compatible > > @@ -53,6 +57,36 @@ allOf: > required: > - reg > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,qcs615-aggre1-noc > + then: > + properties: > + clocks: > + items: > + - description: aggre UFS PHY AXI clock > + - description: aggre USB2 SEC AXI clock > + - description: aggre USB3 PRIM AXI clock Should we also include the IPA clock here? Konrad