From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20F311BC46 for ; Mon, 23 Feb 2026 20:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771878782; cv=none; b=j1Qhe4d8X6xh3v9Gy0s3SteC4OSi1lk8RwQHR6nZdCyZTXLRgwtIIyVhtRoO1InUUt4N0vkHJse6cS3wY2fqJA74J/FDdXPVayWCxkbvqunF+9Vb+KGBi7ez9r4cWhqyvl2vuH+dBtm7/ziKmYgcQBkQ9uNB5QbMcw/e87VB5h8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771878782; c=relaxed/simple; bh=6RU4qc7uAz2eInB+FSJK/iez4rLI2uGvzeq5zQw8LGE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OGqmfhBSKeMG+B5Gd4EqZq94mM/Aky304d5/nlGnu2bUL2M4jv0/dooBqvIh8kFJVYA7MIVBCdyyiJVi5YRtyotSxPcIo47XDiS3n8lfEoX5uMeL6+AxHA12xNywlrcxxS0a/rOwit80SsBa2ui5OFYpDGW7vnuAeNMdaip6F00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FQkPCBpz; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FQkPCBpz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771878781; x=1803414781; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6RU4qc7uAz2eInB+FSJK/iez4rLI2uGvzeq5zQw8LGE=; b=FQkPCBpzBhT62JvkzMT1Fq8aUbAxcTxXCXwl9u/kitOcALcp8LJfGSYf h453ksJsdYMsmfhogGh4MYtXGotE/hTNx+cq3k3Q3WW2P4se11Y7ZyKKD +471a2BuHpz5/ZxG+Y9izQS8XrRp57Hhsc0dGuMfMkuoSC4lxG8wDC3S5 2kG5MUrY5kNwfRfy+y83dx40+mKFtxiIEtGEaYcQA8l0b2JEITk1PQtzJ d0FnSWUSGIenZ8BV/XfwiYfBBhtGhS6OS6Zv2m23HjvLIACTJMQBni8lk iDUvESFU0iruYAk5uP2cftsM6BKOlpSWvDxchsOo1p9YNgO1DCxmHeWYc w==; X-CSE-ConnectionGUID: 0V9zuz7PT0m5N88YbArg1Q== X-CSE-MsgGUID: WrBuuow4Su2/MhvEO9yNAQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="60459820" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="60459820" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 12:32:59 -0800 X-CSE-ConnectionGUID: JVscniskSyq5/RGTqgwJDQ== X-CSE-MsgGUID: wW9/LY/bSj+FNwJS/iKTxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="220673610" Received: from unknown (HELO [10.24.81.147]) ([10.24.81.147]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 12:32:59 -0800 Message-ID: Date: Mon, 23 Feb 2026 12:33:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 05/13] x86/mm: Reset tag for virtual to physical address conversions To: Maciej Wieczor-Retman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra Cc: Maciej Wieczor-Retman , Alexander Potapenko , linux-kernel@vger.kernel.org References: <51598144b682a57f50ec8da65a52b005701f309e.1768845098.git.m.wieczorretman@pm.me> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <51598144b682a57f50ec8da65a52b005701f309e.1768845098.git.m.wieczorretman@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > #ifdef CONFIG_X86_64 > #include > @@ -65,6 +66,13 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr, > * virt_to_page(kaddr) returns a valid pointer if and only if > * virt_addr_valid(kaddr) returns true. > */ > + > +#ifdef CONFIG_KASAN_SW_TAGS > +#define page_to_virt(x) ({ \ > + void *__addr = __va(page_to_pfn((struct page *)x) << PAGE_SHIFT); \ > + __tag_set(__addr, page_kasan_tag(x)); \ > +}) > +#endif Can we pretty please keep this in arch-independent code? The idea of tags is not x86-specific and I can almost guarantee that x86 won't be the last one needing this. On to the rest... > Reset the pointer's tag by sign extending the tag bits in macros that do > pointer arithmetic in address conversions. There will be no change in > compiled code with KASAN disabled since the compiler will optimize the > __tag_reset() out. Nit: there's no "macro" for the rest. They're functions. I also don't _care_ how __tag_reset() works here. Don't explain implementation details. > index 2f0e47be79a4..01f9e6233bba 100644 > --- a/arch/x86/include/asm/page_64.h > +++ b/arch/x86/include/asm/page_64.h > @@ -22,6 +22,7 @@ extern unsigned long direct_map_physmem_end; > > static __always_inline unsigned long __phys_addr_nodebug(unsigned long x) > { > + x = __tag_reset(x); > unsigned long y = x - __START_KERNEL_map; > > /* use the carry flag to determine if x was < __START_KERNEL_map */ > diff --git a/arch/x86/mm/physaddr.c b/arch/x86/mm/physaddr.c > index 8d31c6b9e184..8f18273be0d2 100644 > --- a/arch/x86/mm/physaddr.c > +++ b/arch/x86/mm/physaddr.c > @@ -14,6 +14,7 @@ > #ifdef CONFIG_DEBUG_VIRTUAL > unsigned long __phys_addr(unsigned long x) > { > + x = __tag_reset(x); > unsigned long y = x - __START_KERNEL_map; I know all the virt-to/from-phys functions are a mess. But could we please take a wee peek here at refactoring them so this doesn't need to be done *twice*? I also think the changelog here needs to include something about the idea that arbitrary kernel pointers are assumed to be tagged and that these functions mostly accept those arbitrary pointers. > @@ -35,6 +36,7 @@ EXPORT_SYMBOL(__phys_addr); > > bool __virt_addr_valid(unsigned long x) > { > + x = __tag_reset(x); > unsigned long y = x - __START_KERNEL_map; > > /* use the carry flag to determine if x was < __START_KERNEL_map */ It also occurs to me that having a helper that does: x - __START_KERNEL_map; it could do the tag reset, which might consolidate all of these sites.