mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Andrej Picej <andrej.picej@norik.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, upstream@phytec.de
Subject: Re: [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem
Date: Tue, 4 Jul 2023 10:15:55 +0200	[thread overview]
Message-ID: <b382e51d-2f57-c4ab-7590-2083bd771abd@pengutronix.de> (raw)
In-Reply-To: <20230704080304.816942-3-andrej.picej@norik.com>

Hello Andrej,

On 04.07.23 10:03, Andrej Picej wrote:
> If regulator is not marked as always-on the regulator gets disabled on
> reboot breaking the next boot.

While this is ok as a fix, the real issue is that your system reset doesn't
restore PMIC rails to a good state. Are you perhaps doing a SoC-internal
reset only or have the PMIC misconfigured?

Cheers,
Ahmad

> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 80adb2a02cc9..25d6a036d5b8 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -192,6 +192,7 @@ vdd_3v3_pmic_io_reg: ldo6 {
>  			vdd_sd0_reg: ldo9 {
>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
>  			};
>  
>  			vdd_sd1_reg: ldo10 {

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


  reply	other threads:[~2023-07-04  8:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  8:03 [PATCH 0/2] PHYTEC i.MX6 device-tree fixes Andrej Picej
2023-07-04  8:03 ` [PATCH 1/2] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
2023-07-04  8:03 ` [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem Andrej Picej
2023-07-04  8:15   ` Ahmad Fatoum [this message]
     [not found]     ` <02d491bb-2a40-4909-ebc3-be2e183cfcbb@norik.com>
2023-07-05  8:26       ` Ahmad Fatoum
2023-07-04  8:17   ` Marco Felsch
2023-07-05  8:28     ` Andrej Picej
2023-07-05  8:30       ` Ahmad Fatoum
2023-07-05  8:40         ` Andrej Picej
2023-07-05 10:39           ` Andrej Picej
2023-07-05 12:06             ` Ahmad Fatoum
2023-07-07  9:28               ` Andrej Picej
2023-07-12  8:54                 ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b382e51d-2f57-c4ab-7590-2083bd771abd@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=andrej.picej@norik.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=upstream@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®