From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
Sameer Nanda <snanda@google.com>,
David Decotigny <david.decotigny@google.com>
Subject: [PATCH net v2 2/8] forcedeth: new ethtool stat "tx_timeout" to account for tx_timeouts
Date: Thu, 3 Nov 2011 18:41:17 -0700 [thread overview]
Message-ID: <b38a03bc1edbd129ae39b74ebb379d2354d8a45b.1320369398.git.david.decotigny@google.com> (raw)
In-Reply-To: <cover.1320369398.git.david.decotigny@google.com>
In-Reply-To: <cover.1320369398.git.david.decotigny@google.com>
From: Sameer Nanda <snanda@google.com>
This change publishes a new ethtool stats: tx_timeout that counts the
number of times the tx_timeout callback was triggered.
Signed-off-by: David Decotigny <david.decotigny@google.com>
---
drivers/net/ethernet/nvidia/forcedeth.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 64b1c7c..c82a3c7 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -633,6 +633,7 @@ static const struct nv_ethtool_str nv_estats_str[] = {
{ "rx_packets" },
{ "rx_errors_total" },
{ "tx_errors_total" },
+ { "tx_timeout" },
/* version 2 stats */
{ "tx_deferral" },
@@ -673,6 +674,7 @@ struct nv_ethtool_stats {
u64 rx_packets;
u64 rx_errors_total;
u64 tx_errors_total;
+ u64 tx_timeout;
/* version 2 stats */
u64 tx_deferral;
@@ -2534,6 +2536,8 @@ static void nv_tx_timeout(struct net_device *dev)
spin_lock_irq(&np->lock);
+ np->estats.tx_timeout++;
+
/* 1) stop tx engine */
nv_stop_tx(dev);
--
1.7.3.1
next prev parent reply other threads:[~2011-11-04 1:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 1:41 [PATCH net v2 0/8] forcedeth: minor fixes for stats, rmmod, sparse David Decotigny
2011-11-04 1:41 ` [PATCH net v2 1/8] forcedeth: Improve stats counters David Decotigny
2011-11-04 14:54 ` Stephen Hemminger
2011-11-04 17:17 ` David Decotigny
2011-11-04 1:41 ` David Decotigny [this message]
2011-11-04 1:41 ` [PATCH net v2 3/8] forcedeth: allow to silence tx_timeout debug messages David Decotigny
2011-11-04 1:41 ` [PATCH net v2 4/8] forcedeth: Acknowledge only interrupts that are being processed David Decotigny
2011-11-04 1:41 ` [PATCH net v2 5/8] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-04 1:41 ` [PATCH net v2 6/8] forcedeth: Fix a race during rmmod of forcedeth David Decotigny
2011-11-04 3:46 ` Ben Hutchings
2011-11-04 17:22 ` David Decotigny
2011-11-05 22:16 ` David Decotigny
2011-11-04 1:41 ` [PATCH net v2 7/8] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-04 1:41 ` [PATCH net v2 8/8] forcedeth: fix a few sparse warnings (variable shadowing) David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38a03bc1edbd129ae39b74ebb379d2354d8a45b.1320369398.git.david.decotigny@google.com \
--to=david.decotigny@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snanda@google.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®