Re: [PATCH net-next] net: phy: add driver for the ZTE ZX279128S internal Gigabit PHY

[Andrew Lunn <andrew@lunn.ch>]

> +static int zte_gephy_config_init(struct phy_device *phydev)
> +{
> +	int ret, i, ldo;

Given how minimal this driver is, there are some potential traps we
could fall into later when we find out more about the device. To
reduce the risk a bit, please could you add a test here:

       if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
         	  return -EINVAL;

> +static struct phy_driver zte_gephy_driver[] = {
> +	{
> +		PHY_ID_MATCH_MODEL(ZTE_GEPHY_PHY_ID),
> +		.name			= "ZTE ZX279128S Gigabit PHY",
> +		.flags			= PHY_IS_INTERNAL,
> +		.config_init		= zte_gephy_config_init,
> +		/* The boot firmware hands over with BMCR_PDOWN set. No
> +		 * .suspend: powering the analog domain down and up at runtime
> +		 * has not been tested.
> +		 */
> +		.resume			= genphy_resume,

It looks odd with just resume, it makes it look like a workaround.

Why not have config_init() take it out of power down?

    Andrew