From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel test robot <lkp@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Simek <monstr@monstr.eu>, Mike Rapoport <rppt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arvind Sankar <nivedita@alum.mit.edu>,
Ira Weiny <ira.weiny@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v1] microblaze: tag highmem_setup() with __meminit
Date: Tue, 2 Mar 2021 10:04:47 +0100 [thread overview]
Message-ID: <b38b353b-7138-373b-057a-a4fa4b4ab30e@redhat.com> (raw)
In-Reply-To: <20210301221846.GA4744@localhost.localdomain>
On 01.03.21 23:18, Oscar Salvador wrote:
> On Mon, Mar 01, 2021 at 12:47:49PM +0100, David Hildenbrand wrote:
>> With commit a0cd7a7c4bc0 ("mm: simplify free_highmem_page() and
>> free_reserved_page()") the kernel test robot complains about a warning:
>>
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in
>> reference from the function highmem_setup() to the function
>> .meminit.text:memblock_is_reserved()
>>
>> This has been broken ever since microblaze added highmem support,
>> because memblock_is_reserved() was already tagged with "__init" back then -
>> most probably the function always got inlined, so we never stumbled over
>> it.
>
> It might be good to point out that we need __meminit instead of __init
> because microblaze platform does not define CONFIG_ARCH_KEEP_MEMBLOCK,
> and __init_memblock fallsback to that.
>
> (I had to go and look as I was puzzled :-) )
>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks!
Whoever feels like picking this up (@Andrew?) can you add
"We need __meminit because __init_memblock defaults to that without
CONFIG_ARCH_KEEP_MEMBLOCK" and __init_memblock is not used outside
memblock code.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-03-02 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 11:47 David Hildenbrand
2021-03-01 22:18 ` Oscar Salvador
2021-03-02 9:04 ` David Hildenbrand [this message]
2021-03-02 13:28 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38b353b-7138-373b-057a-a4fa4b4ab30e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=monstr@monstr.eu \
--cc=nivedita@alum.mit.edu \
--cc=osalvador@suse.de \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®