From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CBCFC433ED for ; Tue, 20 Apr 2021 15:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6A961154 for ; Tue, 20 Apr 2021 15:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbhDTPTJ (ORCPT ); Tue, 20 Apr 2021 11:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232835AbhDTPTH (ORCPT ); Tue, 20 Apr 2021 11:19:07 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72057C06174A for ; Tue, 20 Apr 2021 08:18:35 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id z6so2601044wmg.1 for ; Tue, 20 Apr 2021 08:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y1sA+aQaPXL3h/YxiPjTBbVYUS1bVeZ4E2z5caxyFkY=; b=SiOBPrzDeT9AymLJHMv9IvbQ7nLqL+nb1TKmYCV7VsfPhLlQOf0Ww3Z7aLhbBJJ2J7 OYvZhXQ2PcccyOWO889NYZlaih9v/nwWiBt4R8QDJ9WAUu6PFOx6lXbSn2vhmGZG2Rqz /WQHdpc3pzD6MdrnGs7eCwtXUKYxT3AmLCM/durulne/9yAQRHQT6v7P1snV//B0aYZl yuEmfxLSyWQfFs9S3gZdyRzZbLiSmAyb8hJrEpZsVaWDZ8fzRee3usTVLMSAFMmg143v 4NnQjh8JjZg47o7chfVQCx3x4f5SYume8hTOPnxwWj1ehak2ZwymmKRyIlHlEwZWgpc1 H4WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y1sA+aQaPXL3h/YxiPjTBbVYUS1bVeZ4E2z5caxyFkY=; b=Pi11xZovVyFNvndmhiuxnWZeJL0GVouhgBjeIpGv3Vb0P4cdQTiz7zeRXkt9ybuLYR gYu3MnG8AqYxrtswS4tf8uoyYU1gL6gl+zZYnrvIqY2+c7sVgEi+CNOz8Dyl7TcVcV4j Ogj8wIMAgh5HsI4ekF6uMdS4iDkBAokjC6/SRR9dDzzztfTBnrmCzSa3Diku8b3/fB+9 Gwz4gMOokBsp8b05IL3ShJPM3/O6C9iTOZQzNjOR09PL4Jb86cERi7TPx3sdjpfGbywS L/M/jhqrjk/IvNxB04Xlb2nVhyjutX2+miMh6KYUABEuUtCJaVmFaJjKdtbRvDPBvZks v04w== X-Gm-Message-State: AOAM533JTLGe+THljP+GYSM97jxmguurGyzEm2FpKvQ3UnlDLHSwcq5e O2US4dgKPIQ2LjUx7hPQYFXGYalorHjd4wkl X-Google-Smtp-Source: ABdhPJzFfivd1nUbTvbvbC/OCYxG9scaAcwLUaIOksi07Sgc8P8VNa66lkMFWne4o74qEbgTCSBKyQ== X-Received: by 2002:a7b:c303:: with SMTP id k3mr5130906wmj.100.1618931914021; Tue, 20 Apr 2021 08:18:34 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:a079:f96:da87:2d00? ([2a01:e34:ed2f:f020:a079:f96:da87:2d00]) by smtp.googlemail.com with ESMTPSA id m15sm24797766wrx.32.2021.04.20.08.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 08:18:33 -0700 (PDT) Subject: Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Zhang Rui , Amit Kucheria , Matthias Brugger , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210320080646.49615-1-linux@fw-web.de> From: Daniel Lezcano Message-ID: Date: Tue, 20 Apr 2021 17:18:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, On 20/04/2021 16:59, Frank Wunderlich wrote: > Hi, > >> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr >> Von: "Daniel Lezcano" > >> No #ifdef in C file. > ... > >> devm_thermal_add_hwmon_sysfs() ? > > based on your comments this should be enough/right? > > #if IS_ENABLED(CONFIG_THERMAL_HWMON) > tzdev->tzp->no_hwmon = false;> ret = devm_thermal_add_hwmon_sysfs(tzdev); > if (ret) > dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs"); > #endif > > if yes i send out v2, at least it works on my device just the following lines should work: ret = devm_thermal_add_hwmon_sysfs(tzdev); if (ret) dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs"); The no_hwmon usage is a bit fuzzy in the thermal core code. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog