From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486AbdBTNw5 (ORCPT ); Mon, 20 Feb 2017 08:52:57 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:34998 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753297AbdBTNw4 (ORCPT ); Mon, 20 Feb 2017 08:52:56 -0500 Subject: Re: [PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table To: linux-kernel@vger.kernel.org References: <1483380416-9153-1-git-send-email-javier@osg.samsung.com> Cc: Miguel Ojeda Sandonis , Paul Burton From: Javier Martinez Canillas Message-ID: Date: Mon, 20 Feb 2017 10:52:05 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483380416-9153-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 01/02/2017 03:06 PM, Javier Martinez Canillas wrote: > The OF device ID table doesn't have a sentinel NULL entry and so it > causes the following error: > > FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry! > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[1]: *** [__modpost] Error 1 > Makefile:1493: recipe for target 'modules' failed > make: *** [modules] Error 2 > > Signed-off-by: Javier Martinez Canillas > --- Any comments about this patch and 2/2? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America