From: "Xiaqing (A)" <saberlily.xia@hisilicon.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <labbott@redhat.com>, <sumit.semwal@linaro.org>,
<gregkh@linuxfoundation.org>, <arve@android.com>,
<tkjos@android.com>, <maco@android.com>,
<devel@driverdev.osuosl.org>, <puck.chen@hisilicon.com>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<kongfei@hisilicon.com>, <linaro-mm-sig@lists.linaro.org>,
<daniel.liuyi@hisilicon.com>, <yudongbin@hisilicon.com>
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags
Date: Fri, 1 Feb 2019 16:30:53 +0800 [thread overview]
Message-ID: <b39b4839-ee9a-802b-8d46-674a61adfa8c@hisilicon.com> (raw)
In-Reply-To: <20190201081530.GC14343@kadam>
On 2019/2/1 16:15, Dan Carpenter wrote:
> On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
>> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
>> and there will be no chance to change back to low_order_gfp_flags.
>>
>> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
>
> Huh... Presumably you found this bug just by reading the code. I
> wonder how it affects runtime?
>
The problem is that when I found that there was no page allocation failure warning
after the failure of the ion alloc in my test, and then I found the problem of gfp_flags.
regards,
Qing
> regards,
> dan carpenter
>
>
> .
>
next prev parent reply other threads:[~2019-02-01 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 6:59 Qing Xia
2019-02-01 7:55 ` Chen Feng
2019-02-01 8:15 ` Dan Carpenter
2019-02-01 8:30 ` Xiaqing (A) [this message]
2019-02-19 21:18 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b39b4839-ee9a-802b-8d46-674a61adfa8c@hisilicon.com \
--to=saberlily.xia@hisilicon.com \
--cc=arve@android.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.liuyi@hisilicon.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kongfei@hisilicon.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=puck.chen@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=tkjos@android.com \
--cc=yudongbin@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®