From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F79DCCA47B for ; Thu, 9 Jun 2022 14:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235463AbiFIOar (ORCPT ); Thu, 9 Jun 2022 10:30:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235645AbiFIOao (ORCPT ); Thu, 9 Jun 2022 10:30:44 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 671686129D for ; Thu, 9 Jun 2022 07:30:43 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id c196so21254245pfb.1 for ; Thu, 09 Jun 2022 07:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=f3+B3/4f/EYX1WyHVwNor7M5aRUmp3PSGvyyEnFuqik=; b=Uf0gZWDEqsfPzDO/WoOCeZ9zDaQpoG7mpw39fhVrNd4PT36eVUs/AWQRnJc1PGQy6z MxJsCavq8e0r4QA2C5/DW163OyruGXogIMjLQqO9hOiXLcO9KAdDyetG2+YKxTQhKLEs 2Z2d8kh+Z+YW308jK/76QcgUk6kjZDzT2Hb++SdFAaMfqm1xGDHP/BHFdd3FUq7HYUxE 8N59xPbFsSOX7aqE9KZ3G0JG1v++Eu9VcU+yovBX8rENqdxOXtKpG9kuVkCEfUv35Ylq 93P03ULGNI5XIOFC8wrJz30QYpAsVBQrYnTwXdh5W3ycKKateO+O5A+JJHeMY2GkmYv8 FX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=f3+B3/4f/EYX1WyHVwNor7M5aRUmp3PSGvyyEnFuqik=; b=VcgfiBm1fZ8vvm8sJQOf7hDTQFJ1S47HyFUbpJ81sjQRFDPB2d1aihNWaBcV8xo0x7 srT7xiBlWdyucZ0mi4HfvWBl/Au8ZLSbhyu0iUHA9k52toj50J2JKneIHzmxH53accXG 4OOHsdgMKQ1pXP6UfEbWob41bGsPIqkwW90oL0eec9eNLxT1CX+x1A/55ZMwAznyMpof GKwHUUkrd3Mourt58w8BKTC5T/Fb4uO/XUw/oeuJWh1FHG9AXpjO9pHnnoKuc1nHzrtS 5XyqizfRqTtaQcX8Rx5uZcyjZT2NZg7jbQaF3xS44pWuG0Z++j0kDM0fMqYzVTMYZV+K 5YwQ== X-Gm-Message-State: AOAM532aU2z/CoJ5T5vhyNu9+n5JZXLU1hxfbKOE6tCHbtu8lK4i9Lai xPmPi/DIWrCN68L2rX8sqjSABw== X-Google-Smtp-Source: ABdhPJwWUD/Bnzq1gZvJJF6L4NnyDUcnw3k9MegfjCLajnnt2E7D2M2H5E8/ChxURaJNbJ6cPyrKfw== X-Received: by 2002:a62:8101:0:b0:51b:b859:7043 with SMTP id t1-20020a628101000000b0051bb8597043mr40685565pfd.25.1654785042892; Thu, 09 Jun 2022 07:30:42 -0700 (PDT) Received: from [192.168.254.36] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id e8-20020a170902784800b001640ab19773sm17226263pln.58.2022.06.09.07.30.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 07:30:42 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 07:30:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [cgroup] 3c87862ca1: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip Content-Language: en-US To: kernel test robot Cc: 0day robot , Tejun Heo , Zefan Li , Johannes Weiner , Christian Brauner , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , LKML , cgroups@vger.kernel.org, lkp@lists.01.org, Michal Koutny , netdev@vger.kernel.org, bpf@vger.kernel.org, stable@vger.kernel.org, syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com, =?UTF-8?Q?Michal_Koutn=c3=bd?= References: <20220609085641.GB17678@xsang-OptiPlex-9020> From: Tadeusz Struk In-Reply-To: <20220609085641.GB17678@xsang-OptiPlex-9020> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/22 01:56, kernel test robot wrote: > > Greeting, > > FYI, we noticed the following commit (built with gcc-11): > > commit: 3c87862ca13147416d900cf82ca56bb2f23910bf ("[PATCH v2] cgroup: serialize css kill and release paths") > url:https://github.com/intel-lab-lkp/linux/commits/Tadeusz-Struk/cgroup-serialize-css-kill-and-release-paths/20220606-014132 > base:https://git.kernel.org/cgit/linux/kernel/git/tj/cgroup.git for-next > patch link:https://lore.kernel.org/netdev/20220603181321.443716-1-tadeusz.struk@linaro.org > > in testcase: boot > > on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > If you fix the issue, kindly add following tag > Reported-by: kernel test robot > > > [ 55.821003][ C1] WARNING: CPU: 1 PID: 1 at kernel/softirq.c:363 __local_bh_enable_ip (kernel/softirq.c:363) Looks like that will need to be spin_lock_irq(&css->lock) instead of spin_lock_bh(&css->lock) I can respin the patch, but I would like to request some feedback on it first. Tejun, Michal Are you interested in fixing this at syzbot issue all? Do you have any more feedback on this? -- Thanks, Tadeusz