From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B740A2DC77C for ; Wed, 30 Apr 2025 06:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745993566; cv=none; b=Hc40qucmnrgdzxLvAF+kgig/dMsBl/YEPqP0ECkKOitqKaacykTNLIcNz27MsH50QQH4rAXqG8bMyiswWh8KjbaINJOaGoH7Os9a1HU42mxnCwVAbLDdWKZdm3tVAjWVPwCiZXBoG0Jf3W4jpIUqdT2PDyIyrKFBE34qEDRdJSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745993566; c=relaxed/simple; bh=CHHg+kPqADlKY6jCY9mAyr6wG/6GrkP/QGZFBsfbJKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YA8N/H/WkrHJuYzB+VGZW6P0od9UJmnaEJaUcgsftMxfrzi1/f17PnxogBi/hgHEJnGKnBqg6XWAeAi3XrVpBpyac48EI78u6AiVq6mw7mPMIl1FEgJdzoB4x2bQggpgqWfoKz/WIUKLqEbPGlvUB28DBdDfkMCcfuYSGfh8oE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ct5jAEER; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=gB/vHzdP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ct5jAEER; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=gB/vHzdP; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ct5jAEER"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="gB/vHzdP"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ct5jAEER"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="gB/vHzdP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4238A1F7C3; Wed, 30 Apr 2025 06:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745993556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfYXUjVjOyNlQjKzmBA4Z/LIvZ+skq8QMJWdoQyNa/Q=; b=ct5jAEERK/ZkSYKAUjkawleT9FvhZLvNR/muEA0IZqxWM+Mwd/MOvk6fA9fi88GR3Y8S6M W3Uo2xESyvxJDMeFL8yP2Kt+3Jc0NH+hz3+cDL7QzEXvXCWbpFZrskiB23D+8LK27qHRNr c2oxmywNzNtASmZYdXZUuPvSln0R4bw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745993556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfYXUjVjOyNlQjKzmBA4Z/LIvZ+skq8QMJWdoQyNa/Q=; b=gB/vHzdPhJswM9+G9DYeuR6feFzE8aMRfcx+Ir/o/bTfbb39C1/kjD/Zd7GAw7lDStWXCt maskKlPTnkZNO0CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ct5jAEER; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="gB/vHzdP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745993556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfYXUjVjOyNlQjKzmBA4Z/LIvZ+skq8QMJWdoQyNa/Q=; b=ct5jAEERK/ZkSYKAUjkawleT9FvhZLvNR/muEA0IZqxWM+Mwd/MOvk6fA9fi88GR3Y8S6M W3Uo2xESyvxJDMeFL8yP2Kt+3Jc0NH+hz3+cDL7QzEXvXCWbpFZrskiB23D+8LK27qHRNr c2oxmywNzNtASmZYdXZUuPvSln0R4bw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745993556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfYXUjVjOyNlQjKzmBA4Z/LIvZ+skq8QMJWdoQyNa/Q=; b=gB/vHzdPhJswM9+G9DYeuR6feFzE8aMRfcx+Ir/o/bTfbb39C1/kjD/Zd7GAw7lDStWXCt maskKlPTnkZNO0CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0914139E7; Wed, 30 Apr 2025 06:12:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F0TzLFO/EWhUZQAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 06:12:35 +0000 Message-ID: Date: Wed, 30 Apr 2025 08:12:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: select tls config when tcp tls is enabled To: Alistair Francis , hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis References: <20250429224025.3077488-1-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250429224025.3077488-1-alistair.francis@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4238A1F7C3 X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[gmail.com,lst.de,grimberg.me,nvidia.com,lists.infradead.org]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid,suse.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 4/30/25 00:40, Alistair Francis wrote: > Ensure that TLS support is enabled in the kernel when > NVME_TCP_TLSS is enabled. This allows TLS secure channels to be > used out of the box. > > Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall") > Signed-off-by: Alistair Francis > --- > drivers/nvme/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig > index d47dfa80fb95..4d64b6935bb9 100644 > --- a/drivers/nvme/host/Kconfig > +++ b/drivers/nvme/host/Kconfig > @@ -102,6 +102,7 @@ config NVME_TCP_TLS > depends on NVME_TCP > select NET_HANDSHAKE > select KEYS > + select TLS > help > Enables TLS encryption for NVMe TCP using the netlink handshake API. > I would have folded it into the previous patch. Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich