From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752854AbdFTXKq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 19:10:46 -0400
Received: from mx2.suse.de ([195.135.220.15]:43718 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752392AbdFTXKp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 19:10:45 -0400
Subject: Re: [PATCH] tty: hide unused pty_get_peer function
To: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>
Cc: Kees Cook <keescook@chromium.org>,
        Colin Ian King <colin.king@canonical.com>,
        linux-kernel@vger.kernel.org
References: <20170620203436.630727-1-arnd@arndb.de>
From: Aleksa Sarai <asarai@suse.de>
Message-ID: <b39fdd1f-8e85-0e0d-3564-d6e76241b0da@suse.de>
Date: Wed, 21 Jun 2017 09:10:37 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170620203436.630727-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> TIOCGPTPEER is only used for unix98 PTYs, and we get a warning
> when those are disabled:
> 
> drivers/tty/pty.c:466:12: error: 'pty_get_peer' defined but not used [-Werror=unused-function]
> 
> This moves the respective functions inside of the existing #ifdef.
> 
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Oops, I missed that.

   Acked-by: Aleksa Sarai <asarai@suse.de>

-- 
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/