From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 781071A267 for ; Thu, 12 Feb 2026 15:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770911339; cv=none; b=EQI+y1/ElGuE2VpvoWQOBF1gy1ANchgZg7nz+jXbkctRZBJ+ArBvysAAWhzmEzUOta610UajRbj2zJi5BgX4o7u64bCWCXQJ+hOYPR9ug86NELvZlHLBTt7K718KKU/0a3CRJX9faZZATJIb7RzxeskUQCkIQM8nESNqgIEkpVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770911339; c=relaxed/simple; bh=iRzL9jBQ8w1gYaFtFp79jU8IsZQtkH+fCqbeuImugCM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=WWcvUX7NdHLLb1QKHEzrbCdUgt4moiJfM2w6dofhOIChruPk724r05sg3UFFbi8w6BME7OAegrZNZQT7cWd8eQ2q+gonXAz0BbBqYpjNx7O7p4dQJLacX22OjI8HGlmxBSQejhIpEWMvaXMVBQOXA7gXle8F5xdPXsATFJW1cC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NPJ6JeNg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RwBBn69n; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NPJ6JeNg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RwBBn69n" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CDRl0M1339921 for ; Thu, 12 Feb 2026 15:48:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= blanNpJmF38WotYj+8199SeXnGRrXS7oA23dNvJbxLk=; b=NPJ6JeNg4wvH69KH FE6kHS3T7JTWG2sToSMpDTg+WDnaGOrhoU9G1Jp9KlgUq6V8jyqNf8IgFrgFLQaN X8rmcG1B+D3BGXF5M5mMiBo7LjCVGdwHjZNTW0/m48aHDYxWBSg+Y7gXqPxNSHl6 seWWpK9MzQa4t7/B+lNhPe9gs9gu3EWPBneetDis2d0D/ARFkdx7HE87n/Gk2Fsn KTiUBxw0l+yzrTxaq+JhZ8dUgxQLy0pdOpZrBGWl3pdKWLcD3Vk1qGr3+HeIYIUG ZKoeC/GFr/ApctaLim5u+pzjEM6HgEY7gAShNk4538j5/MNOq59w7peOEd7FS3HU Ccyh6g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c90wjb8ek-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 15:48:57 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3ad1b81aso5551185a.2 for ; Thu, 12 Feb 2026 07:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770911336; x=1771516136; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=blanNpJmF38WotYj+8199SeXnGRrXS7oA23dNvJbxLk=; b=RwBBn69n6USzXXhprHLnoFTiiWvtr1r+H8c7J6Jz9M2DoXncJm0SKN41UwegvYKbgF EXrgIkiVA10lPuOJEchLiww19NdlPUS1+KwvE0NAVDKYGZoJlxjur9E4SYj4Bu2h73B8 t0XMoeo6jYHAEpBFm2a9flog3dmCM8uWinRSqL61KTuEjVxzzQNs60OJ7t94P8VMa5LD b7irBXs6YXcfDmDnHKyAgfdbfu/ZtyhYP7jwyYgqO1zPbrUtri2ioeo0X7P5hk73p9Uj jgfOoVD5wc+DrFsgGyNfdA+CrO9gZiS28Zclt0NHqdZuGhtLsikCMkHNaRutWPLijRwf 0n7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770911336; x=1771516136; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=blanNpJmF38WotYj+8199SeXnGRrXS7oA23dNvJbxLk=; b=ip6wkxLL86CNfmpyqNz6v/dLVgsoW+albU91DKjnad7+8sE8qKB3K5NZk9oldWHuCS MRo6ylnI4NmIQL3EIqw2S8zvoJRoWnt9pCxyHH7MmieyDtH8l25x5rqDuPezzqpDVZVX /m/geuGB5gNh0tDyRNnWpWF10lTe7gs4hdfR12M1ufAh9X/nS1tB2pcpdt2ERcAra278 ePLaaOD1DXZdL3zjyqL5a8nW3PYsT1ZjlTwoBFgB0Bo4IaryG8zsrlAxdVee3boXr87q QSftALNOwCYQ3tr1TOZfz/WW36F57WvEfxzZMAz3oUIzc+r+mGEInQwUWMhgpyHfDcSL iFvQ== X-Forwarded-Encrypted: i=1; AJvYcCUygv3of1HNfkZ0D9cnGk8GvuprMrj/GA9BnjXeDgjUSbzrsbI+C/txaVi5m75RT2Dl8eUMnEmfzwTcYGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5l/XVwi77PgPHFkbyCQvJzMNpFLtzPmaI8pcHeGoowH9x+6RF KvGwuA4e8E35yT5Z40RjzX6TMLxImeQiAc3BwlQz0VERDIXB0azL31FTtbH1rlayFGdNcoroGzL IbXH/YYsGxkULtVlNwyN/ibdMlW0BqZ971xI9/rSxn+K47imfEAe6nR1SNL9vcwE0xtA= X-Gm-Gg: AZuq6aK32LxUgAov/lAqaLthLpN67kT7oKlwmChCq3naBKLtVHZE0PSisxEAODp4Gij WnKd59dvZ6ppSTmSpqJgnnTBFH2BIs8MhIUK8hX8Yc/lYJTCu/OAm6gBlUYbcqhBEYbrsWs5f00 vLicZYuSKRnsTdpM1XLh7mw4cVJlpmJBN6Oey3bywN+9JFyns36XfCSKNjEhY940EkwnnvanUMo ZSqgH+hK7XFbrTxNYtnNBhQh2XEOCqdS4uxOHPMSs2zmHYIZnST1kTFUe0KcdOeiRvl4JHnTpvo TdwVFknkT+Hcm6SIfGv9RAI5dTH9T5KcnSrkpmzOqYC4NPErncWnAvp6B88zf9ASphr4I8cm7oK tvTNA/89HjfwcjwsdssJkcqcAfYZCAOVRXtM1dlJaCl/jtC816qKH3voMbN6ZSyQdlHa51olVbB MO1OEDKJROeJ5l4voTNC1UZMEuwM0aKgIQJdLr4YKDXPkSRRAoOPpllnViWiw9chhzlCybS2LJP ogijOzbqnhMcbqp X-Received: by 2002:a05:620a:708e:b0:8c6:aaf3:cb44 with SMTP id af79cd13be357-8cb33041591mr367742685a.4.1770911336537; Thu, 12 Feb 2026 07:48:56 -0800 (PST) X-Received: by 2002:a05:620a:708e:b0:8c6:aaf3:cb44 with SMTP id af79cd13be357-8cb33041591mr367738285a.4.1770911336004; Thu, 12 Feb 2026 07:48:56 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6e9cd6d4sm173327066b.23.2026.02.12.07.48.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 07:48:54 -0800 (PST) Message-ID: Date: Thu, 12 Feb 2026 16:48:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH v2] driver core: Make deferred_probe_timeout default a Kconfig option To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Rob Herring , Bjorn Andersson , linux-kernel@vger.kernel.org References: <20260212145416.83949-1-johannes.goede@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=DtlbOW/+ c=1 sm=1 tr=0 ts=698df669 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=lbxW-ssu0gYgB3DE3wkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDEyMSBTYWx0ZWRfX58SxnNdwPMjH fOy3ePvkdDVnVVlr8pl3DXOXTfY+H5GSIaHK1mw4b/vTl4EjXEzFB0mOM0Wgt+9Tbuq8UN2iM1I MzQnrDOp0lciw0B/Mqty/sAYkcaOZkeYnC79qBn9FVyDlLvvifyeYyW6eb10QJEt+OToInszQZB hwU304rv4pjV4bXzrzlJSFquYJZ7FsgmIQEIMnMlLnfqszqEyNcgMZBUTp8JWThx1oGEMw3WCVo dvtwMRIWkk5XBUIQNTP/Y6wJqFY46NkRe8AjqX5cLcsMrq5hlfS3wzmp+9KtI61NbwezpHSZgKp ZymNkaKnwTJqb+g2XaIVTZQFgVAFV5ot42TikbR9mRTpFphnx0uc37aSO3VwgRmubVDjTTJah29 UdDCiCjNfXNmWqRRJcNTIMthc8hWtg85ULaBEPGoD1WGXi+3HIm2pgWmRIK7Gy7QdbeV/XIJhCK 3W21MO75d8DZawuoGiA== X-Proofpoint-ORIG-GUID: Y-fXtFsl-A5ceJcDSgbJzZlanGOTV8gH X-Proofpoint-GUID: Y-fXtFsl-A5ceJcDSgbJzZlanGOTV8gH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_04,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120121 Hi, On 12-Feb-26 16:22, Saravana Kannan wrote: > On Thu, Feb 12, 2026 at 6:54 AM Hans de Goede > wrote: >> >> Code using driver_deferred_probe_check_state() differs from most >> EPROBE_DEFER handling in the kernel. Where other EPROBE_DEFER handling >> (e.g. clks, gpios and regulators) waits indefinitely for suppliers to >> show up, code using driver_deferred_probe_check_state() will fail >> after the deferred_probe_timeout. >> >> This is a problem for generic distro kernels which want to support many >> boards using a single kernel build. These kernels want as much drivers to >> be modular as possible. The initrd also should be as small as possible, >> so the initrd will *not* have drivers not needing to get the rootfs. >> >> Combine this with waiting for a full-disk encryption password in >> the initrd and it is pretty much guaranteed that the default 10s timeout >> will be hit, causing probe() failures when drivers on the rootfs happen >> to get modprobe-d before other rootfs modules providing their suppliers. >> >> Make the default timeout configurable from Kconfig to allow distro kernel >> configs where many of the supplier drivers are modules to set the default >> through Kconfig. >> >> While at it document that a value of -1 can be used to disable the timeout >> (wait indefinitely). >> >> Acked-by: Saravana Kannan >> Signed-off-by: Hans de Goede >> --- >> Changes in v2: >> - Remove unnecessary addition of "if (driver_deferred_probe_timeout < 0)" >> check >> - Add Acked-by from Saravana >> --- >> Documentation/admin-guide/kernel-parameters.txt | 2 +- >> drivers/base/Kconfig | 9 +++++++++ >> drivers/base/dd.c | 6 +----- >> 3 files changed, 11 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt >> index aa0031108bc1..d26957741713 100644 >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -1250,7 +1250,7 @@ Kernel parameters >> out hasn't expired, it'll be restarted by each >> successful driver registration. This option will also >> dump out devices still on the deferred probe list after >> - retrying. >> + retrying. Set to -1 to wait indefinitely. > > Forgot to fix this? As mentioned in the updated commit message: "While at it document that a value of -1 can be used to disable the timeout (wait indefinitely)." I dropped the code-changes for this since -1 is already supported, it still seems like a good idea to document that -1 can be used so I decided to keep the documentation change. Regards, Hans >> >> delayacct [KNL] Enable per-task delay accounting >> >> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig >> index 1786d87b29e2..f7d385cbd3ba 100644 >> --- a/drivers/base/Kconfig >> +++ b/drivers/base/Kconfig >> @@ -73,6 +73,15 @@ config DEVTMPFS_SAFE >> with the PROT_EXEC flag. This can break, for example, non-KMS >> video drivers. >> >> +config DRIVER_DEFERRED_PROBE_TIMEOUT >> + int "Default value for deferred_probe_timeout" >> + default 0 if !MODULES >> + default 10 if MODULES >> + help >> + Set the default value for the deferred_probe_timeout kernel parameter. >> + See Documentation/admin-guide/kernel-parameters.txt for a description >> + of the deferred_probe_timeout kernel parameter. >> + >> config STANDALONE >> bool "Select only drivers that don't need compile-time external firmware" >> default y >> diff --git a/drivers/base/dd.c b/drivers/base/dd.c >> index bea8da5f8a3a..2f358e29e0e8 100644 >> --- a/drivers/base/dd.c >> +++ b/drivers/base/dd.c >> @@ -257,11 +257,7 @@ static int deferred_devs_show(struct seq_file *s, void *data) >> } >> DEFINE_SHOW_ATTRIBUTE(deferred_devs); >> >> -#ifdef CONFIG_MODULES >> -static int driver_deferred_probe_timeout = 10; >> -#else >> -static int driver_deferred_probe_timeout; >> -#endif >> +static int driver_deferred_probe_timeout = CONFIG_DRIVER_DEFERRED_PROBE_TIMEOUT; >> >> static int __init deferred_probe_timeout_setup(char *str) >> { >> -- >> 2.52.0 >>