From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbdC2TNw (ORCPT ); Wed, 29 Mar 2017 15:13:52 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34971 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603AbdC2TNu (ORCPT ); Wed, 29 Mar 2017 15:13:50 -0400 Subject: Re: [PATCHv3 2/2] leds: cpcap: new driver To: Sebastian Reichel , Richard Purdie , Pavel Machek , Lee Jones References: <20170324084732.31255-1-sre@kernel.org> <20170324084732.31255-2-sre@kernel.org> Cc: Tony Lindgren , Rob Herring , Mark Rutland , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Wed, 29 Mar 2017 21:12:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170324084732.31255-2-sre@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, On 03/24/2017 09:47 AM, Sebastian Reichel wrote: > Motorola CPCAP is a PMIC (power management integrated circuit) found > in multiple smartphones. This driver adds support for the chip's LED > controllers. This introduces support for all controllers used by the > Droid 4. According to Motorola's driver (no datasheets available) > there a couple of more LED controllers. I did not add support for > them, since I cannot verify that they work with my modifications. > > Acked-by: Pavel Machek > Signed-off-by: Sebastian Reichel > --- > Changes since PATCHv1: > - binding: reference common led binding for label > - drop DEBUG define (leftover) > - s/led/LED/g in debug prints > - order includes alphabetically > - introduce mutex, since led API is not atomic > - register led class after initial register setup > - use GPLv2+ in header > - drop unsupported leds from driver > > Changes since PATCHv2: > - use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON > > Notes: > - The "motorola" vendor-prefix is added via rtc-next > --- > .../devicetree/bindings/leds/cpcap-leds.txt | 29 +++ > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-cpcap.c | 239 +++++++++++++++++++++ > 4 files changed, 278 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt > create mode 100644 drivers/leds/leds-cpcap.c > > diff --git a/Documentation/devicetree/bindings/leds/cpcap-leds.txt b/Documentation/devicetree/bindings/leds/cpcap-leds.txt > new file mode 100644 > index 000000000000..ebf7cdc7f70c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/cpcap-leds.txt I've changed cpcap-leds.txt to leds-cpcap.txt to match the prevailing pattern for LED DT bindings file names. Please let me know if you have any objections. -- Best regards, Jacek Anaszewski