From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Ingyu Jang <ingyujang25@korea.ac.kr>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Naushir Patuck <naush@raspberrypi.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] media: rp1-cfe: Use IS_ERR() check for media_entity_remote_source_pad_unique()
Date: Mon, 2 Nov 2026 13:32:46 +0200 [thread overview]
Message-ID: <b3a85767-9cf5-4e28-a6a0-b6695e63601b@ideasonboard.com> (raw)
In-Reply-To: <20261101132422.1396104-1-ingyujang25@korea.ac.kr>
Hi,
On 01/11/2026 15:24, Ingyu Jang wrote:
> media_entity_remote_source_pad_unique() returns either a valid struct
> media_pad pointer or an error pointer (ERR_PTR(-ENOTUNIQ) or
> ERR_PTR(-ENOLINK)); it never returns NULL. The current NULL check
> therefore never triggers, and the "pad not connected" error path is
> unreachable.
>
> Replace the NULL check with an IS_ERR() check so the validation
> actually detects malformed media graphs.
>
> Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
prev parent reply other threads:[~2026-11-02 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 19:31 [PATCH] " Ingyu Jang
2026-05-22 10:14 ` Dave Stevenson
2026-06-03 6:41 ` Jai Luthra
2026-11-01 13:24 ` [PATCH v2] " Ingyu Jang
2026-11-02 11:32 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a85767-9cf5-4e28-a6a0-b6695e63601b@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=florian.fainelli@broadcom.com \
--cc=ingyujang25@korea.ac.kr \
--cc=jai.luthra@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®