From: Atish Patra <Atish.Patra@wdc.com>
To: "hch@lst.de" <hch@lst.de>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Cc: "robin.murphy@arm.com" <robin.murphy@arm.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] dma-direct: don't truncate dma_required_mask to bus addressing capabilities
Date: Tue, 6 Aug 2019 20:16:47 +0000 [thread overview]
Message-ID: <b3aacbda7b6227c0f0bc46b39575f8eb1417a51b.camel@wdc.com> (raw)
In-Reply-To: <20190806052325.GB13409@lst.de>
On Tue, 2019-08-06 at 07:23 +0200, Christoph Hellwig wrote:
> On Mon, Aug 05, 2019 at 05:51:53PM +0200, Lucas Stach wrote:
> > The dma required_mask needs to reflect the actual addressing
> > capabilities
> > needed to handle the whole system RAM. When truncated down to the
> > bus
> > addressing capabilities dma_addressing_limited() will incorrectly
> > signal
> > no limitations for devices which are restricted by the
> > bus_dma_mask.
> >
> > Fixes: b4ebe6063204 (dma-direct: implement complete bus_dma_mask
> > handling)
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> Yeah, this looks sensible. Atish, can you check if this helps on the
> HiFive board as well?
Yes. It fixes the nvme issue on HiFive Unleashed + Microsemi expansion
board.
FWIW,
Tested-by: Atish Patra <atish.patra@wdc.com>
Regards,
Atish
prev parent reply other threads:[~2019-08-06 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 15:51 Lucas Stach
2019-08-06 5:23 ` Christoph Hellwig
2019-08-06 20:16 ` Atish Patra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3aacbda7b6227c0f0bc46b39575f8eb1417a51b.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=Alistair.Francis@wdc.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=patchwork-lst@pengutronix.de \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®