From: Jijie Shao <shaojijie@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <shaojijie@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue
Date: Mon, 7 Apr 2025 09:06:42 +0800 [thread overview]
Message-ID: <b3aafd85-cb58-4046-88df-2b3566e2497d@huawei.com> (raw)
In-Reply-To: <20250404075804.42ccf6f0@kernel.org>
on 2025/4/4 22:58, Jakub Kicinski wrote:
> On Thu, 3 Apr 2025 21:53:10 +0800 Jijie Shao wrote:
>> In normal cases, the driver must ensure that the value
>> of rx pause mac addr is the same as the MAC address of
>> the network port. This ensures that the driver can
>> receive pause frames whose destination address is
>> the MAC address of the network port.
> I thought "in normal cases" pause frames use 01:80:C2:00:00:01
> as the destination address!?
No, the address set in .ndo_set_mac_address() is used.
01:80:C2:00:00:01 is supported by default. No additional configuration is required.
>
> Are you sure this patch is not a misunderstanding, and the issue
> is already fixed by patch 2?
It's a different issue. This patch is used to solve the problem that
the configuration is lost after reset.
>
>> Currently, the rx pause addr does not restored after reset.
Here.
>>
>> The index of the MAC address of the host is always 0.
>> Therefore, this patch sets rx pause addr to
>> the MAC address with index 0.
next prev parent reply other threads:[~2025-04-07 1:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 13:53 [PATCH net v2 0/7] There are some bugfix for hibmcge driver Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 1/7] net: hibmcge: fix incorrect pause frame statistics issue Jijie Shao
2025-04-04 5:26 ` Michal Swiatkowski
2025-04-04 10:59 ` Simon Horman
2025-04-03 13:53 ` [PATCH net v2 2/7] net: hibmcge: fix incorrect multicast filtering issue Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 3/7] net: hibmcge: fix the share of irq statistics among different network ports issue Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 4/7] net: hibmcge: fix wrong mtu log issue Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 5/7] net: hibmcge: fix the incorrect np_link fail state issue Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue Jijie Shao
2025-04-04 14:58 ` Jakub Kicinski
2025-04-07 1:06 ` Jijie Shao [this message]
2025-04-07 17:11 ` Jakub Kicinski
2025-04-10 1:07 ` Jijie Shao
2025-04-03 13:53 ` [PATCH net v2 7/7] net: hibmcge: fix multiple phy_stop() issue Jijie Shao
2025-04-04 11:01 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3aafd85-cb58-4046-88df-2b3566e2497d@huawei.com \
--to=shaojijie@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®