From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <angelogioacchino.delregno@collabora.com>,
<aaronyu@google.com>, <matthias.bgg@gmail.com>,
<trevor.wu@mediatek.com>, <tzungbi@google.com>,
<julianbraha@gmail.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v6 2/8] ASoC: mediatek: mt8186: add platform driver
Date: Thu, 9 Jun 2022 10:58:42 +0800 [thread overview]
Message-ID: <b3ab001a4a28767cf4f8a5b330b11ead80c5d48e.camel@mediatek.com> (raw)
In-Reply-To: <YqCG+9YkuXsDeh/I@sirena.org.uk>
On Wed, 2022-06-08 at 12:24 +0100, Mark Brown wrote:
> On Tue, Jun 07, 2022 at 10:20:40PM +0800, Jiaxin Yu wrote:
>
> > +obj-$(CONFIG_SND_SOC_MT8186) += snd-soc-mt8186-afe.o
> > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_DA7219_MAX98357) += mt8186-
> > mt6366-da7219-max98357.o
> > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_RT1019_RT5682S) += mt8186-
> > mt6366-rt1019-rt5682s.o
>
> This breaks bisection - these drivers are being added to the build
> here
> but the relevant source files aren't added until later on in the
> series
> so the commits in between won't build when the relevant Kconfig
> options
> are selected. The Makefile and Kconfig updates should be moved into
> the
> driver patches.
I see, this is to ensure the independence of each patch. I will move
the Kconfig and Makefile changes related to the machine driver to the
corresponding patch.
Thanks,
Jiaxin.Yu
next prev parent reply other threads:[~2022-06-09 2:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 14:20 [PATCH v6 0/8] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 1/8] dt-bindings: mediatek: mt6358: add new compatible for using mt6366 Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 2/8] ASoC: mediatek: mt8186: add platform driver Jiaxin Yu
2022-06-08 11:24 ` Mark Brown
2022-06-09 2:58 ` Jiaxin Yu [this message]
2022-06-07 14:20 ` [PATCH v6 3/8] ASoC: mediatek: mt8186: add mt8186-mt6366 common driver Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 4/8] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 5/8] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 6/8] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 7/8] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s Jiaxin Yu
2022-06-07 14:20 ` [PATCH v6 8/8] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ab001a4a28767cf4f8a5b330b11ead80c5d48e.camel@mediatek.com \
--to=jiaxin.yu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julianbraha@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®