From: Timur Tabi <timur@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
swboyd@chromium.org, linux-gpio@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v3 3/3] gpiolib: Show correct direction from the beginning
Date: Tue, 2 Oct 2018 07:29:48 -0500 [thread overview]
Message-ID: <b3b2e31d-f411-370d-21c9-3a141906ee58@kernel.org> (raw)
In-Reply-To: <20181002082731.20141-3-ricardo.ribalda@gmail.com>
On 10/2/18 3:27 AM, Ricardo Ribalda Delgado wrote:
> + /* REVISIT: most hardware initializes GPIOs as inputs (often
> + * with pullups enabled) so power usage is minimized. Linux
> + * code should set the gpio direction first thing; but until
> + * it does, and in case chip->get_direction is not set, we may
> + * expose the wrong direction in sysfs.
> + */
I don't think this comment applies any more.
Also, please don't use timur@codeaurora.org any more. That address is
no longer valid. Use timur@kernel.org instead.
next prev parent reply other threads:[~2018-10-02 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 8:27 [PATCH v3 1/3] gpiolib: Add init_valid_mask exported function Ricardo Ribalda Delgado
2018-10-02 8:27 ` [PATCH v3 2/3] pinctrl: msm: Use " Ricardo Ribalda Delgado
2018-10-02 8:27 ` [PATCH v3 3/3] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-10-02 12:29 ` Timur Tabi [this message]
2018-10-02 9:14 ` [PATCH v3 1/3] gpiolib: Add init_valid_mask exported function Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b2e31d-f411-370d-21c9-3a141906ee58@kernel.org \
--to=timur@kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®