From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32939435EDB for ; Wed, 8 Jul 2026 16:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529410; cv=none; b=hd3CyALtFj5XVPMFWHxlaJHvqMnl7YGola/yULvBVWQa7hF2Xw7iDsYVuHMFruW3f/L6Kysg39Bok+5GbDD5bv3ikoamfdlI3a+Ak6UNVLR3xA8nfAnLG6+STR6Rqlyjmi7FzODsTyUg8YBdXLfW3Z9KSkPn18eQop+eyq72C3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783529410; c=relaxed/simple; bh=XbHwPXYNVvkP+QCkHDk9DeAKKpxWOytoPU2U2ndXHCY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sx6pbYFCRP5Ae1oqIGDjk0azKAjA/J04cJRwtnI3VFQJgLNfKCixUoFsHHqInpmSlzRGld6C/NulJ+Lm1iTlCK9TsX+vHgRRPSinx27rU2QpUs1fDdWTlGgd4XavUplTgMiaB7xWPCGUKB9HyL650LrpxF5mKGmbSfZ9PxxZAm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LIifIwyS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=p/2BSrhY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LIifIwyS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="p/2BSrhY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783529406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XbHwPXYNVvkP+QCkHDk9DeAKKpxWOytoPU2U2ndXHCY=; b=LIifIwySH8MtPjwEtJ0BXv3uMEE4HGV+IK8w9wPlg8tgi0VIXIRrJ+tRNIHBl0RwmFHsTc YsvWxjFYDLDY3/b2IXclojwWPcSL20dhqJC/QsWOCjI4VwzQN5jw8XBL6DaJB+a3Lhe6EQ kemfsSxzLyavzpFnF87SskWwvlnH1eQ= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-7WUiJ4eXMRaGPgw4iW-eBg-1; Wed, 08 Jul 2026 12:50:04 -0400 X-MC-Unique: 7WUiJ4eXMRaGPgw4iW-eBg-1 X-Mimecast-MFC-AGG-ID: 7WUiJ4eXMRaGPgw4iW-eBg_1783529404 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8f0ed4fe79aso20424816d6.0 for ; Wed, 08 Jul 2026 09:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783529404; x=1784134204; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=XbHwPXYNVvkP+QCkHDk9DeAKKpxWOytoPU2U2ndXHCY=; b=p/2BSrhYORYgDL2ltHnaxNb11Jaaj7KaTRIjGaYo9+mgHAMf8dgxvm4LUJ8RBLCXDu 0pO/8Gej623pA+7sHk8XXr09cN7e5C0YxP49NggQ2+NJtFay8uTlCQRgYPAhj7xz1AP0 HbH/V6BcHNfJ2c4exMIo2S+IUyDowcmRR9xUamuJ+91ETvK15aT9F4e2HVBTUuB15OA+ 5lygrCmJdX5buwiJNME16FN1FO0Gt5NGJMqeySG9liafuHvl3t1KDc6tJHkQDr5WCubh 86LhOo+pOXZ7PbrKWpqX2NIaNIrfzqB6blqyWR6OuKCSZNnRfmv40nBlcZIE+Cgoqka2 RrSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783529404; x=1784134204; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XbHwPXYNVvkP+QCkHDk9DeAKKpxWOytoPU2U2ndXHCY=; b=As3u3UBYT8c9zvMJnrVsyWpfca91eC69+ZfGKltze961iFje1OCsHT9ffju7wsvzPw 8ZfSlSEv5c286m2ajaGm6ChoCPXP5vcn7dOM/w/NBW91e8ynWJa4EjBB4IJvuE1sgSHD d9MUU3rDJ7QWc+1GeCUl/z7iopN+NqDw92KqrTe1aDqcewRMknhZM+4p8+HklJ7S+GXD IzMVEX08xWW+xq/m5nPn7/ZnkYqxBNx5jCY79fq9BOAUvHjVeVL8Y4lhJQ89kwJt1MXv PapQzZLF0WKpONMnH3DvUgc0lrLGVGpOlFP4FWrYN9D1SiUDwndP6W+MATpnOvHtV8l3 LoMw== X-Forwarded-Encrypted: i=1; AHgh+Rovf4Hn1Hf4WEj7Sxct7HGliZQ/rgaP5WUIYwOdxAxT0q39xB9lxyRHrKVadf+cIz33a5OiR6pdvmPsQ40=@vger.kernel.org X-Gm-Message-State: AOJu0YxSMiQztV3EAEtcTiqYyfY7F7Wu0UNxcy+BejzTO66o3lNOHaFx wFAoNNb9qX6J13GA98MLNTwT101FETQSaa/nntkCphukVDNhGlZRcJHOeCwSfVS7rurcJrMwJYM lY4mOQTJkT72GCjigQ6r7PVY1MwXBZa8c57OlXDirvNl50EZZ0QCuOVek73AXPCrsmg== X-Gm-Gg: AfdE7cngwix59PhFXWh7LPsadLQv6UQQpskrHFy8y4r+kBXQtkJOyuRiTugozLrz5T9 AsZxKH6NAp/WHlpBNdS9Xb8ZWJl0JgHDYhusgv0FRwUpUR+Lw6aTJwHNYvhyG+hIorjKkT1mQSq SMjt193rQj+8j+ixcWAQWZCYqa5K3mb1nUE6FoY1f3Nj3qHos2o2SuGlo8glDRLaNxwRolRIRsM xus5kJP22YAHd8beuGV1YJv6LivUzJADLVzNnHDmJ0skr33Kk5ogQY2zrD1RpozOwEEXfft3pdW c71dO69txXFJEaSgv/c5bQ9RFnkrUs4qUb4CUmv1St87ZLokkGwv5kFTAy8+Ujw7Y66HHXTX2s8 qVC8ROLgqXj9R3Jm+N8uAS32Parog3DNwFebd1Q+xsBEo3yE= X-Received: by 2002:ad4:5ccd:0:b0:8e9:f5de:d614 with SMTP id 6a1803df08f44-8fec3a03667mr37427566d6.51.1783529402713; Wed, 08 Jul 2026 09:50:02 -0700 (PDT) X-Received: by 2002:ad4:5ccd:0:b0:8e9:f5de:d614 with SMTP id 6a1803df08f44-8fec3a03667mr37427136d6.51.1783529401867; Wed, 08 Jul 2026 09:50:01 -0700 (PDT) Received: from loberman-thinkpadp16gen3.rmtusma.csb ([2600:6c65:2440:d8c:dbb1:97f1:a6e6:766b]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ff70196cc5sm5834976d6.27.2026.07.08.09.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 09:50:01 -0700 (PDT) Message-ID: Subject: Re: [PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery From: Laurence Oberman To: Don.Brace@microchip.com, mateusz.nowicki@posteo.net Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, storagedev@microchip.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 08 Jul 2026 12:50:00 -0400 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-05-14 at 14:24 +0000, Don.Brace@microchip.com wrote: > ________________________________________ > From:=C2=A0Mateusz Nowicki > Sent:=C2=A0Wednesday, May 6, 2026 9:01 AM > To:=C2=A0Don Brace - C33706 > Cc:=C2=A0martin.petersen@oracle.com=C2=A0; > James.Bottomley@HansenPartnership.com=C2=A0< > James.Bottomley@HansenPartnership.com>; storagedev > ; > linux-scsi@vger.kernel.org=C2=A0; > linux-kernel@vger.kernel.org=C2=A0 > Subject:=C2=A0[PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery > =C2=A0 > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe >=20 > A PCIe bus reset (e.g. "echo 1 > /sys/bus/pci/devices//reset") > on a > controller without FLR support leaves the HPE SR932i-p Gen10+ > unusable > until reboot: smartpqi registers no pci_error_handlers, so the driver > is not notified, firmware reverts to SIS mode, and all queue mappings > are dropped while the driver still drives PQI. >=20 > Patch 1 adds .reset_prepare / .reset_done reusing > pqi_ofa_ctrl_quiesce() / _unquiesce() / pqi_ctrl_init_resume(). >=20 > Patch 2 raises SIS_CTRL_READY_RESUME_TIMEOUT_SECS from 90s to 180s, > matching the cold-boot path; without this patch 1 fails at the SIS > ready check because firmware boot after reset takes ~125s on the > SR932i-p Gen10+. >=20 > Tested on HPE SR932i-p Gen10+ against Linus' master at 74fe02ce122a. >=20 > Thanks for the patch.=20 > NAK for now. >=20 > Before we ack, we want to run this through internal regression on the > SR-series=20 > =E2=80=94 particularly the OFA + bus-reset interaction in patch 1 and whe= ther > the 180s timeout in patch 2 should apply universally or > =C2=A0=C2=A0=C2=A0=C2=A0 be controller-gated. This may lead to changes in= your patches. >=20 >=20 >=20 >=20 > Hi Don, Where are we with the testing you wanted to do. Regards Laurence