From: Guenter Roeck <linux@roeck-us.net>
To: Jerry.Hoemann@hpe.com
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] watchdog: hpwdt: SMBIOS check
Date: Sun, 22 Oct 2017 07:56:05 -0700 [thread overview]
Message-ID: <b3bfecf2-2ac6-4c1d-a03e-5f70aa03f7e0@roeck-us.net> (raw)
In-Reply-To: <20171022015621.GB28641@anatevka.americas.hpqcorp.net>
On 10/21/2017 06:56 PM, Jerry Hoemann wrote:
> On Fri, Oct 20, 2017 at 07:37:21PM -0700, Guenter Roeck wrote:
>> On 10/20/2017 03:54 PM, Jerry Hoemann wrote:
>>> Correct test on SMBIOS table 219 Misc Features bits for UEFI supported.
>>>
>> Please explain in more detail. There is no table 219 in the SMBIOS specification.
>
> Sorry, my patch documentation was imprecise, I should have stated Type 219 record.
>
> Type 219 is an HPE OEM SMBIOS extension whose contents are considered
> confidential, so I'm not at liberty to go into details. I will say
> that Type 219 describes features of the iLO which hpwdt is implemented
> against.
>
>
>> There is table 9, BIOS Characteristics Extension Byte 2, which specifies bit 3
>> as "UEFI Specification is supported.", but nothing that really maps to the
>> other byte, and no "misc features". Maybe this is HP specific, but then we'll
>> need to have much better explanation.
>
> This patch is to correct commit cce78da766.
>
> Our current servers do not support the CRU BIOS interfaces and we
> need to avoid calling it. Tom initially only checked that iCRU which
> replaced CRU was supported. But, later added code to extend to also
> test whether UEFI was supported to anticipate a time when iCRU wasn't
> supported either but where we still don't want to call back into CRU.
>
> Tom's original change was implemented to an older definition of Type 219.
> Unfortunately, the specification (and firmware) were modified to use a
> different pair of bits to represent UEFI. However, a corresponding change
> to update Linux was missed.
>
> The code is currently working today as the iCRU bit is correctly being
> checked. But as the purpose of cce78da766 is to protect the
> code for a time when iCRU isn't true, we want to correct the
> checking of the UEFI bit.
>
Please add at least some of that explanation to the description and reorder
the patches such that the fixes come first.
Thanks,
Guenter
>
>>
>>> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
>>> ---
>>> drivers/watchdog/hpwdt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
>>> index ef54b03..4c011e8 100644
>>> --- a/drivers/watchdog/hpwdt.c
>>> +++ b/drivers/watchdog/hpwdt.c
>>> @@ -707,7 +707,7 @@ static void dmi_find_icru(const struct dmi_header *dm, void *dummy)
>>> smbios_proliant_ptr = (struct smbios_proliant_info *) dm;
>>> if (smbios_proliant_ptr->misc_features & 0x01)
>>> is_icru = 1;
>>> - if (smbios_proliant_ptr->misc_features & 0x408)
>>> + if (smbios_proliant_ptr->misc_features & 0x1400)
>>> is_uefi = 1;
>>> }
>>> }
>>>
>> Presumably patch 2/3 and 3/3 are bug fixs and should come first
>> so they can be applied to stable releases.
>>
>
> I can re-order the patches or delay the first patch if necessary.
>
>
> Thanks
> Jerry
>
next prev parent reply other threads:[~2017-10-22 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 22:54 [PATCH 0/3] watchdog: hpwdt: driver update Jerry Hoemann
2017-10-20 22:54 ` [PATCH 1/3] watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT Jerry Hoemann
2017-10-21 2:25 ` Guenter Roeck
2017-10-22 1:41 ` Jerry Hoemann
2017-10-22 14:55 ` Guenter Roeck
2017-10-24 16:13 ` Jerry Hoemann
2017-10-24 18:42 ` Guenter Roeck
2017-10-20 22:54 ` [PATCH 2/3] watchdog: hpwdt: SMBIOS check Jerry Hoemann
2017-10-21 2:37 ` Guenter Roeck
2017-10-22 1:56 ` Jerry Hoemann
2017-10-22 14:56 ` Guenter Roeck [this message]
2017-10-20 22:54 ` [PATCH 3/3] watchdog: hpwdt: Check source of NMI Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3bfecf2-2ac6-4c1d-a03e-5f70aa03f7e0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jerry.Hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®