From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbeAZDEV (ORCPT ); Thu, 25 Jan 2018 22:04:21 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:44541 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbeAZDET (ORCPT ); Thu, 25 Jan 2018 22:04:19 -0500 X-Google-Smtp-Source: AH8x227TrT8Ks9IpOO2vndM1umVXrpRNNOCK7qhHQGMx4Z71UadbyovKn/UQqJ4/o2bfp9gVW2+cjw== From: Baolin Wang To: jason.wessel@windriver.com, daniel.thompson@linaro.org Cc: baolin.wang@linaro.org, mingo@kernel.org, arnd@arndb.de, broonie@kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] kdb: use ktime_get_seconds() instead of ktime_get_ts() Date: Fri, 26 Jan 2018 11:03:14 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kdb code will print the monotonic time by ktime_get_ts(), but the ktime_get_ts() will be protected by a sequence lock, that will introduce one deadlock risk if the lock was already held in the context from which we entered the debugger. Since kdb is only interested in the second field, we can use the ktime_get_seconds() to get the monotonic time without a lock, moreover we can remove the 'struct timespec', which is not y2038 safe. Signed-off-by: Baolin Wang --- kernel/debug/kdb/kdb_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 69e70f4..f0fc6f7 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2486,10 +2486,8 @@ static int kdb_kill(int argc, const char **argv) */ static void kdb_sysinfo(struct sysinfo *val) { - struct timespec uptime; - ktime_get_ts(&uptime); memset(val, 0, sizeof(*val)); - val->uptime = uptime.tv_sec; + val->uptime = ktime_get_seconds(); val->loads[0] = avenrun[0]; val->loads[1] = avenrun[1]; val->loads[2] = avenrun[2]; -- 1.7.9.5