From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C261ADC7D for ; Tue, 14 Jan 2025 09:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736848780; cv=none; b=l+oGQMhaqovqGmARoSCQkyf+RzqgXrCTkG6KAfwlWM0KRgX/nFn21bUT7N3YBCtn2/0yNgMU7NAOvtwB5g0SfwF38HcGiYWCwrvjgtZkakx6T8Y2gw2MfoY0TxeanaaKodLE1yN99Ixpx0McDTOUGxdRYPCSHGc37WKiRloE9xs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736848780; c=relaxed/simple; bh=PZcRmnI2h4F/hhDglgNNNnVq/bsrc/tDx+3g1RD6JOs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t4uo8sSAUVAmykVMZ+0UJAlAI5NXwmqSTeAPjhnHOqaaB0JiClpZ2Bpc4AwukvBz2iDYlfKh+Y78IkQeVN3MOVQNxagxyZQBpvKgTpWf5GWADuqPYB8BdGXI0DpvWLXlCzUP3eXp4RrOfKBAtQCJ4w/xH0tEmFdSPODpjw1ww/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g4K8YWYb; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g4K8YWYb" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ab2b29dfc65so814944066b.1 for ; Tue, 14 Jan 2025 01:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736848777; x=1737453577; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qv1jJD+Sb4D1WqjgjJOnNmg7mft9hCw88azA+ajAikc=; b=g4K8YWYb4OYy3AyZnwKodSFUluxylV0IaDZfYyxw/DJGIgyPjq6+Ez+NOT7FGeeGLz GK2f5U/3FJ9j4OrbtDRyZsjK1OJCFqo+ouz7al1I+RR/eAtdXkx1AWJIlF0KYCzWTvXc e/lj4H21ShpQCSy8WeW5VVBG1SDyOUJpSTidSnzbY+H2TmYs0X2zdP8Yv6/aCsJMK32Q JU9MBIyF9vELqbPKb3JSQdRRf/yp5DMu73tfSzyLlWbpYbjMzRoGiQBqfp+jYKBnSqI+ oJ/WguGbQY7MLlerHb3dzctKBJjOxHPKE4IKdJPw3HDZuJkIdlZ/7FCuNjew79jH/7LW o0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736848777; x=1737453577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qv1jJD+Sb4D1WqjgjJOnNmg7mft9hCw88azA+ajAikc=; b=I+zEyLrEPFgs+cKHAvtcc5XKyuUcG0vGc+4XA19bg2eLKymMN/WrGiuSNzVjXdL7RQ DGrGrhQ2gY2uxtPmhioMCUMSSZBZij9QcVa5H5qKu+ORSaC74SG+nxDj9r5V7CNGFIcF KgjXV/zMO85qJd5Qu7HpYt+fVQNTZtBX1Iyo1XgN7X/fLRsF3ZhCRvVEG+pl8U0XksOp kgxS4xuueYQg9pQ6pjuGzaRsjskX2445sbFVIJPNgpheK97RUWNEwFClS9dLvXTi+zNQ Op9a46Fldvdgs7TWj7EG8Ggxi4EzkpM8j423gN4YBXKjh5MACIDeJHfTnlSizVZsB/2L WLMw== X-Forwarded-Encrypted: i=1; AJvYcCVJ0uJ46tlpl8/U9wILPQAeizSA8LiMRJUjmTYkQNwKcRYKZaPnjWcZcHm88XLrdjVJuQVkT4H6JB86h5w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+W4pWpIHDOyNWjxk85LOH0fGLUso+cIkH2m6piPosRHZdNyru io0uUtNlTMUvb2pCNZB+qH29UI/fsWvIP3/PyruOoX6uKU+ZGZAPasodrOWoqK4= X-Gm-Gg: ASbGncuy2qAPjyK85ygMNznpu269mxMOKWHLkITotaUnNb3JQ851nTWETBcfEncmIKs us7jiOjJJPTyAMwIljWGEyJ64HwwRduM4I8WPFZlojj/f5oIDz6jmLryu8nGxzXWW5kUu7JNXtQ j+qiukKQXHvX+TV9UEU9E/IFTll4lqntZvN6h3nBH142hl/zBbmxjhZfSO39si3lZl8V2rtjwx5 D633FnH9R2wCqC6a2BTk/t8D/tjPzBkEr+tEG9SkN5MgJ2RBbM+rgSKiKU7ig== X-Google-Smtp-Source: AGHT+IGQwGV+OCJyZcmr85VT1IKTszmeQgkTPCcj7NQDW10pvZs1NvQF9hL554XdKRbEnnfnUmfYWg== X-Received: by 2002:a17:906:f44:b0:ab3:ed0:ce7 with SMTP id a640c23a62f3a-ab30ed00de2mr777849966b.55.1736848777178; Tue, 14 Jan 2025 01:59:37 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c90d6a4csm608709566b.71.2025.01.14.01.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 01:59:36 -0800 (PST) Date: Tue, 14 Jan 2025 12:59:33 +0300 From: Dan Carpenter To: John Meneghini Cc: Karan Tilak Kumar , sebaddel@cisco.com, arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, aeasi@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v7 07/15] scsi: fnic: Add and integrate support for FDMI Message-ID: References: <20241212020312.4786-1-kartilak@cisco.com> <20241212020312.4786-8-kartilak@cisco.com> <4141c9ab-c640-4765-a23c-c2f64df687cb@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 13, 2025 at 12:35:03PM -0500, John Meneghini wrote: > Just a note to say that these patches are important to Red Hat and we > are actively engaged in back porting and testing these patches in to > RHEL-9 and RHEL-10. > > I think these issues that Dan has pointed out are all issues which > can be addressed in a follow up patch. I mean we already merged this. I only got involved because of static checker issues in linux-next. What I'm complaining about is not so much any specific issue but just that the process was not followed. Normally this patch would not be merged. If anyone sent a patch like this to drivers/staging it would have triggered Greg's patch-bot automated response: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. This rule is the same in every subsystem. No one wants to merge a patch like this. But what happened is the patch sat on the list and only Hannes and Martin were doing any review. Karan was left doing all the work with no help or guidance. Eventually Martin has to give up right? The patchset isn't up to normal standards but it's basically okay and Martin can't do every single thing by himself and eventually it's pretty clear no one else is coming to help. It is what it is etc. Please understand this in the gentlest way. Next time if something is important then assign an engineer to help out. It would have taken a day to prepare this patchset for merging. You had seven months. It's not fair to show up five days before the merge window asking for special exemptions from the review process. Maintainers and reviewers are already overworked, they shouldn't have to work around your deadlines. >From what I've seen Karan is absolutely doing a good job addressing the problems I reported so it's fine. But normally this is not how it works. regards, dan carpenter