From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F245215077 for ; Wed, 14 Jan 2026 01:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768354525; cv=none; b=BCk3HAaa6rZVXxii7o4cT4B/w9+c1gwkj3p6PamRDyfHNApuNHES7fmhQmi/QVTI+aZg4PlHheM8ibHOklcBOt025SwlFGbFgh/dRAPTTbi1Puwg7d9Wfa7PYBZZXXnPEdt3d09qwmt0dRZ5WIiGOWzBts2jFo4DJDW6di7dYfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768354525; c=relaxed/simple; bh=UBZ0xQQc9x8hovtqO2IzmbFI/0v4QnsYfchssHdggm0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p4fXCqJ8YenYX8W1Vj5SqwLWFP1oNivViFOxmCCNaUZXe4Jpp8aNGfpwAxIj9jD3jBZWS0oth1DyTXTCs1oX2ivjwBLEymeRmPPU7qv7HYuttOSY7c51nh2QSZikReTGf5FVr/S0wdD0RM52r9mo0Xs5zHBANhCUfbkjI0Ta7KA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZiA2R61a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ya1IrjUt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZiA2R61a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ya1IrjUt" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60DNHl36984992 for ; Wed, 14 Jan 2026 01:35:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tbLyVWXmVL2eJA5y9LHtBYuhAL4cRiZrb7+YgmccOwA=; b=ZiA2R61aKbKsjkg7 Td8zVE0CnaONJv/7WcJYbYZq3z4DJ7cH/G3jjWGjPuPJw0eYqg7wU/DRdgT4tQqj gRhMepTlYfvIMg3ZSLkbwTEg8WDPbNjyRSZb2QrDJzJ2XP/chbJ27mKcJNrG7hyF jN1s3kKZrgDlvKxtoyCjWBc64T3KFzY0C6pP9iHqQT3i14n2YaWCQuRGxgT40HlM OwS4VBAWR5jUUS8BEAnffexffy7GmYoPS6/5BzJDDFUZZwk3xZ0OwAhibNQgne0f Ehz5Bl8c6z175gJU4LUbCh0vBEqesJKTy/bcLbw2e1EbQ6MomP1mYvF5vTnogvPU WC0FAg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnr3e9vve-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 01:35:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0dabc192eso79344965ad.0 for ; Tue, 13 Jan 2026 17:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768354520; x=1768959320; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tbLyVWXmVL2eJA5y9LHtBYuhAL4cRiZrb7+YgmccOwA=; b=Ya1IrjUtRwRgqnmkoHXH/97iCaA9lrBJLTi4KAWIqmc0inWajrj9j72NcTvq6rmvpK 8qejhs362O14suT+RSsJJOWKKt51DuFeJCjo8oTj7VNt6djHel0pf9bBAtS2Nuq3agXA ImvMLIVQee/MFciclHKFVariq/upMdenhVyTdwd4Hfb4KeGj1Kfye1aAETWniTk0i3QH RGg/Zisd7+eeplLOi5eqUgcIJYOYmzmnNw2W8hI3mUKxObop8u73GwPnctmwQ/jSJ9ZX KkT12ZdE424GzSPzNKxNiNt0LCwJS56d/SfPUcLtEYKO/xHkiXqrdZRjIhFT80eqVzjD tyhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768354520; x=1768959320; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tbLyVWXmVL2eJA5y9LHtBYuhAL4cRiZrb7+YgmccOwA=; b=YxZhdk+8uAFLGCKsEg6zgPhugWRBK12h8Q09BYA8r7DcJARa4HJzqqiGp/qq96iK0G 3zr8Du3zpcHCerPqTKzrNUbDCQxDPkdoe/lsheZ/Ug7VUj42osE5IFx2PGyK3RinBzRz EcEyUaW56xLZjGl/qE/TPU1lj2buo2VewuCoYlCny7THMfbI+9zzaLnEkBRmft3ejawV JsEus5wDiGufJbZGyWov9B3iMNKBRneC3UesNczghDxfYKaADL0dk2t0aGOOptN9RiLV KZsMLBtOoox9qKqU/W1WFDZth9lU4cXorozdu42wm0cbSMI9LbHX7x+9WOxpvFtYfQKD LI0Q== X-Forwarded-Encrypted: i=1; AJvYcCVlri+03ZLxT7FGRY9jXXfUgY5geIqKc2o+ZquMyiv3NGTlo1pbpa/j6VA2ownlZl0F+qsQv3C9CVVe+0k=@vger.kernel.org X-Gm-Message-State: AOJu0YytUAlTCsZMbvhasu6/Re8ms4FvRysMQxxvE/s3ZpPW6++XCd9M /XKx/KRcY43JpF2TJxRYppcRKr+zKEqpZngtueZXrsublxymdjLkFWRjQ+DP7E8WXL/dm+ja24n Cc3raxehzrkYByWkPQL9QD+rAJNsE8D9vyaZILatAzahpL4lR1n7sEA+JfmXPFbkM8wE= X-Gm-Gg: AY/fxX6gM7BhpKy055iz9aCns1pFUfocnSYlz6k3kz2ZtwJSQA32spnPrmRptO/pEgB aBuqwNaMLvdiGZAt8rw+lG+zhPCFV4mh8ymbFScSEFjGrByZ1HAV/86HsZR66tP+tM+ZUhPiO3q yJ0xCDdxkEoXr7frZQAOysL1RVYvlsCylJo1u7HO5il435aGOGxepdelHXPB/bFIP6OuCGiJL9G OaN2TWFzGtWiiVjjEMWh1jqLdBt/e45kxu5RPqXLeN8oBYRb9lw/cvZ2WmAClD1Q2/cwCXPQnxO k6NMC0Bus4bzlJ0MDycgRvsAFcqKNOHcvqcRGu9zYQgkKfwzeTt1Kb9QhAKTkPjfenFTNFP9PYY oxnl5dMFPiVwnethIYhsSTxE/5207z12EN/LUagveR+IMh0VOD46WZqXVGpMLRvVas8jUBXJYoK XcFpmdSQ== X-Received: by 2002:a17:902:c410:b0:29e:a615:f508 with SMTP id d9443c01a7336-2a599e23086mr9724725ad.28.1768354520263; Tue, 13 Jan 2026 17:35:20 -0800 (PST) X-Received: by 2002:a17:902:c410:b0:29e:a615:f508 with SMTP id d9443c01a7336-2a599e23086mr9724405ad.28.1768354519752; Tue, 13 Jan 2026 17:35:19 -0800 (PST) Received: from [10.133.33.186] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3ba03f9sm210077615ad.0.2026.01.13.17.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 17:35:19 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 09:35:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] media: qcom: camss: Add SM8750 compatible camss driver To: Vijay Kumar Tumati , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20260113-sm8750-camss-v2-0-e5487b98eada@oss.qualcomm.com> <20260113-sm8750-camss-v2-2-e5487b98eada@oss.qualcomm.com> <61801034-225f-429c-9f34-f80044506bf3@oss.qualcomm.com> Content-Language: en-US From: Hangxiang Ma In-Reply-To: <61801034-225f-429c-9f34-f80044506bf3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=TPFIilla c=1 sm=1 tr=0 ts=6966f2d9 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=3IMT_TZWw9feNxxRiIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDAwOCBTYWx0ZWRfX7vg1KUa6VbRq LxB+tqXVNs8Uwl5ONcB4ZJNCnTucPO54ZFuUfB97FfSUDMTTY0dqR8K3hQj1J/uPDr0vCO6l/xN 6jXWLNF3Kwhenc+SCxai9klMzPN3qqBSifwUpWd1yg2CE9bb0BxbS6VexrpotOlHRAYmJ9mi2v8 7FK4mCo+u7GK+otp1RlP+VfGkN0XN/5HWYJ+GFVJPk4JYhbFlmW7GK3Iag6bnK3jVlJrRPFIot9 6xXHO5YxoUcx15uxbYb6A/MfdY5N4M+v8EarU0s3UBsuwEd7an55Emyc1g2uYXC6THnDD2gVbs5 Zc9uzovDDtWwbaG0DqBKl142du5hPXiMwD+dK10ewaC+XSJg+bv2gNMvscybUI2FdU1e8QHYN1p caSM02WH+wxCrQ208lOX8P1hjbbT6yu8Ls7nCOxoMUveE2mhDDiBLHthOBAFqAOM6KhCQFSOaqw CCu92h+Vu+JOlfwpf0w== X-Proofpoint-GUID: ngVBp9epXqULRljGdEUmvGfADIYT3_vL X-Proofpoint-ORIG-GUID: ngVBp9epXqULRljGdEUmvGfADIYT3_vL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_04,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140008 On 1/14/2026 4:53 AM, Vijay Kumar Tumati wrote: > > On 1/13/2026 2:28 AM, Hangxiang Ma wrote: >> Add support for SM8750 in the camss driver. Add high level resource >> information along with the bus bandwidth votes. Module level detailed >> resource information will be enumerated in the following patches of the >> series. >> >> Signed-off-by: Hangxiang Ma > Hi Hangxiang, I believe some reviewed-by tags are missing for these > patches. Can you please double check? >> --- >>   drivers/media/platform/qcom/camss/camss.c | 22 ++++++++++++++++++++++ >>   drivers/media/platform/qcom/camss/camss.h |  1 + >>   2 files changed, 23 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/ >> media/platform/qcom/camss/camss.c >> index 36ff645d9c1e..56f20daeca3e 100644 >> --- a/drivers/media/platform/qcom/camss/camss.c >> +++ b/drivers/media/platform/qcom/camss/camss.c >> @@ -4066,6 +4066,20 @@ static const struct resources_icc >> icc_res_sa8775p[] = { >>       }, >>   }; >> +static const struct resources_icc icc_res_sm8750[] = { >> +    { >> +        .name = "cam_ahb", >> +        .icc_bw_tbl.avg = 150000, >> +        .icc_bw_tbl.peak = 300000, >> +    }, >> +    /* Based on 4096 x 3072 30 FPS 2496 Mbps mode */ >> +    { >> +        .name = "cam_hf_mnoc", >> +        .icc_bw_tbl.avg = 471860, >> +        .icc_bw_tbl.peak = 925857, >> +    }, >> +}; >> + >>   static const struct camss_subdev_resources csiphy_res_x1e80100[] = { >>       /* CSIPHY0 */ >>       { >> @@ -5487,6 +5501,13 @@ static const struct camss_resources >> sm8650_resources = { >>       .vfe_num = ARRAY_SIZE(vfe_res_sm8650), >>   }; >> +static const struct camss_resources sm8750_resources = { >> +    .version = CAMSS_8750, >> +    .pd_name = "top", >> +    .icc_res = icc_res_sm8750, >> +    .icc_path_num = ARRAY_SIZE(icc_res_sm8750), >> +}; >> + >>   static const struct camss_resources x1e80100_resources = { >>       .version = CAMSS_X1E80100, >>       .pd_name = "top", >> @@ -5518,6 +5539,7 @@ static const struct of_device_id >> camss_dt_match[] = { >>       { .compatible = "qcom,sm8250-camss", .data = &sm8250_resources }, >>       { .compatible = "qcom,sm8550-camss", .data = &sm8550_resources }, >>       { .compatible = "qcom,sm8650-camss", .data = &sm8650_resources }, >> +    { .compatible = "qcom,sm8750-camss", .data = &sm8750_resources }, >>       { .compatible = "qcom,x1e80100-camss", .data = >> &x1e80100_resources }, >>       { } >>   }; >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/ >> media/platform/qcom/camss/camss.h >> index 616ed7bbb732..2a53524dec93 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -91,6 +91,7 @@ enum camss_version { >>       CAMSS_845, >>       CAMSS_8550, >>       CAMSS_8650, >> +    CAMSS_8750, >>       CAMSS_8775P, >>       CAMSS_KAANAPALI, >>       CAMSS_X1E80100, > > Thanks, > > Vijay. > Hi Vijay, the B4 tool didn’t retrieve any ‘Review-by’ tags before I submitted this revision. Since I wasn’t sure if they were valid, I didn’t handle that by adding tags manually. Hi Bryan, is it possible for me to add the 'Review-by' tags manually if B4 doesn't pick them up automatically? Your feedback would be helpful so I can manage this situation better in the future. Best Regards, Hangxiang