From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: "Marc Aurèle La France" <tsi@tuyoix.net>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH} ntfs3: fix [df]mask display in /proc/mounts
Date: Fri, 30 Sep 2022 18:41:53 +0300 [thread overview]
Message-ID: <b3d04e78-c6d0-17ec-620f-5125e645dd00@paragon-software.com> (raw)
In-Reply-To: <d3337d95-201c-43bd-3b37-4fd9e654d821@tuyoix.net>
On 8/10/22 23:28, Marc Aurèle La France wrote:
> ntfs3's dmask and fmask mount options are 16-bit quantities but are displayed
> as 1-extended 32-bit values in /proc/mounts. Fix this by circumventing
> integer promotion.
>
> This change is not eligible for stable@.
>
> Please Reply-To-All.
>
> Thanks and have a great day.
>
> Marc.
>
> Signed-off-by: Marc Aurèle La France <tsi@tuyoix.net>
>
> diff -aNpRruz -X /etc/diff.excludes linux-5.17.1/fs/ntfs3/super.c devel-5.17.1/fs/ntfs3/super.c
> --- linux-5.17.1/fs/ntfs3/super.c 2022-03-28 02:03:22.000000000 -0600
> +++ devel-5.17.1/fs/ntfs3/super.c 2022-03-28 07:14:10.799008309 -0600
> @@ -518,9 +518,9 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
> seq_printf(m, ",gid=%u",
> from_kgid_munged(user_ns, opts->fs_gid));
> if (opts->fmask)
> - seq_printf(m, ",fmask=%04o", ~opts->fs_fmask_inv);
> + seq_printf(m, ",fmask=%04o", opts->fs_fmask_inv ^ 0xffff);
> if (opts->dmask)
> - seq_printf(m, ",dmask=%04o", ~opts->fs_dmask_inv);
> + seq_printf(m, ",dmask=%04o", opts->fs_dmask_inv ^ 0xffff);
> if (opts->nls)
> seq_printf(m, ",iocharset=%s", opts->nls->charset);
> else
Thanks for patch, applied!
prev parent reply other threads:[~2022-09-30 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 20:28 Marc Aurèle La France
2022-09-30 15:41 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d04e78-c6d0-17ec-620f-5125e645dd00@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=tsi@tuyoix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®