From: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: kpallavi@qti.qualcomm.com, srini@kernel.org,
amahesh@qti.qualcomm.com, arnd@arndb.de,
gregkh@linuxfoundation.org, krzk+dt@kernel.org,
conor+dt@kernel.org, quic_bkumar@quicinc.com,
ekansh.gupta@oss.qualcomm.com, linux-kernel@vger.kernel.org,
quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
jingyi.wang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com,
ktadakam@qti.qualcomm.com
Subject: Re: [PATCH v6 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Date: Mon, 22 Dec 2025 14:38:28 +0530 [thread overview]
Message-ID: <b3d2c54d-f2ea-420a-b7f3-b9e60a96a841@oss.qualcomm.com> (raw)
In-Reply-To: <20251211154139.GA1424272-robh@kernel.org>
On 12/11/2025 9:11 PM, Rob Herring wrote:
> On Thu, Dec 11, 2025 at 03:39:30PM +0530, Kumari Pallavi wrote:
>> Kaanapali introduces changes in DSP IOVA layout and CDSP DMA addressing
>> that differ from previous SoCs. The SID field moves within the physical
>> address, and CDSP now supports a wider DMA range, requiring updated
>> sid_pos and DMA mask handling in the driver.
>>
>> Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
>> ---
>> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> index 3f6199fc9ae6..142309e2c656 100644
>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>> @@ -18,7 +18,12 @@ description: |
>>
>> properties:
>> compatible:
>> - const: qcom,fastrpc
>> + oneOf:
>> + - items:
>> + - enum:
>> + - qcom,kaanapali-fastrpc
>> + - const: qcom,fastrpc
>
> Does the driver work at all on this platform without the changes in this
> series? If not, then it is not compatible with "qcom,fastrpc" as you
> say here.
>
Thanks for the clarification
No, it doesn't work on kaanapali without this patch series
I have updated the bindings accordingly to allow
either "qcom,kaanapali-fastrpc" for Kaanapali or "qcom,fastrpc"
for older platforms
properties:
compatible:
enum:
- qcom,kaanapali-fastrpc
- qcom,fastrpc
Regards,
Pallavi
> Rob
next prev parent reply other threads:[~2025-12-22 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 10:09 [PATCH v6 0/4] Add ADSP and CDSP support on Kaanapali SoC Kumari Pallavi
2025-12-11 10:09 ` [PATCH v6 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali Kumari Pallavi
2025-12-11 15:41 ` Rob Herring
2025-12-22 9:08 ` Kumari Pallavi [this message]
2025-12-11 10:09 ` [PATCH v6 2/4] misc: fastrpc: Rename phys to dma_addr for clarity Kumari Pallavi
2025-12-11 10:09 ` [PATCH v6 3/4] misc: fastrpc: Add support for new DSP IOVA formatting Kumari Pallavi
2025-12-11 13:38 ` Dmitry Baryshkov
2025-12-11 10:09 ` [PATCH v6 4/4] misc: fastrpc: Update dma_bits for CDSP support on Kaanapali SoC Kumari Pallavi
2025-12-11 13:38 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d2c54d-f2ea-420a-b7f3-b9e60a96a841@oss.qualcomm.com \
--to=kumari.pallavi@oss.qualcomm.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=amahesh@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=kpallavi@qti.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=ktadakam@qti.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®