From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E089A248F72 for ; Tue, 27 May 2025 08:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748333975; cv=none; b=W0u7A/s/x9kwtvMF1xSbhaiqX73wav0U9fo/B920fWiuv5y3cn35T8elPgRowmbwGeQRODBwkDiulknjZxNIjgz3VYrtfFDSnDhU5/zlzbEHXrAh4cyNFQ15kJVF6bURNED5mWj7jtZZDfKHA14bEUHWiW2zqxLDSPCQacQ9+jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748333975; c=relaxed/simple; bh=ia8kZdP0HFoJkRuqfb9xYK3PP1X9WFdfCow4Ewno8P0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qopnBluu+O4+/SskQUQNMZPb3y6dA5jG0Vo9A3KLsxVf+1Zb0lIF6hcnOtBZY/ZeZpgmim4CgI0BNyyRjiz4+WrJOoG24ikOFUqxe7a0fzEN/lqDc9vadO7lIBkK5iBPsdqF0HITMo6i7KnlypZm7Tcoql3ikaG7yzLlmWR6W6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pVTYCAhX; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pVTYCAhX" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-441d1ed82dbso35859795e9.0 for ; Tue, 27 May 2025 01:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748333971; x=1748938771; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dMOUzI+Rl9kCd96v3bJcE+T2pFM5Ij46/8q1c510Oug=; b=pVTYCAhXK0P46qJjOhOoNjEwGWdy7Z6CbVLokeqZf5mbK9vDAB/ep6MskK6VIrTfQM EcTNKvJs+jSB34M0oV7Na+ujMXdhffd4tDC/8qp063d2j4XOksNeFdgISMj/X30xiJty gM+/hTM8P4rLkgm6gk2IOrhD/j7Ci+M7BfWzfv9DnF6kAqPTK2xRO1y0N6Ys3TGzHWo0 jvogReYJOQsXzrxW+qlqyBAHShL3nJ0lctCRC0DL2X8DM5+R6m5IQS9P03ZJenMhK1Zd Uw4mVOIF5+8jAq/hpmbzULXJXPlhDQVhVoIvDYV/IacmYptdI0gtYpQbDqi5O1XyNlnJ 3w6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748333971; x=1748938771; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dMOUzI+Rl9kCd96v3bJcE+T2pFM5Ij46/8q1c510Oug=; b=YnjUyUSM1h61RCWkkzq0iPYI83V7L+V4LYxS0lCOJRe7qyiubZ9ViDoHx3OqnG7qT5 gb/zFAvJSwhyNLa1qArgwcQ5dWiBVDfxxRDoPMOmI6Cr2BhZ0L+Vadctx9I8kSBRTOhf Y7X56YOX7vwVU/HWYXu2mRblhyCRiHDez8XPjF4yM8WFgY4H1NcggFlCFb1+kc9Dl+EZ StFv2TtOGueEbzYk41SXkhjp1mrWODHCsYAMPlWU6ZnnCGexB+oitttnbcluqB1F+I7O 6z1ozFiN5aWQYZFgIjTyNx95U0f8lsSfR3vuGHZCGld98ZuSKdJGI00gzhQfCvXA/bGL Jedw== X-Gm-Message-State: AOJu0YyPr7no315QKGoAJUbNdDEaJ255Y23qmm638r77sQOVPFXmW5rl O1KGFdU4lb0n+2BbC8efCq4UFQBa5flGfdn6S7kdcNavb0b8PX/H7pSYCy/Q0ZefSnY= X-Gm-Gg: ASbGnctpQ8eIhQuMqKDzNqTachVmYYhCy2HmIiDRkAULnETHWHFyv/akcKu5yn+igjC 216L3r4sd0b4ZX/bEMvDgLeuaAvLXAhHoUVskpw7rQPziTbhjPCVDYp3XlYuc5bbAumB9lyIhtc Y1Tqt0DUD3V34wB94VL28kAeeea5vqZsny+zWKlU1eB4PNvdkwdL7i8HfMxsDFjU+yy96N0DyIl Cb48QZcOFnjFhXrOCK8V9cKIWk4cdCz6AX95Ghf18R4W/AG4BoLxH9l9bU9WeEhoOVsdKzcmJWa I1ICk8J5HEvKW9jqq7LQMtVd9r0UDr88EBsk4maC2/SltTCftSrtGeaOnoOcAczCwNO+CHJIShF QS/zDko58rq5x682C X-Google-Smtp-Source: AGHT+IFjTsGVi2CK4OkLJrI3Smdv4M+APjpCmrgDiR1D6zlgPXvjVIxxpzIlokGl7A7BbOpPT/vmFw== X-Received: by 2002:a05:600c:a13:b0:440:6852:5b31 with SMTP id 5b1f17b1804b1-44c91dd151amr132439605e9.10.1748333971167; Tue, 27 May 2025 01:19:31 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4d53ce0b4sm6807921f8f.37.2025.05.27.01.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 01:19:30 -0700 (PDT) Message-ID: Date: Tue, 27 May 2025 09:19:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support To: Vincent Knecht , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250525-camss-8x39-vbif-v2-0-6d3d5c5af456@mailoo.org> <20250525-camss-8x39-vbif-v2-1-6d3d5c5af456@mailoo.org> <10c45ae1d2453f7c81dadeb132b6c2911ab7d95c.camel@mailoo.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <10c45ae1d2453f7c81dadeb132b6c2911ab7d95c.camel@mailoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/05/2025 17:20, Vincent Knecht wrote: >> You have both >> >> if (vfe->res->has_vbif) { >> >> and the above switch, there's no point in checking this twice in two >> different ways. >> >> Choose one, suggest has_vbif is enough. > I think the switch is still needed, so that distinct settings > can be applied for different SoCs. > > Or should I just apply the 8939 settings unconditionally, and keep it > as an exercice for the next dev who need other settings for another SoC > to deal with ? 🙂 > > Thanks The flag should be enough. --- bod