From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763319AbdAKK2Y (ORCPT ); Wed, 11 Jan 2017 05:28:24 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:43519 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761334AbdAKK2V (ORCPT ); Wed, 11 Jan 2017 05:28:21 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7ef-f79d26d00000420c-84-587608c2ad92 Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board To: hoegeun kwon , Inki Dae , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang From: Andrzej Hajda Message-id: Date: Wed, 11 Jan 2017 11:28:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-reply-to: <94285a63-68df-494c-872b-41c5810a3251@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIKsWRmVeSWpSXmKPExsWy7djPc7qHOMoiDDb/EbHoPXeSyWL7kWes Fte/PGe1mH/kHKvFla/v2SzeL+9is1g6o4/VYtL9CSwWN361sVr0P37NbHH+/AZ2i8u75rBZ zDi/j8ni/54d7BY/d81jceD32DnrLrvHplWdbB7bvz1g9bjffZzJo2/LKkaPz5vkAtiiuGxS UnMyy1KL9O0SuDIar01iK7goULF+eRNLA+Nr3i5GTg4JAROJzZv+MUHYYhIX7q1n62Lk4hAS WMYosWDJdRYI5zOjxPdTs1lhOqaeOMMMV/WqcT5YO6+AoMSPyfdYQGxmAU2JF18mQXU/Y5S4 39rADJIQFkiWuNreC5YQEdjAKDFx5m1GEIdZ4DujRP+7FewgVWxA7X8332SDGGsnMWPWHDCb RUBV4vtOiBpRgQiJQ8dug03lFLCXuPX7BhvEanmJg1eeg22QEPjKLvHuzQSgBAeQIyux6QAz xA8uEs/uHWWHsIUlXh3fAmXLSFye3A3V280o8an/BDuEM4VR4t+HGVDd1hKHj19khdjGJzFp 23RmiAW8Eh1tQhAlHhIzD19kgQg7Suxo04UExUxmid8vz7FPYJSfhRRks5CCbBaSHxYwMq9i FEktLc5NTy021CtOzC0uzUvXS87P3cQITFin/x1/v4PxaXPIIUYBDkYlHt4HL0oihFgTy4or cw8xSnAwK4nwKrCXRQjxpiRWVqUW5ccXleakFh9ilOZgURLn3bvgSriQQHpiSWp2ampBahFM lomDU6qBkVn/FZdIC8O8uXcb/IOkKr9G+15R89JyEO3ZY1Yu9WNiUEV6r7z8iU8Kf5l65lx6 W+3d98D3lonGto7wCs/An1f0LrlKf/50LlPSdLeShYrDGc9NfuFRP50EL2xjl9U5v+cHs8u9 mNByj9qVH6z8g15uW8vzL6lflSeXPXbelj0rnL2zrtspsRRnJBpqMRcVJwIAzT1AeVQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t/xy7rbOcoiDO7eM7LoPXeSyWL7kWes Fte/PGe1mH/kHKvFla/v2SzeL+9is1g6o4/VYtL9CSwWN361sVr0P37NbHH+/AZ2i8u75rBZ zDi/j8ni/54d7BY/d81jceD32DnrLrvHplWdbB7bvz1g9bjffZzJo2/LKkaPz5vkAtii3Gwy UhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X 4JbReG0SW8FFgYr1y5tYGhhf83YxcnJICJhITD1xhhnCFpO4cG89WxcjF4eQwBJGie72K2AJ XgFBiR+T77F0MXJwMAuoS0yZkgtR84xR4vSu26wgNcICyRJH181nAUmICGxglGhdeZcVomom s8SZJXvZQRxmge+MEsf2/GMBaWET0JT4u/kmG8QKO4kZs+aA2SwCqhLfd65gB1knKhAh0XA4 HSTMKWAvcev3DbASZgF5iYNXnrNMYBSYheTAWQgHzkJStYCReRWjSGppcW56brGRXnFibnFp Xrpecn7uJkZg3G479nPLDsaud8GHGAU4GJV4eC1el0QIsSaWFVfmHmKU4GBWEuFVYC+LEOJN SaysSi3Kjy8qzUktPsRoCnTqRGYp0eR8YErJK4k3NDE0tzQ0MrawMDcyUhLnnfrhSriQQHpi SWp2ampBahFMHxMHp1QDI8+/fs9DF7TVzsmcvu61NFKh2mfb7UjzQzddBKby7rxzxfCL1OY9 73ZzbNjVO/NsxTGhqV81Xj1asWft3zfzns579n7lH8u66tiodWKLCmYdrT+a/+LmtqMVz348 zeE/1bb2E4NI5P954p9zzjV7PT6zemOO6qOjL39GcDvryf9qfvVUOKZs4l4dJZbijERDLeai 4kQAMGNBhfECAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111102815eucas1p1e8eb03c19fda2f9247d322635fab31e3 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 X-RootMTR: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> <5875EF69.1070803@samsung.com> <581db2a8-e357-a3ba-9464-fa8f83f95c09@samsung.com> <94285a63-68df-494c-872b-41c5810a3251@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.01.2017 11:23, hoegeun kwon wrote: > > On 01/11/2017 06:39 PM, Andrzej Hajda wrote: >> On 11.01.2017 09:40, Inki Dae wrote: >>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >>>> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>>>> From: Hyungwon Hwang >>>>> >>>>> This patch add the panel device tree node for S6E3HA2 display >>>>> controller to TM2 dts. >>>>> >>>>> Signed-off-by: Hyungwon Hwang >>>>> Signed-off-by: Andrzej Hajda >>>>> Signed-off-by: Chanwoo Choi >>>>> Signed-off-by: Hoegeun Kwon >>>>> Tested-by: Chanwoo Choi >>>>> --- >>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> index ddba2f8..6d362f9 100644 >>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> @@ -18,6 +18,18 @@ >>>>> compatible = "samsung,tm2", "samsung,exynos5433"; >>>>> }; >>>>> >>>>> +&dsi { >>>>> + panel@0 { >>>>> + compatible = "samsung,s6e3ha2"; >>>>> + reg = <0>; >>>>> + vdd3-supply = <&ldo27_reg>; >>>>> + vci-supply = <&ldo28_reg>; >>>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>>> The same here (as in 1st comment) , te-gpios should be dropper - decon >>>> uses hw-trigger. >>> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. >>> >>> Thanks. >> OK, I forgot it was not yet ported to mainline. >> >> Regards >> Andrzej > I received a reply while I was writing the mail. > so, how about removing te-gpios later? I think this is a good solution, just do not forget to change it to optional in bindings, to make it removable. Regards Andrzej