From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD4423ABBF for ; Sun, 23 Aug 2026 16:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787502883; cv=none; b=OIOkuYrp63/Im4LESAuSx6JCYSF37NdOGcVkMi22R2woylInqA+yIkZNN8l5adVkMBtU+TmUFuoGSwLWg7u9ctuBm+U9iynzCJEg+nMreVPT6I7mb727IuddAxcHY7fcopSE+/0VS+aE4kCzBnAW9MAa0sR0SWU2Xv7ahlTPRx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787502883; c=relaxed/simple; bh=02ybAsaiwsvWoQcNLX0GyaEbVxLKweh93ot9JkZWSS8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FB3SJxHau29RBNoob8whK38EZamGw1izPg6kMJ9fnphSu/zp5d5wST2Sxqr8SPjOangnaNOMhplD+ZN8Y+pwV2PqmIARMI2PkWTZ/6lA76CVfdYAkT8xN/vDsQ0zv67sZ0Rh2KtozX31nGOyPkv+i6tEWRicG4mn7+OVO7w07EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bxh28NaE; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bxh28NaE" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-cbee3777e1cso1558388a12.3 for ; Sun, 23 Aug 2026 09:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787502882; x=1788107682; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8sTClNBlu3puMMXbF+SQ5upo6RgBShUKol0pOMHxtJA=; b=Bxh28NaE3pZmwYRPHlFnO0NJjlRoBW6i7MJTKXjWYJeZg7H5rItuAXsbWfUjtlEwLL l7M5JnVUwdlj7U+4zfIeqOD3Cr+x0f3Q5yzGxa2kitvN/BHlvZNpSPcjQ9Wo89fV2z0V 9BlAeL5GgGoRv0puyS3IZ6dHhiiLod53PErWCiEdCkwXfkW3oqN9xuz2E6IPOVHhlQFn X3BCVEuSF53EDE78fqvtIPR9zjuEvofvhrKS/emlHAJc+p6qViczQFWbbyXbE6JqdEwS FwKswdnXW8g9zZaClVu2x1dUwXnm5UTWlhdKuXjHloyTnXxIJy8x3SCuUFdAptIBtXFk toPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787502882; x=1788107682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8sTClNBlu3puMMXbF+SQ5upo6RgBShUKol0pOMHxtJA=; b=musDe0ecSXNjSeM+Hi8+oJkud0hmj1r4DpliAOtHyOPqXOzuiOsgwN1PNywXGqXbfF 7R5Ki66ALMfRq0mPmruPlFzeSehZbTmU/9WdX14PTRvXHoRHvsMxAQ1v88ZUb7jaLRCt Ur05NzDhjGkPoDJAX8236GYTB7+ayEclOELg/zf8sqKq0rhsrJaD8SP9RUq7Ws1+vP9o FLyaRs7fi0f7KqlkACgkeexU8qxkf4v8hDs5neyQq7phhE3NhcKgHq0C9NWWqb60rcr6 th9OHdrCiESLVB2r3+T99YeQF/pLqI/9qlb8k1SByTzlbNXIXKUriarYHGstp9UHAR3f OqDg== X-Forwarded-Encrypted: i=1; AHgh+RrJ93ZaDGu2uPjeilgSR4B4niQ0J65C76v3K/OBY/B18Zm2/TbTbaaAcmUujbJzx7SzU/pkeiBkU1YxkNk=@vger.kernel.org X-Gm-Message-State: AFuF++kpu2sfenv64Ip7qYsMveDrsjbItnb2jELxKcNcmnSR225oiVoX 2w5AUnPpV+IAN3Dh7CrJVC7CuYeyA+LGSHsbp4EMAR37ilB4qeaTuJ+s X-Gm-Gg: AR+sD12DjZSLcMF4Xp6eLVW5qOg12CiWUZUyBWip9A3LPqOFP9ZXR+s+Byh4To0nS6c BUBS9+Qg4JEpUHqyrCgzq38KbWiHdJcL7AhsOZqQ3Jwy0JkxfBdTAwRhiPY9kJpzahzIOepWJ0H JlcqbRu4JmM9zVGGfEEzJiz5lSd0eDepwKaKfsFiFqzxaIgWPZamhXW6T4eHcSdUgSAXQK0iPUd i/bknjFgMsPRiezAGIg108aZruzUnA4OXOZTm4w9srW8DNyC7opqBBRhz0demaArJk6oxCoPo96 C/PaokLkQuTfa6KuMsDt+tqk/UvDUpYfZbszb6X9aTINHfPDrhPT/gV8RCEcCUUql8EwzLmKEjo WBsqcqhqyN2oafONs+n5LSjzTtVqZ7CjBxJGT2vonL5H2nsbfi1rFamGvTMRsvR/7txvCxztMUd RknIP2GgZhvLdpj8uPWXUKyskIDj/hFaJXdRAX0x/wBekZ4DCOf+gerfqVj0Cy2FIL0sArPVemP ZUO0Nw8elPR7Y3XmGx37K66vLgw4UUSpw7WsYrXKuPFbJNSqLd7iqjGejZM9MWppCkfOdKtPC34 Uo9er0qA8UCfdMR35Bwt X-Received: by 2002:a17:90b:1b0b:b0:37f:e1b6:4c7d with SMTP id 98e67ed59e1d1-395c35ac458mr32281415a91.6.1787502881613; Sun, 23 Aug 2026 09:34:41 -0700 (PDT) Received: from Mac.net (198-27-228-154.fiber.dynamic.sonic.net. [198.27.228.154]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141860ef75esm17084319c88.7.2026.08.23.09.34.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 23 Aug 2026 09:34:41 -0700 (PDT) From: Ahmad Byagowi To: Andi Shyti Cc: Peter Rosin , Jakub Kicinski , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Ahmad Byagowi Subject: [PATCH v7 1/3] i2c: mux: Fix channel node leak on adapter add failure Date: Sun, 23 Aug 2026 09:34:36 -0700 Message-ID: X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit i2c_mux_add_adapter() takes a reference to the Device Tree channel node before registering the new adapter. If adapter registration fails, the error path frees the private data without dropping that reference. Release the channel node before freeing the private data. Fixes: bc45449b1444 ("i2c/of: Automatically populate i2c mux busses from device tree data.") Signed-off-by: Ahmad Byagowi --- drivers/i2c/i2c-mux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c index 681a201c239b..68a4c34b5987 100644 --- a/drivers/i2c/i2c-mux.c +++ b/drivers/i2c/i2c-mux.c @@ -408,6 +408,7 @@ int i2c_mux_add_adapter(struct i2c_mux_core *muxc, return 0; err_free_priv: + of_node_put(priv->adap.dev.of_node); kfree(priv); return ret; } -- 2.50.1 (Apple Git-155)