From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA173C53210 for ; Tue, 3 Jan 2023 11:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236931AbjACLLd (ORCPT ); Tue, 3 Jan 2023 06:11:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237290AbjACLLI (ORCPT ); Tue, 3 Jan 2023 06:11:08 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6222CBC86 for ; Tue, 3 Jan 2023 03:11:04 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id y25so45183219lfa.9 for ; Tue, 03 Jan 2023 03:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9D5LFOOL7M248RT3YKkgzKFTBRXhYh2dkwaJ1IaRHxA=; b=EnOEatK+DA5jF5hkgO1d9SjyfsSx+JiDXvYMOfqMv+LZMR6PCSVgIVzkVR58uboHuD qeDlDmM7YhSAjXKD0MUkL+bsKd0nAjQoXKlLEliz8pFBAu894A9JJjYiW/y4VrnhYdlT Rya9NYCDUqRobuLp/HaPfCwfndMc56IcsUPtfQXI0zmqc3/AD+cnQ1uBizkLuNQUFOEb xnjtEH8onQteF23DbXjfYq48XFV+OUj5/QKDmNKebwbWMX3qAYAYjk9P8m2c5sSsPCoo jsk98/REB0LQ3eeGj2WJhFRdl+vP5GHD//P2d+bCyvIZhsLlujymbK5JPJH7YOhoh7si vz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9D5LFOOL7M248RT3YKkgzKFTBRXhYh2dkwaJ1IaRHxA=; b=binmDDFcMl3adedLLI/9EtBkex8D6eXFBFoId0d5Rvn9a+cqzPGjnDYbOgXo/mWMo6 w+WFSAF0JoOV0piYRBAbRXk4nDtyDurNB4NcUTCJA0lJki8JHXLE3X/JvxWaajmdHOFS nC4G87h0wFM5CwnjG/K1/5GiTOiFlGk1OuzzMb68MhhLlFFgT0zYLAe5LOvFa+EuMWAN Rxq8n3alPeVM5KgzWeyZyCssgnDvbVsD+48c3qRKWPn1OZmpqd/vgIYaviWIJxr9fCQb wRtPsGSqA2s5xcGXgD5dHPBPoD1FvBV1N/KhofYVxazOEIjWgqqSv6pxl3HIPKuncpvK 22/g== X-Gm-Message-State: AFqh2korUfyH0BFW6LDxFNGINqk7TqrNVSDLQC5V05KpJQzBrteeK01A cBTsagz/ISa7JZbAM8U1Evcp5g== X-Google-Smtp-Source: AMrXdXuAKQ0YTIV1hBpWs/3wrPMP3yAYJaFJ9eyf/qO07z2O81ePy+C/Oezlg0JBhGYsf5BvJNWYhA== X-Received: by 2002:ac2:5b41:0:b0:4a4:68b9:66dd with SMTP id i1-20020ac25b41000000b004a468b966ddmr12722492lfp.40.1672744262769; Tue, 03 Jan 2023 03:11:02 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w16-20020a05651234d000b004b57a253deasm4792967lfr.162.2023.01.03.03.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 03:11:02 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 12:11:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/5] arm64: dts: fsd: Add codec node for Tesla FSD Content-Language: en-US To: Padmanabhan Rajanbabu , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, s.nawrocki@samsung.com, perex@perex.cz, tiwai@suse.com, pankaj.dubey@samsung.com, alim.akhtar@samsung.com, rcsekar@samsung.com, aswani.reddy@samsung.com Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20230103045613.100309-1-p.rajanbabu@samsung.com> <20230103045613.100309-5-p.rajanbabu@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230103045613.100309-5-p.rajanbabu@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote: > Add device tree node support for codec on Tesla FSD platform. > > Signed-off-by: Padmanabhan Rajanbabu > --- > arch/arm64/boot/dts/tesla/fsd-evb.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts > index cf5f2ce4d2a7..e2fd49774f15 100644 > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > @@ -10,6 +10,7 @@ > > /dts-v1/; > #include "fsd.dtsi" > +#include > > / { > model = "Tesla Full Self-Driving (FSD) Evaluation board"; > @@ -34,6 +35,18 @@ > clock-frequency = <24000000>; > }; > > +&hsi2c_5 { > + status = "okay"; > + > + tlv320aic3x: codec@18 { > + #sound-dai-cells = <0>; > + compatible = "ti,tlv320aic3104"; > + reg = <0x18>; First compatible, then reg, then the rest. > + reset-gpios = <&gpg1 6 GPIO_ACTIVE_LOW>; > + status = "okay"; It's by default. Why do you need it? Best regards, Krzysztof