From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiasheng Jiang <jiashengjiangcool@gmail.com>,
sylvester.nawrocki@gmail.com, mchehab@kernel.org,
dron0gus@gmail.com, tomasz.figa@gmail.com,
alim.akhtar@samsung.com, kyungmin.park@samsung.com,
laurent.pinchart@ideasonboard.com
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: mipi-csis: Add check for clk_enable()
Date: Fri, 22 Nov 2024 08:01:39 +0100 [thread overview]
Message-ID: <b3ef3855-f95f-43ad-9a2a-3803c1f00046@kernel.org> (raw)
In-Reply-To: <20241121210543.8190-2-jiashengjiangcool@gmail.com>
On 21/11/2024 22:05, Jiasheng Jiang wrote:
> Add check for the return value of clk_enable() to gurantee the success.
>
> Fixes: b5f1220d587d ("[media] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
> drivers/media/platform/samsung/exynos4-is/mipi-csis.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> index 63f3eecdd7e6..d1c938065475 100644
> --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> +++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> @@ -940,7 +940,9 @@ static int s5pcsis_pm_resume(struct device *dev, bool runtime)
> state->supplies);
> goto unlock;
> }
> - clk_enable(state->clock[CSIS_CLK_GATE]);
> + ret = clk_enable(state->clock[CSIS_CLK_GATE]);
> + if (ret)
> + goto unlock;
You should unwind the work done, so power off the phy and disble regulators.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-22 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 21:05 [PATCH 2/2] media: camif-core: " Jiasheng Jiang
2024-11-21 21:05 ` [PATCH 1/2] media: mipi-csis: " Jiasheng Jiang
2024-11-22 7:01 ` Krzysztof Kozlowski [this message]
2024-11-22 19:47 ` Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ef3855-f95f-43ad-9a2a-3803c1f00046@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=dron0gus@gmail.com \
--cc=jiashengjiangcool@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®