From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C0FC433F5 for ; Thu, 24 Feb 2022 08:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbiBXIyu (ORCPT ); Thu, 24 Feb 2022 03:54:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232062AbiBXIyr (ORCPT ); Thu, 24 Feb 2022 03:54:47 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497E4163062; Thu, 24 Feb 2022 00:54:18 -0800 (PST) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id C1FB122239; Thu, 24 Feb 2022 09:54:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1645692856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZvkcoUKllQj2T4+MNV6kXQ3nLOUi8Q7r2MLGcdGUqmY=; b=RBInsJPHuWavYhtDil26uHxuu1hhkXEIy8BK9iZ7Gqbb0NEctvhoVGEPGErHLnVGbznh6m CCB2eo37CSiFwVfhtG/l4bHYj8aczvSJLIAgxX1PlM+kXD4C/xywD/5II4iBMgUbotl7Sq eKne8tpz6DqzFLwtJ43OtBoLdquy9E4= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 24 Feb 2022 09:54:15 +0100 From: Michael Walle To: Heiko Thiery Cc: Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Shawn Guo Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs In-Reply-To: References: <20220223210559.1999209-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-02-24 08:29, schrieb Heiko Thiery: > Hi, > > Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle > : >> >> Use the power signal names as given in the schematics of the reference >> board. >> >> Signed-off-by: Michael Walle >> --- >> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 >> ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts >> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts >> index b4225cfcb6d9..eaa06f49aef5 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts >> @@ -41,7 +41,7 @@ pmic: pmic@25 { >> >> regulators { >> buck1: BUCK1{ >> - regulator-name = "BUCK1"; >> + regulator-name = "VDD_ARM_0V9"; > > I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC". > >> regulator-min-microvolt = <600000>; >> regulator-max-microvolt = <2187500>; >> regulator-boot-on; >> @@ -50,7 +50,7 @@ buck1: BUCK1{ >> }; >> >> buck2: BUCK2 { >> - regulator-name = "BUCK2"; >> + regulator-name = "VDD_SOC"; > > And this should be "VDD_ARM_0V9". You are absolutely right. I noticed it on the 8MNANOD3L-EVK but forgot to update these. -michael