From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B47CC433E2 for ; Mon, 22 Mar 2021 17:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F8FB6199E for ; Mon, 22 Mar 2021 17:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbhCVR1w (ORCPT ); Mon, 22 Mar 2021 13:27:52 -0400 Received: from m-r1.th.seeweb.it ([5.144.164.170]:45459 "EHLO m-r1.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbhCVR1W (ORCPT ); Mon, 22 Mar 2021 13:27:22 -0400 Received: from [192.168.1.101] (abac242.neoplus.adsl.tpnet.pl [83.6.166.242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 02EE31F3D9; Mon, 22 Mar 2021 18:27:14 +0100 (CET) Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support To: Robert Foss , agross@kernel.org, bjorn.andersson@linaro.org, amitk@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul References: <20210322100420.125616-1-robert.foss@linaro.org> <20210322100420.125616-2-robert.foss@linaro.org> From: Konrad Dybcio Message-ID: Date: Mon, 22 Mar 2021 18:27:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322100420.125616-2-robert.foss@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > + tsens0: thermal-sensor@c222000 { > + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2"; > + reg = <0 0x0C263000 0 0x1ff>, /* TM */ > + <0 0x0C222000 0 0x8>; /* SROT */ Please use lowercase hex > + tsens1: thermal-sensor@c223000 { > + compatible = "qcom,sm8350-tsens", "qcom,tsens-v2"; > + reg = <0 0x0C265000 0 0x1ff>, /* TM */ > + <0 0x0c223000 0 0x8>; /* SROT */ Ditto > + trips { > + cpu0_alert0: trip-point0 { > + temperature = <90000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu0_alert1: trip-point1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "passive"; Shouldn't this be "hot"? Possibly ditto for all cpu*alert1-labeled nodes. > + }; > + > + cpu0_crit: cpu_crit { > + temperature = <110000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; These values seem, err.. scorching hot.. Are they alright? > + // TODO: What is the NSP subsystem? Please use C-style comments (/* foo */) Konrad