From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbdDNTvz (ORCPT ); Fri, 14 Apr 2017 15:51:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:22865 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbdDNTvx (ORCPT ); Fri, 14 Apr 2017 15:51:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,200,1488873600"; d="scan'208";a="74234667" Subject: Re: [PATCH] x86/mpx, selftests: Only check bounds-vs-shadow when we keep shadow To: Joerg Roedel , Shuah Khan , Ingo Molnar References: <1491488598-27346-1-git-send-email-joro@8bytes.org> Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel From: Dave Hansen Message-ID: Date: Fri, 14 Apr 2017 12:51:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1491488598-27346-1-git-send-email-joro@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2017 07:23 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The check between the hardware state and our shadow of it is > checked in the signal handler for all bounds exceptions, > even for the ones where we don't keep the shadow up2date. > This is a problem because when no shadow is kept the handler > fails at this point and hides the real reason of the > exception. > > Move the check into the code-path evaluating normal bounds > exceptions to prevent this. Looks good to me. Acked-by: Dave Hansen