From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Henrik Grimler" <henrik@grimler.se>,
"Chanwoo Choi" <cw00.choi@samsung.com>
Subject: Re: [PATCH 5/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos4412
Date: Fri, 3 Feb 2023 12:45:09 +0100 [thread overview]
Message-ID: <b3f31e71-fa1a-e0c0-fdfa-f65674ccc5cd@samsung.com> (raw)
In-Reply-To: <29841f64-360b-1426-e1fd-dd4c64ee5455@linaro.org>
Hi Krzysztof,
On 29.01.2023 11:42, Krzysztof Kozlowski wrote:
> On 25/01/2023 10:45, Krzysztof Kozlowski wrote:
>> The soc node is supposed to have only device nodes with MMIO addresses,
>> as reported by dtc W=1:
>>
>> exynos4412.dtsi:407.20-413.5:
>> Warning (simple_bus_reg): /soc/bus-acp: missing or empty reg/ranges property
>>
>> and dtbs_check:
>>
>> exynos4412-i9300.dtb: soc: bus-acp:
>> {'compatible': ['samsung,exynos-bus'], 'clocks': [[7, 456]], 'clock-names': ['bus'], 'operating-points-v2': [[132]], 'status': ['okay'], 'devfreq': [[117]]} should not be valid under {'type': 'object'}
>>
>> Move the bus nodes and their OPP tables out of SoC to fix this.
>> Re-order them alphabetically while moving and put some of the OPP tables
>> in device nodes (if they are not shared).
>>
> Applied.
I don't have a good news. It looks that this change is responsible for
breaking boards that were rock-stable so far, like Odroid U3. I didn't
manage to analyze what exactly causes the issue, but it looks that the
exynos-bus devfreq driver somehow depends on the order of the nodes:
(before)
# dmesg | grep exynos-bus
[ 6.415266] exynos-bus: new bus device registered: soc:bus-dmc
(100000 KHz ~ 400000 KHz)
[ 6.422717] exynos-bus: new bus device registered: soc:bus-acp
(100000 KHz ~ 267000 KHz)
[ 6.454323] exynos-bus: new bus device registered: soc:bus-c2c
(100000 KHz ~ 400000 KHz)
[ 6.489944] exynos-bus: new bus device registered: soc:bus-leftbus
(100000 KHz ~ 200000 KHz)
[ 6.493990] exynos-bus: new bus device registered: soc:bus-rightbus
(100000 KHz ~ 200000 KHz)
[ 6.494612] exynos-bus: new bus device registered: soc:bus-display
(160000 KHz ~ 200000 KHz)
[ 6.494932] exynos-bus: new bus device registered: soc:bus-fsys
(100000 KHz ~ 134000 KHz)
[ 6.495246] exynos-bus: new bus device registered: soc:bus-peri (
50000 KHz ~ 100000 KHz)
[ 6.495577] exynos-bus: new bus device registered: soc:bus-mfc
(100000 KHz ~ 200000 KHz)
(after)
# dmesg | grep exynos-bus
[ 6.082032] exynos-bus: new bus device registered: bus-dmc (100000
KHz ~ 400000 KHz)
[ 6.122726] exynos-bus: new bus device registered: bus-leftbus
(100000 KHz ~ 200000 KHz)
[ 6.146705] exynos-bus: new bus device registered: bus-mfc (100000
KHz ~ 200000 KHz)
[ 6.181632] exynos-bus: new bus device registered: bus-peri ( 50000
KHz ~ 100000 KHz)
[ 6.204770] exynos-bus: new bus device registered: bus-rightbus
(100000 KHz ~ 200000 KHz)
[ 6.211087] exynos-bus: new bus device registered: bus-acp (100000
KHz ~ 267000 KHz)
[ 6.216936] exynos-bus: new bus device registered: bus-c2c (100000
KHz ~ 400000 KHz)
[ 6.225748] exynos-bus: new bus device registered: bus-display
(160000 KHz ~ 200000 KHz)
[ 6.242978] exynos-bus: new bus device registered: bus-fsys (100000
KHz ~ 134000 KHz)
This is definitely a driver bug, but so far it worked fine, so this is a
regression that need to be addressed somehow...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2023-02-03 11:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 9:45 [PATCH 1/9] ARM: dts: exynos: correct HDMI phy compatible in Exynos4 Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 2/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos5420 Krzysztof Kozlowski
2023-01-26 9:47 ` Marek Szyprowski
2023-01-26 10:59 ` Krzysztof Kozlowski
2023-01-28 10:43 ` Krzysztof Kozlowski
2023-01-28 22:55 ` Marek Szyprowski
2023-01-29 10:41 ` Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 3/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos3250 Krzysztof Kozlowski
2023-01-29 10:41 ` Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 4/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos4210 Krzysztof Kozlowski
2023-01-29 10:42 ` Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 5/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos4412 Krzysztof Kozlowski
2023-01-29 10:42 ` Krzysztof Kozlowski
2023-02-03 11:45 ` Marek Szyprowski [this message]
2023-02-03 11:46 ` Krzysztof Kozlowski
2023-02-03 11:51 ` Marek Szyprowski
2023-02-03 20:34 ` Krzysztof Kozlowski
2023-02-03 21:12 ` Krzysztof Kozlowski
2023-02-03 22:50 ` Marek Szyprowski
2023-02-06 16:12 ` Krzysztof Kozlowski
2023-03-24 17:07 ` Marek Szyprowski
2023-03-24 18:52 ` Krzysztof Kozlowski
2023-02-03 11:53 ` Markus Reichl
2023-01-25 9:45 ` [PATCH 6/9] ARM: dts: exynos: use generic node names for phy Krzysztof Kozlowski
2023-01-26 10:17 ` (subset) " Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 7/9] ARM: dts: exynos: use lowercase hex addresses Krzysztof Kozlowski
2023-01-26 10:17 ` (subset) " Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 8/9] arm64: dts: exynos: move exynos-bus nodes out of soc in Exynos5433 Krzysztof Kozlowski
2023-01-25 9:45 ` [PATCH 9/9] arm64: dts: exynos: use lowercase hex addresses Krzysztof Kozlowski
2023-01-26 10:17 ` (subset) " Krzysztof Kozlowski
2023-01-26 10:17 ` (subset) [PATCH 1/9] ARM: dts: exynos: correct HDMI phy compatible in Exynos4 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f31e71-fa1a-e0c0-fdfa-f65674ccc5cd@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=kgene@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=replicant@osuosl.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®