mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Abreu <jose.abreu@synopsys.com>
To: "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@nokia.com>,
	Jose Abreu <jose.abreu@synopsys.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	"David S. Miller" <davem@davemloft.net>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: fix memory corruption with large MTUs
Date: Tue, 19 Mar 2019 14:42:32 +0000	[thread overview]
Message-ID: <b3f61517-3d6d-dc20-fd50-6ac98e0b9dd4@synopsys.com> (raw)
In-Reply-To: <DB6PR0701MB2487FF2B8D4C0219DD209952F4400@DB6PR0701MB2487.eurprd07.prod.outlook.com>

On 3/19/2019 11:07 AM, Koskinen, Aaro (Nokia - FI/Espoo) wrote:
> Hi,
> 
> From: Jose Abreu [jose.abreu@synopsys.com]:
>> On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
>>>       /* Fill DES3 in case of RING mode */
>>> -     if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
>>> +     if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>>
>> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?
> 
> I think it should be the same as in stmmac_init_rx_buffers():
> 
>         if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>                 stmmac_init_desc3(priv, p);
> 
> A.
> 

Hmm, yeah makes sense. I was under impression that XGMAC had a >
16KB buffer but I was wrong.

This change looks okay then.

Acked-by: Jose Abreu <joabreu@synopsys.com>

Thanks,
Jose Miguel Abreu

  reply	other threads:[~2019-03-19 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 21:36 Aaro Koskinen
2019-03-19 10:36 ` Jose Abreu
2019-03-19 11:07   ` Koskinen, Aaro (Nokia - FI/Espoo)
2019-03-19 14:42     ` Jose Abreu [this message]
2019-03-19 20:33 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3f61517-3d6d-dc20-fd50-6ac98e0b9dd4@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=aaro.koskinen@nokia.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®