From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7498E35DA78 for ; Fri, 13 Mar 2026 17:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421716; cv=none; b=uPCblT4ipdVV/trDoBi9LyXUcEGPdaQBO2Uy1w982NLfyHfyiIrI4btLLqf/f5ZzTfa9xQzCk1SPYSIeFmhEng6QUM70vgXuIWVwpf/PESB+cOXkGM8PieZEh8kmfK3KIDmoV95zdbKnJOrAPT7Gj0fWOqNklKAS1wmEkrhO4bM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773421716; c=relaxed/simple; bh=na5aIQmd51a6vTVSTeVTzISuG98aQ2mjt0ZNjgjSa4M=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=dXl5PHEzESNq3iCOiAUGNrTcun8CY9XUHDd2tdGy2gQTrkRtS7q903LI3EN1lbZ1lTXs3U677/cQNV+jvJqjDvzx3A85OeNShK9X2SqZYyjS0OXZ1exvAw9iO2/WQbOKXhmJENg89Lji2SwNVz6ChdHWDYJNSFnWT4M1FW/Qi10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=WzdSk1mR; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WzdSk1mR" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8cd8347d9fdso313977185a.1 for ; Fri, 13 Mar 2026 10:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773421712; x=1774026512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=q2wUEHO95agDl9HgpTnHWh4fawNLMxRmnfJlPuyaoJY=; b=WzdSk1mRSe4L1cDGWT8I7i8ZnAHVbDgiDCtkOsUbizgieDi/uHO8Dyb1XIdczqlaJg m0pD9LIJ4Zg9onbtQdH49fv5Y4WLgre/e7Z9xU9rLPwkUUY3XpDD9h1f4sOWcCbBoV7V V3wJTLCW5Xy7Yc3LACf8lDYXmvtDIcXVfk4OvW2+LNH9QKssMWW1th1FnXqUILQu3M8+ ZrqWpwN1XLxtJ/e8a5WgZzYcJJBFgfV+haZG2FLckxGStVisoZ7Sw5vDpkfO4pd2yIv9 Tntnw347t7xwzaIxArnuKbFn0nBZxV6YIp+Voxsl1OoiYepJhCN9yGHwPeRWgO93mZDB TDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773421712; x=1774026512; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q2wUEHO95agDl9HgpTnHWh4fawNLMxRmnfJlPuyaoJY=; b=izlXNlNNYGOfhsAKeVrT5MQP4iDW4vfbmzQAj0DdF8W+B9LGDs3vV/j5jiEXv0p04l FzD8aX5EzNhjCpiZWsfAv7+gy2Wc9SVIAd0ulhgre/aqlomWudc22kWJb68WnxZ0QQHy oE4TzJ8u479kD2Nt7/RuyLGKmW8OQzBO28z4dkRv91gs58m0JcvSQUCL8hXOomFgtS7Z XRSFBIrsHivsuq4vl+2uAXnqvoLzH/6iWzT0BShdb+oD/DOeA+clgaUEa9XhQK754NdX d653jKeVK2cb0RZwAxI6L3Vw1E4FNbIhRorxFx5C0zv9ygpN+HpGJbAh3roh/HzOc88w ml6A== X-Forwarded-Encrypted: i=1; AJvYcCWrofECONa2lT50hluWkcH3eYIS0rTyNpIaOCv6kCZMq7nlpL9KvdwRc7+aQaqWXf6RkFVxjeiJgB511/w=@vger.kernel.org X-Gm-Message-State: AOJu0YywzozFA5RSZ3hLrV6FoEw1ex9E2LLQ9I+DJOfv1EZENX6tS25k G7t0A0Jf6Mud1otuSZbSVgxyCUI0gVeKkHuV2GMAli0+l/FCcX3S0FATflYbcDUBrkA= X-Gm-Gg: ATEYQzy+NIBphWAL9wLyAFXZKqaT8aEk50BpMvXzE34f+ZEgkiYHz0usFGKvRwU50xV 959k7T7Mji9exzCpegD+6OcI3UnIFJtVXy/rpQUNUGo+JbsEWpmnw3/s+jgL9ER0ULnbOc31MMA eyJpgVZkXhj/QiekiDhYP2c3I84oorBchfV8Gp1j4WQnmtLdxfPBE3X6e9d3RZaTYHX3TgbKlS8 YTTWi1AgY0xCPn+Aj01uU9+UeJU0vclIOUUl307MhOWwYV2QpR7W6x1eef1T/8VcZb1zXDQ77MM tkAofuI1Uv2zLb+hB6rfcqrJTXqE95gY11W7UJvwRv7IaETUsUwah8FSTdAFRn4VH0bWjrSX0EF 2ghWPdaYyv6J35XWG5sflIS+KebLzbdLjLS0PnF1scWlsSJXS7kedq/rjlLUJq0bkrOLo0bVc2l 5VC76eOrBdeJmPT6Kw8fc6znZLmR2S8ZumwSlwAMIeI33Qd7yfBkIAADPm26wLgppYaJDVcbwhF w/x X-Received: by 2002:a05:620a:1a19:b0:8cd:90d5:92c with SMTP id af79cd13be357-8cdb59fe41amr594805385a.12.1773421712407; Fri, 13 Mar 2026 10:08:32 -0700 (PDT) Received: from ?IPV6:2001:1970:3847:e000:4c82:63a9:39e9:5c17? ([2001:1970:3847:e000:4c82:63a9:39e9:5c17]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda1fda2c6sm583719685a.13.2026.03.13.10.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 10:08:31 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 13:08:29 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Trevor Gamblin Subject: Re: [PATCH v2 7/7] riscv: dts: spacemit: k1-orangepi-rv2: add SD card support with UHS modes To: Anand Moon Cc: Iker Pedrosa , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Michael Opdenacker , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260309-orangepi-sd-card-uhs-v2-0-5bb2b574df5d@gmail.com> <20260309-orangepi-sd-card-uhs-v2-7-5bb2b574df5d@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-03-13 10:42, Anand Moon wrote: > Hi Trevor, > > On Fri, 13 Mar 2026 at 19:26, Trevor Gamblin wrote: >> On 2026-03-09 07:40, Iker Pedrosa wrote: >>> Add complete SD card controller support with UHS high-speed modes. >>> >>> - Enable sdhci0 controller with 4-bit bus width >>> - Configure card detect GPIO with inversion >>> - Connect vmmc-supply to buck4 for 3.3V card power >>> - Connect vqmmc-supply to aldo1 for 1.8V/3.3V I/O switching >>> - Add dual pinctrl states for voltage-dependent pin configuration >>> - Support UHS-I SDR25, SDR50, and SDR104 modes >>> >>> This enables full SD card functionality including high-speed UHS modes >>> for improved performance. >>> >>> Signed-off-by: Iker Pedrosa >>> --- >>> arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts >>> index 414b03f5e6480f05f5d7eeaaa0afb4e86425ae36..361135269801f436703b6f1d768c91325a52f07f 100644 >>> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts >>> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts >>> @@ -140,3 +140,22 @@ sd_vqmmc: aldo1 { >>> }; >>> }; >>> }; >>> + >>> +&sdhci0 { >>> + pinctrl-names = "default", "state_uhs"; >>> + pinctrl-0 = <&mmc1_cfg>; >>> + pinctrl-1 = <&mmc1_uhs_cfg>; >>> + bus-width = <4>; >>> + cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>; >>> + cd-inverted; >>> + no-mmc; >>> + no-sdio; >>> + disable-wp; >>> + cap-sd-highspeed; >>> + vmmc-supply = <&sd_vmmc>; >>> + vqmmc-supply = <&sd_vqmmc>; >>> + sd-uhs-sdr25; >>> + sd-uhs-sdr50; >>> + sd-uhs-sdr104; >>> + status = "okay"; >>> +}; >>> >> Hello again, >> >> Thanks for doing this work. My colleagues and I have been testing this >> on an OrangePi RV2, and also a Muse Pi Pro board (making a similar tweak >> to this patch in k1-musepi-pro.dts). To do the testing on my end, I'm >> applying the patch series on top of 6.19 in a Yocto BSP. >> >> I've been finding that I see issues with the UHS support on my side >> (this log comes from an image built and flashed to an SD card): >> >> >> [ 1.072417] sdhci-spacemit d4280000.mmc: Got CD GPIO >> [ 1.109741] mmc0: SDHCI controller on d4280000.mmc [d4280000.mmc] using >> ADMA >> [ 1.114589] clk: Disabling unused clocks >> [ 1.118421] PM: genpd: Disabling unused power domains >> [ 1.123249] ALSA device list: >> [ 1.126[ 1.129949] check access for rdinit=/init failed: -2, ignoring >> [ 1.133284] Waiting for root device >> PARTUUID=e94bfdd7-a36f-4315-a480-476e2a12403d... >> [ 1.176569] mmc0: new UHS-I speed DDR50 SDHC card at address aaaa >> [ 1.180732] mmcblk0: mmc0:aaaa SS16G 14.8 GiB >> [ 1.276268] mmcblk0: recovery failed! >> [ 1.277351] I/O error, dev mmcblk0, sector 0 op 0x0:(READ) flags >> 0x800000 phys_seg 1 prio class 2 >> [ 1.286346] Buffer I/O error on dev mmcblk0, logical block 0, async page >> read >> [ 1.293891] mmcblk0: recovery failed! >> [ 1.297289] I/O error, dev mmcblk0, sector 0 op 0x0:(READ) flags >> 0x800000 phys_seg 1 prio class 2 >> [ 1.306269] Buffer I/O error on dev mmcblk0, logical block 0, async page >> read >> [ 1.313522] mmcblk0: unable to read partition table >> >> >> At first I wondered if maybe there was an issue with the card itself, >> but by changing the sdhci0 section to this, I'm able to read the SD just >> fine: >> > I used the same example on the K1-OrangePi-RV2 DTS, > But it’s slightly different from the one you’re working with. > I tested on the latest 7.0-rc3. > >> &sdhci0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&mmc1_cfg>; >> bus-width = <4>; >> cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>; >> cd-inverted; >> no-mmc; >> no-sdio; >> disable-wp; >> vmmc-supply = <&sd_vmmc>; >> vqmmc-supply = <&sd_vqmmc>; >> no-1-8-v; >> status = "okay"; >> }; >> > + > +&sdhci0 { > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc1_cfg>; > + pinctrl-1 = <&mmc1_uhs_cfg>; > + bus-width = <4>; > + cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>; > + cd-inverted; > + no-mmc; > + no-sdio; > + disable-wp; > + cap-sd-highspeed; > + vmmc-supply = <&sd_vmmc>; > + vqmmc-supply = <&sd_vqmmc>; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + status = "okay"; > +}; > > Thanks > -Anand Yes, my mistake - with 7.0-rc3 it works for me: [    1.071767] sdhci-spacemit d4280000.mmc: Got CD GPIO [    1.110368] mmc0: SDHCI controller on d4280000.mmc [d4280000.mmc] using ADMA [    1.115231] clk: Disabling unused clocks [    1.119072] PM: genpd: Disabling unused power domains [    1.123875] ALSA device list: [    1.1268[    1.130718] Waiting for root device PARTUUID=e94bfdd7-a36f-4315-a480-476e2a12403d... [    1.181158] mmc0: new UHS-I speed DDR50 SDHC card at address aaaa [    1.185341] mmcblk0: mmc0:aaaa SS16G 14.8 GiB [    1.198009] GPT:Primary header thinks Alt. header is not at the end of the disk. [    1.202874] GPT:1134331 != 31116287 [    1.206388] GPT:Alternate GPT header not at the end of the disk. [    1.212468] GPT:1134331 != 31116287 [    1.215993] GPT: Use GNU Parted to correct GPT errors. [    1.221230]  mmcblk0: p1 p2 p3 [    1.529978] EXT4-fs (mmcblk0p3): mounted filesystem dbc76877-092e-4f8a-9f06-bf286309d8de r/w with ordered data mode. Quota mode: disabled. [    1.540069] VFS: Mounted root (ext4 filesystem) on device 179:3. In which case: Tested-by: Trevor Gamblin