From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F089215F5C for ; Mon, 19 Jan 2026 01:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768787105; cv=none; b=qlvry2nHOjA50zxpXRWRuuikxThiwbtlMM72WQeYao+RI+bniisuN2sjmH1ACiWNKtK9tY0Fb7qBeoOY82Qn3y6fD1H42I+MB6/1+MOBZSnKz+z0jW8I/vF8equKJ5abWKgRPDLOKhPJOLEGkFXLzz5lJaTyPhQEMZSBTd8AgvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768787105; c=relaxed/simple; bh=N6/5EVm2AcMQT1kye/rQbhIFzqexVCwNT6WeSrv3aPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qccm45ooW+7aG+r08qkcQeKjY3y9xKHCm4gD8rtmzIQwB08K2ncp82DhpmYi7lwxDkS65bthpJ32yQj5P0EsEc9ijZSxcBIXOl8a+d4+oj9WxJZzcjo/1PZ83Pcf4PuhkZ8vLGbe3DsQuO5eC45rwxcTZGK2yXQM7Oqxrh7Adnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G5PheNVZ; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5PheNVZ" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2ad70765db9so3779408eec.1 for ; Sun, 18 Jan 2026 17:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768787103; x=1769391903; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=s87tThxbZd/DcmcnvOZNycySqw7quHQWIM3ahwKwjr0=; b=G5PheNVZdfbNLJvtZUp4n0KFcv/7jlgPcpNvMXf+cr/0HamgOFwVO7HJS3dUk5RiQb HNscq7QNwfRgWlrC7Se0CzVwOlOHL6R7YEQIiqhV7Rqsa8dfRjbJKEb9QnAkZd0L+QbD euXOp7KPRTXB5SCFWa1h8KxNR8EumTUNspz/XVpC1x8vR7dEjACjUtmj2sd/8+nYjM3V GvBdAHik3En8Q9mXz38j81t4idEK+brDzU8uooWsL3boe31r5OE5n2chey+mGFZYjH8Y 2ijr/xUlg1gPpvjTiDbuT3PiVEmu3CW/5k/d3wcF4f3obXqzmbUKueXl3Nh2xfY9PWDV Zgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768787103; x=1769391903; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s87tThxbZd/DcmcnvOZNycySqw7quHQWIM3ahwKwjr0=; b=Whepy/ZhvztZL7iDjH6EGlXpPQOj5XWE9hqZ4hiZ2uw+ueASI1h01Vu+wLsQl9pqx0 AOv53pLH4nDu5z1RdjFasiEgFqqK9nph4+JI9t3D1kI1fZQGampfVwVqTMH/AnFoXTt1 swFNQDVRC0QXaWzaCrGe2nVxCG0JSmDGlVM+EVdtJHnnoSyhLbAW3DBXw5qwOBKPsGRp n6nSPWpmlPJSOUwxDXhj7HvOze9ZumXBB6KHkDNLnNlEJrsZmuK7gGhN3JHyFwGMBFlb VuZ1C92x/hgVM+IX8Vn1tbS5bViu3a6c8JOA7gOfzx4v/OY4QNiEFZejE/MYOK+2epbT xc2g== X-Forwarded-Encrypted: i=1; AJvYcCX36h+A85bjU3oL1kBg9FuqqNu9Q/xb83D0IlJ0g2mxF/5UG1tg94M92ejkDYJYARWOCWrvcs4paJIZhjw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjhe8ZLa/RBHOFPfCexArbigrzbuDQ5+5/4w/y9yHNP6EQjOJy 7IZPZ3hf+4ymFMn738/0J1H+vFKiFQohzFBlxde1oHyRXg0ocp61d6JQ X-Gm-Gg: AY/fxX4vwXfmqAPanMHRCztNu8HQnMw3UrKk9GIVJQtLWo45vJ904q6ShPQcLErNvlN gR7FKlngDgeXk0PUsP9+xIfRL+PjV3Z/vnDCNrTzGiNdsx8T1d7jkjcCzcOIue7+HmYwk2xQnMA iPsyHLWK/JQjK5GmapjaUH8EHPaz8er3xASVKFRfSnFDaNeLkhs8HlxPbF0EeRJQ1RxdQKxf/iJ qMan9JlqiOuGM3jT4MdvHTIzJnIarlac4mk9tJAfvF4wJ3IUM6etE/Yqiscly7fAvkETdV/mTFa fQfNC3NU7HvDRIDEV+qSmzLqLq2JrxWh9UpPjVtWtGPWztHtN4Wj8bXqrZacYKSe+6Sxf7A2bjS MHkmeGorp+Uf/5Gb44WAJ5EJ9g3mmbP3Rgzel8p9kAzvy6fDH0yJ2KeVUBMx0wqG5MhBsaq6nXf u6DnJ+SR4/x7P71Eu4nQleIttB7EPHfEmscSig9v02h82tg8pwXeWG6bOQset8 X-Received: by 2002:a05:7300:6c15:b0:2ae:5b27:d182 with SMTP id 5a478bee46e88-2b6b4e5b5a3mr6897836eec.12.1768787103297; Sun, 18 Jan 2026 17:45:03 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b34c11c4sm11050254eec.1.2026.01.18.17.45.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jan 2026 17:45:02 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Sun, 18 Jan 2026 17:45:00 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] hwmon: (tmp108) Add support for P3T1035 and P3T2030 To: Frank Li Cc: Mayank Mahajan , corbet@lwn.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, priyanka.jain@nxp.com, vikash.bansal@nxp.com References: <20260116113554.986-1-mayankmahajan.x@nxp.com> <20260116113554.986-2-mayankmahajan.x@nxp.com> <5e4c5665-9094-4ed0-9b7e-0d7c565ad33c@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Frank, On 1/18/26 09:30, Frank Li wrote: ... >>>> @@ -101,21 +120,7 @@ static int tmp108_read(struct device *dev, enum hwmon_sensor_types type, >>>> ®val); >>>> if (err < 0) >>>> return err; >>>> - switch (regval & TMP108_CONF_CONVRATE_MASK) { >>>> - case TMP108_CONVRATE_0P25HZ: >>>> - default: >>>> - *temp = 4000; >>>> - break; >>>> - case TMP108_CONVRATE_1HZ: >>>> - *temp = 1000; >>>> - break; >>>> - case TMP108_CONVRATE_4HZ: >>>> - *temp = 250; >>>> - break; >>>> - case TMP108_CONVRATE_16HZ: >>>> - *temp = 63; >>>> - break; >>>> - } >>>> + *temp = tmp108->sample_times[FIELD_GET(TMP108_CONF_CONVRATE_FLD, regval)]; >>> >>> This code optimation need seperate patch. >>> >> No, There are now two ranges, not just one. > > Previous code use swtich case to handle sample. now convert to use a map > array tmp108_sample_times[]. > > My means use a small patch convert existed switch case to map array firstly > , then add second range, which make code easy to review. > You are not signed up as reviewer of this driver. I am, and I don't want to see a separate patch just for this because it means extra work for me. Thanks, Guenter