From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753277AbdGFHnj (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Jul 2017 03:43:39 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34542 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752772AbdGFHni (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Jul 2017 03:43:38 -0400
Subject: Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed
 via ACPI namespace
To: Hanjun Guo <guohanjun@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>
References: <1499315732-63950-1-git-send-email-guohanjun@huawei.com>
Cc: linux-kernel@vger.kernel.org, Ma Jun <majun258@huawei.com>,
        Agustin Vega-Frias <agustinv@codeaurora.org>,
        John Garry <john.garry@huawei.com>, Hanjun Guo <hanjun.guo@linaro.org>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <b3fc8328-3929-7aac-8b59-da71401ab853@arm.com>
Date: Thu, 6 Jul 2017 08:43:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1499315732-63950-1-git-send-email-guohanjun@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/07/17 05:35, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> commit d59f6617eef0 (genirq: Allow fwnode to carry name information only)
> forgot to do "domain->fwnode = fwnode;" for irqchips being probed via
> ACPI namesapce (DSDT/SSDT), that will break platforms with irqchip such
> as mbigen or qcom irq combiner, set the fwnode back to fix the issue.
> 
> Reported-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  kernel/irq/irqdomain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 14fe862..1bc38fa 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -151,7 +151,6 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
>  			domain->flags |= IRQ_DOMAIN_NAME_ALLOCATED;
>  			break;
>  		default:
> -			domain->fwnode = fwnode;
>  			domain->name = fwid->name;
>  			break;
>  		}
> @@ -172,7 +171,6 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
>  		strreplace(name, '/', ':');
>  
>  		domain->name = name;
> -		domain->fwnode = fwnode;
>  		domain->flags |= IRQ_DOMAIN_NAME_ALLOCATED;
>  	}
>  
> @@ -196,6 +194,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
>  	INIT_RADIX_TREE(&domain->revmap_tree, GFP_KERNEL);
>  	domain->ops = ops;
>  	domain->host_data = host_data;
> +	domain->fwnode = fwnode;
>  	domain->hwirq_max = hwirq_max;
>  	domain->revmap_size = size;
>  	domain->revmap_direct_max_irq = direct_max;
> 

This doesn't seem right.

Why is is_fwnode_irqchip() returning false when presented with an
irqchip probed via the ACPI namespace? That's what you should consider
fixing instead of moving that code around.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...