From: Dave Hansen <dave.hansen@intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Lee Jones <lee@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: brgl@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/platform/geode: reference the real node of the cs5535 GPIO controller
Date: Thu, 21 May 2026 07:19:49 -0700 [thread overview]
Message-ID: <b4045ca5-8b4d-4b22-b97f-2414a1591d8f@intel.com> (raw)
In-Reply-To: <20260429-cs5535-swnode-v1-2-2bc5e17ddcf9@oss.qualcomm.com>
On 4/29/26 05:23, Bartosz Golaszewski wrote:
> We now can access the address of the software node associated with the
> GPIO controller cell of the cs5535 MFD device. Make it the target of the
> GPIO software node references in geode-common.c. Make sure the cs5535
> driver is built-in for all boards selecting GEODE_COMMON.
This looks like a good cleanup, but the changelog has me scratching my
head a bit.
I'm not quite sure what problem this is solving. It's also a bit unusual
to have a driver depend on another not being built as a module. There's
also not really a mention of the:
+MODULE_IMPORT_NS("CS5535");
in the changelog.
Oh, and on a minor note, it might all be more clear if the changelog was
written in imperative voice and removed the "We".
Honestly, this is old hardware so I don't want to fret about this too
much. I'd be happy to ack this, but I don't really know what I'm acking. ;)
next prev parent reply other threads:[~2026-05-21 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 12:23 [PATCH 0/2] x86/platform/geode: enable real fwnode GPIO lookup Bartosz Golaszewski
2026-04-29 12:23 ` [PATCH 1/2] mfd: cs5535: add, assign and expose the software node for the GPIO cell Bartosz Golaszewski
2026-05-07 15:21 ` (subset) " Lee Jones
2026-05-11 7:54 ` Bartosz Golaszewski
2026-05-13 13:28 ` Lee Jones
2026-05-13 13:38 ` Bartosz Golaszewski
2026-05-19 12:05 ` Bartosz Golaszewski
2026-05-21 13:52 ` Lee Jones
2026-04-29 12:23 ` [PATCH 2/2] x86/platform/geode: reference the real node of the cs5535 GPIO controller Bartosz Golaszewski
2026-04-29 19:06 ` Dmitry Torokhov
2026-04-30 7:10 ` Bartosz Golaszewski
2026-05-21 14:03 ` Bartosz Golaszewski
2026-05-21 14:19 ` Dave Hansen [this message]
2026-05-22 8:25 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4045ca5-8b4d-4b22-b97f-2414a1591d8f@intel.com \
--to=dave.hansen@intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bp@alien8.de \
--cc=brgl@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hpa@zytor.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®