From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59202B9A7; Tue, 21 May 2024 18:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716316263; cv=none; b=hDq1sX2Id6iFDbluyCDf71XCWMsIjhiX5/mBYQute0FZe+8FrEb4y7Zafzt6S2BDU8VaJar//8SHiGyF684zYWF3omOyzjzsk/5mhX7edNft9XbIMOs6QmdezzRBS7kfino9TI0xW7TlZ2wjas0eI4gw8Vm7zMW1MzUBgzjq99Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716316263; c=relaxed/simple; bh=UzsGdwJz/Brc2hgT0ha+Ss2WZxJOw4KDyYb7rLojnz8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=AH3gjtMWYbq/B0Gx3ehMv1GYqCfmBwrfs4iSflqrCImW0NnSmNcDd1sbK+LYBrW/OHkdymCAzx+c7ogNtedIo1116vj9qS8tr+zDQJrfXkRSBvmOqYX1m7eFWSAyWt2TLFqeOfg6415ZCXK1n0Q8n+JalE6m15Mmr5rChNTBStU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WRoKrGrQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WRoKrGrQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 039D7C2BD11; Tue, 21 May 2024 18:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716316263; bh=UzsGdwJz/Brc2hgT0ha+Ss2WZxJOw4KDyYb7rLojnz8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=WRoKrGrQZOCjJuFjxcJt5qdA5n7OpRVziUqYEnc15RYyic+NZImF4s98u9PMiiuTr 18QobjbvQ5vs3AFanAADzoy1LIYstrJzvc0/C6Njfd+a5R4fh37UvTTkuqI6OmFiVT icb0xlGuM60UbeMVWPXidJGp/jfAnC8IMbW/WMdXEzltAefy9iQr4Fkvm8JpS/sQJl DDEPefAJ6TqHnGo0svWlYl4uFYM2id8vG3EmN4MIRcwbzbf+i1xQjuqCjXJ/xZqE20 a1UWn0bCGIMkXwJAqszVzB6888P7bULfz1rgq4kyi6yhHUzt5w8y9PsZKBT7bWe0pM zz7MSbWLDaOxw== Date: Tue, 21 May 2024 11:31:02 -0700 (PDT) From: Mat Martineau To: Yunsheng Lin cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck , Ayush Sawal , Eric Dumazet , Willem de Bruijn , Jason Wang , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , John Fastabend , Jakub Sitnicki , David Ahern , Matthieu Baerts , Geliang Tang , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Boris Pismenny , bpf@vger.kernel.org, mptcp@lists.linux.dev Subject: Re: [RFC v4 11/13] net: replace page_frag with page_frag_cache In-Reply-To: <20240515130932.18842-12-linyunsheng@huawei.com> Message-ID: References: <20240515130932.18842-1-linyunsheng@huawei.com> <20240515130932.18842-12-linyunsheng@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII On Wed, 15 May 2024, Yunsheng Lin wrote: > Use the newly introduced prepare/probe/commit API to > replace page_frag with page_frag_cache for sk_page_frag(). > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > .../chelsio/inline_crypto/chtls/chtls.h | 3 - > .../chelsio/inline_crypto/chtls/chtls_io.c | 100 ++++--------- > .../chelsio/inline_crypto/chtls/chtls_main.c | 3 - > drivers/net/tun.c | 44 ++---- > include/linux/sched.h | 4 +- > include/net/sock.h | 14 +- > kernel/exit.c | 3 +- > kernel/fork.c | 3 +- > net/core/skbuff.c | 59 +++++--- > net/core/skmsg.c | 22 +-- > net/core/sock.c | 46 ++++-- > net/ipv4/ip_output.c | 33 +++-- > net/ipv4/tcp.c | 35 ++--- > net/ipv4/tcp_output.c | 28 ++-- > net/ipv6/ip6_output.c | 33 +++-- > net/kcm/kcmsock.c | 30 ++-- > net/mptcp/protocol.c | 67 +++++---- > net/sched/em_meta.c | 2 +- > net/tls/tls_device.c | 139 ++++++++++-------- > 19 files changed, 349 insertions(+), 319 deletions(-) > Hi Yunsheng - The MPTCP content looks ok to me. The MPTCP regression tests pass as well. Acked-by: Mat Martineau