From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815AbeBGJWg (ORCPT ); Wed, 7 Feb 2018 04:22:36 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:41020 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbeBGJWb (ORCPT ); Wed, 7 Feb 2018 04:22:31 -0500 Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node To: Sekhar Nori , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring References: <20180206125806.19350-1-kishon@ti.com> <20180206125806.19350-16-kishon@ti.com> <210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com> CC: Mark Rutland , Russell King , , , , From: Kishon Vijay Abraham I Message-ID: Date: Wed, 7 Feb 2018 14:51:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote: > Kishon, > > On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: >> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. >> >> Signed-off-by: Kishon Vijay Abraham I > > Along with this, dont we need to have > > /delete-property/ mmc-hs200-1_8v; > > for eMMC on Beagle x15 which does not support HS200? > > Or are you planning to depend on lack of pinctrl entries for HS200 to > take care of that? right now it relies on lack of pinctrl entries but I think adding delete property is appropriate. Actually I missed porting the patch that adds /delete-property/. Thanks Kishon > > Thanks, > Sekhar > > >> --- >> arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 7bf33d522b14..feb496e7c5ef 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -1073,7 +1073,13 @@ >> status = "disabled"; >> pbias-supply = <&pbias_mmc_reg>; >> max-frequency = <192000000>; >> + sd-uhs-sdr104; >> + sd-uhs-sdr50; >> + sd-uhs-ddr50; >> + sd-uhs-sdr25; >> + sd-uhs-sdr12; >> cap-sd-highspeed; >> + mmc-ddr-1_8v; >> cap-mmc-highspeed; >> }; >> >> @@ -1092,6 +1098,10 @@ >> status = "disabled"; >> max-frequency = <192000000>; >> cap-sd-highspeed; >> + sd-uhs-sdr25; >> + sd-uhs-sdr12; >> + mmc-hs200-1_8v; >> + mmc-ddr-1_8v; >> cap-mmc-highspeed; >> }; >> >> -- >> 2.11.0 >> >